From: Andrew Lunn <andrew@lunn.ch>
To: Ciprian Regus <ciprian.regus@analog.com>
Cc: linux-kernel@vger.kernel.org, Nuno Sa <nuno.sa@analog.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Mark Brown <broonie@kernel.org>,
Yang Yingliang <yangyingliang@huawei.com>,
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
Dell Jin <dell.jin.code@outlook.com>,
netdev@vger.kernel.org
Subject: Re: [net-next v2] net: ethernet: adi: adin1110: Reduce the MDIO_TRDONE poll interval
Date: Tue, 27 Feb 2024 00:26:14 +0100 [thread overview]
Message-ID: <aaf490d5-e903-4638-9a7e-ab273b81df5e@lunn.ch> (raw)
In-Reply-To: <20240223162129.154114-1-ciprian.regus@analog.com>
On Fri, Feb 23, 2024 at 06:21:27PM +0200, Ciprian Regus wrote:
> In order to do a clause 22 access to the PHY registers of the ADIN1110,
> we have to write the MDIO frame to the ADIN1110_MDIOACC register, and
> then poll the MDIO_TRDONE bit (for a 1) in the same register. The
> device will set this bit to 1 once the internal MDIO transaction is
> done. In practice, this bit takes ~50 - 60 us to be set.
>
> The first attempt to poll the bit is right after the ADIN1110_MDIOACC
> register is written, so it will always be read as 0. The next check will
> only be done after 10 ms, which will result in the MDIO transactions
> taking a long time to complete. Reduce this polling interval to 100 us.
> Since this interval is short enough, switch the poll function to
> readx_poll_timeout_atomic() instead.
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-02-26 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 16:21 [net-next v2] net: ethernet: adi: adin1110: Reduce the MDIO_TRDONE poll interval Ciprian Regus
2024-02-26 23:26 ` Andrew Lunn [this message]
2024-02-27 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaf490d5-e903-4638-9a7e-ab273b81df5e@lunn.ch \
--to=andrew@lunn.ch \
--cc=amit.kumar-mahapatra@amd.com \
--cc=broonie@kernel.org \
--cc=ciprian.regus@analog.com \
--cc=davem@davemloft.net \
--cc=dell.jin.code@outlook.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pabeni@redhat.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox