From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 547DB38C2C5 for ; Wed, 4 Mar 2026 08:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772611653; cv=none; b=PFb5Fg+8uVbU+YLsKe7iWgVy5xLzM7MoNc75T65ZeH7V7f8PGFfxxzW0iMDoY5Udcta3qA7PxJ8z0mmjAatqglI6rSD424nCuRLibQfiSRo46nKWUbnWT/Kl3nn87IJkGQaDxhvKdGxXX3r8O1aZOnFM6E3i+jxS7kbyCsl1TCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772611653; c=relaxed/simple; bh=4ZI+SD3jD+IY3XcMnXZ2Lccr40hmpqlA1lS3Z42+WWo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aQEDmF+uKGeyFJHVmBiFvJ/TzZiqa+5VWhx+hkHuxLKQ6S/hEVFQrtGgauNEJpomxK/zqfk7ClmIL7vkEFBJmu7JNY5gWZqhqcjmnKC5ZX5R6J6xqQa+OUgZjgLIxKpgqGLTZmzqdAhF2129A/w69aiBUZLghiQnTF9/sqJsZF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hPQNryTQ; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hPQNryTQ" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48336a6e932so40081145e9.3 for ; Wed, 04 Mar 2026 00:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772611651; x=1773216451; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cVXPpCyp/KjyhGEHsF5inZ+ZQgDHJ+B5qlUBdv6NHDw=; b=hPQNryTQCLUWSFiutXaD3gzjLU3pYaN+Dke8RJ84xLGSIMPN53p81sxoFWzCTcA8ba le6M24LW8XIcQyspMhWpL+7iAKH5CIejPYdeVlaZk4avvz5QE1WbkG/sUjR+xHLyGQko YX6Id3n1KOOTGKMN+OCkxjOrC+xzVoWJ3zuUGBVefJRrYx5CIwmwQiR1cv6JD6IhT3Ir UGXbZcrJnsELZ32BdyFIsWMtjjY4kHDtDn5XXHY2A54QqxTtJdxG9YO+vyxcXYMK74IP JrLUug6ueD/9UqtB/xr65MPwWQLhlz04Ucif3SAiZcUZ1HQPjPU5pZ9QY06sbiox1FnZ JLlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772611651; x=1773216451; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cVXPpCyp/KjyhGEHsF5inZ+ZQgDHJ+B5qlUBdv6NHDw=; b=lEB1ux7Ep9VQRr65rdUVKMQa46LNq6wfeyl37kI7rsNuZ+jYf75BDFGAGUMZbkIXwI wJ8sVFmHSS7utiCsS/H8RD/a8mhcTr5M6eTp2G2sMM7c8AqNiJ7NKejf7IApsasFMDSX s9rjUO2oLpbf+EYG8/w+gua9lPoORTvc0TH6C1+JwxsG/qPmk1siCbqGXWcI8DqXP+L8 +n5xZzc7pm0bGB9Ad8oQuVJg8CgeAwr3YEmKty6K+1+GPB142JqFBIsAUvW0mmcISQmK nnp/f1j5W672e/qhdHRhqycLTpjxO+a1F4ncSLvf7qsx/uIc2k87GBIGp1pcU9O5br8c 9j8g== X-Forwarded-Encrypted: i=1; AJvYcCXP9gdqFOEfHU8kXYkeC/nr2qCRdu4hk3TTWc+2b6Jtd+KQCALIRc5D7Y2AFlDztWgGt3u7GWAos+OlM3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwmTEWTVP2bS7XHFanuEHbEzyWT6/nrQgKeyIvtes0629SXPE/I alM9XzcxFXSEqXBLGDoIynUqmmxFSfh7QIU/akdw1AMZOjq6DC2MX2kD6iDo8pNYizWkAiiXdI8 0KpMC X-Gm-Gg: ATEYQzzsl/20kkHoxN3TEAEHOn9oGpY3x/xpxJaKtlv1LfzcTUKTB829Mvp4+NWLFUM SycLbOVblt3NUvfbmcEuRYF2hmpK/jqOXzLSj34mB1JvH7d2nkgVixiI8fEq3+a+3Ul5ni/XkEE Fjsapv1XQuAV/B3vYray1+3UbYj3VBSY+WLycVKXAVR53SSaf4X8Lkwymp2xjkz44abOGuW35sv TB9aJFymBMEv8w6lHdFnZK1QXKLA9egf0qslqVZAoEKV+NdeDwk+nCHIQWD3+FTM3HEOmohFA3n e+vamfd4Zs43727VrZR5W+kaoO+Yz4iNe+64Ap2wf/kTL2fHRe26T9wX0Tx7fl2sE8yYWKZCK7w d8HnRXdutmGXBdpM4nyhLBJHUzUIe2QzviwJJvdEJPGs5ib0nU6YUL7NNBe9x+LS7Cj9fHI/UYU YeIA3dpMsMWf1YucVW7U1espLhNpf/ X-Received: by 2002:a05:6000:1842:b0:439:b55d:b0eb with SMTP id ffacd0b85a97d-439c7fd3a59mr2271566f8f.38.1772611650336; Wed, 04 Mar 2026 00:07:30 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439c1fc577bsm9446052f8f.19.2026.03.04.00.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 00:07:29 -0800 (PST) Date: Wed, 4 Mar 2026 11:07:26 +0300 From: Dan Carpenter To: Soham Kute Cc: marvin24@gmx.de, gregkh@linuxfoundation.org, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: nvec: kbd: use -EINVAL instead of -1 Message-ID: References: <20260228202008.40063-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 04, 2026 at 01:13:05PM +0530, Soham Kute wrote: > Hi Dan, > > Thanks for pointing me to smatch. I built the DB and ran the queries. > > >From what I can see, dev->event() is called in input_handle_event() > but the return value is not propagated back up. The smatch caller_info > table shows type INTERNAL for that call which I understand means the > return value stays internal and never reaches the caller of > input_event(). > > So yes, this patch has no runtime effect. The reason I sent it was > that pcspkr.c uses -EINVAL in the same type of event callback, so I > thought nvec_kbd should be consistent with that. Put that kind of thing in the commit message. "This patch has no effect on runtime but returning proper error codes is the correct thing and it makes it more consistent with other functions that implement it such whatever_function() in pcspkr.c" > > Also noticed atkbd.c has the same -1 in its event callback. Should I > send a fix for that too? If you want to do that, then sure, absolutely. regards, dan carpenter