From: Niklas Cassel <cassel@kernel.org>
To: Pedro Falcato <pfalcato@suse.de>
Cc: Damien Le Moal <dlemoal@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: libata-core: Add BRIDGE_OK quirk for QEMU drives
Date: Wed, 4 Mar 2026 13:08:35 +0100 [thread overview]
Message-ID: <aaggw9ezzeY2_aEO@ryzen> (raw)
In-Reply-To: <azwfeaf5hdn5g2vutuhzkjl42ld52vyjs4go2coer3yuagiep2@r5hejnknuwj2>
Hello Pedro,
On Wed, Mar 04, 2026 at 11:23:01AM +0000, Pedro Falcato wrote:
(snip)
> So, does this look better?
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index d61846f03edc..c57e35ccc092 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4231,6 +4231,7 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
> /* Devices that do not need bridging limits applied */
> { "MTRON MSP-SATA*", NULL, ATA_QUIRK_BRIDGE_OK },
> { "BUFFALO HD-QSU2/R5", NULL, ATA_QUIRK_BRIDGE_OK },
> + { "QEMU HARDDISK", "2.5+", ATA_QUIRK_BRIDGE_OK },
Yes, I would prefer that.
When booting a device that has quirks applied, we will get prints in dmesg
showing which quirks were applied.
It would be nice if we could avoid applying quirks for QEMU when (sometime
in the future) a newer version of QEMU is available that does the right
thing.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-03-04 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 18:33 [PATCH] ata: libata-core: Add BRIDGE_OK quirk for QEMU drives Pedro Falcato
2026-03-04 1:03 ` Damien Le Moal
2026-03-04 9:21 ` Niklas Cassel
2026-03-04 11:23 ` Pedro Falcato
2026-03-04 12:08 ` Niklas Cassel [this message]
2026-03-04 19:34 ` Pedro Falcato
2026-03-05 7:54 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaggw9ezzeY2_aEO@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfalcato@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox