From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4514E35CB6F for ; Wed, 4 Mar 2026 14:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772634601; cv=none; b=nCfuQgREMu77hzonos5xQYkdZFo6cddKtx7RjAapHzjC9dTp0sqRo0GuS05PJd/tTrJx6jU+waEHv+e1ne2iKxRACoRHBP9zjJkV5q+iHGAdv2Ho60qQ12FqOJZOQwrKEo2DdgcX/UX9yF1cchIveFWeZ+EM2fOlboQBshrad6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772634601; c=relaxed/simple; bh=KJYwgD8a5x3dFWij9qo8R0F8k3yUFjNN+Nah1NIDZs0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=llWE5+1pT2PgP6nuZVsgpykT9N+AIR74IDIccWPad5HBDMct0d/4o9INRNkhc6gfbuZVyzCZkFChZ126bZTIYL0g4QCdsJ2Ob6lC0KBUVEFzR/ceM7t4yb9Ov7zE+kSRO94McXmyaKNufDwxzfRae0m3ZgIPcIxfSZ9PAewBM14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=P1LDAQ81; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P1LDAQ81" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48371bb515eso103607885e9.1 for ; Wed, 04 Mar 2026 06:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772634598; x=1773239398; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vItL+rwbobOFxMZ3mkQBXQUgxfP7hCn2bqDZg0FE4Wk=; b=P1LDAQ81wRy8avPtpPkyhzGeniAeVj27+q9zMERlesInexfwhnOXlz8r1Ts7NX6ic6 nPEliBBgdhcQv4M2nUEOMvJ/F0l3BvW2QFwI2gLFYj/s6zvsoVcQLdVPtzr4OxjZCzjE AjVj2OYyMjvgjk1QNRWD7pxqI1wbltpKObV4m0HPJb/D/g3zFuWfc07x63a8WTEYfG/s DdT4dTBZR6SojFi1Glo12IXIxSSef6aAtiQ1Vb8Q5yn8xHmK6WLo5TNBn6RaCuPSA6xr /4cu+3E1LJOvHT3v4T+ivCUjBeWFdcBUCbCLWGqdwwQUE4GSWIepssEDjK31Oix6UhD0 euGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772634598; x=1773239398; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vItL+rwbobOFxMZ3mkQBXQUgxfP7hCn2bqDZg0FE4Wk=; b=RrbWa4OOiRgEubwA911d74WnoK8Kx8JH/YEjKzdMvrJHCCetUR2Eh430jQSqubJX22 CfcU+Vhdo2oAVkNyPXkx8Nu9FGrmDPN7J+G0jad5CxnakZe98FcMC2hJD+8vb4c3Ys7Y E/qKIMHMjdK1AwFCuoSI7gJ4enXKsUHAvX/yNYplnyrYqtS9jTBsGcmmsclBNrkuTdEV IJBBoAw76fto+bsWXT9Iq4+zGJwefDfllHnR2UDO1667jB/2ePWWh3R0DO3MDvnBWYoV eGAQqxy1Vh/PtXaeWsGcUIeWtMiau+FzKwg7DBsth0XapZ/c0c6HocGA29KcPViv4WVj RX6A== X-Forwarded-Encrypted: i=1; AJvYcCVOTI6yqLaMZRwy3XAIMKELpUyePQQzzb+FFAotS9UYkoOybbY8GxauO11ZN+cErV5av3E+OTdDWnKAFqI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzy/GB0gw0ozbLQbYy10Uk7cZhiom/JHEUFVTH/n5zZGNnFzSfC BojxFWF1AGjPD7R0HOArVHGPzAW1NAdvzlfY/y3sdA0itZW4/eecN+OnGkwUd068yEM= X-Gm-Gg: ATEYQzyRtgjju2bKcdfzYqySc8gzjbvkJKMyc33MgkFncJLGakhisdGUfIhoC9rAm6w rt0arqddzAU2/xCme7V2rWu0iscEpw6i5cc1XVwsU93IOB7rxQrrpwDHXEiBEYV/896Tk+p5k2l aviGeyDpAm0xFO/ntjN5MfY6aXKGUH46yCjwUaF1X2M56uXsFqoLOJjAddSFjTj/kwWEmEYdn20 WkCe4qMdgOMhi8HsLxb03d7UkGUF5sOcRNPsgn/trYQYiQoCFcliKkdeh7QyX2NrakAA9N4sFTU RegxEMC7A5ooPmA//SMS83vI4JRxCGUhea5OArRkUSCesLgXzXwzLnhDAVEbgVNK5Pu4W2deyg6 j0j5NM4hDKx4JQTjudnA3pdK4wwF0nhMKnnQKGssnXbMdovOVWz4JOvf7/2Wxq5dpdbs+/J1sod E0kZzd7QWKRnOhQSxQpwN8JZVQVbGb X-Received: by 2002:a05:600c:1f13:b0:480:4a90:1afe with SMTP id 5b1f17b1804b1-485198bab53mr33785625e9.34.1772634597557; Wed, 04 Mar 2026 06:29:57 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485188914ddsm68911555e9.12.2026.03.04.06.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 06:29:57 -0800 (PST) Date: Wed, 4 Mar 2026 17:29:54 +0300 From: Dan Carpenter To: Soham Kute Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] staging: sm750fb: sw_i2c_write_byte: return -ETIMEDOUT on timeout Message-ID: References: <20260304084545.156170-1-officialsohamkute@gmail.com> <20260304084545.156170-6-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260304084545.156170-6-officialsohamkute@gmail.com> On Wed, Mar 04, 2026 at 02:15:44PM +0530, Soham Kute wrote: > Return -ETIMEDOUT instead of -1 when the I2C byte write times out. > The callers check for non-zero return value and treat it as failure. > "The callers either ignore errors or treat all non-zero returns as failure and return -1." > Signed-off-by: Soham Kute > --- > drivers/staging/sm750fb/ddk750_swi2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c > index 0ef8d4ff2ef9..a17f758dda6c 100644 > --- a/drivers/staging/sm750fb/ddk750_swi2c.c > +++ b/drivers/staging/sm750fb/ddk750_swi2c.c > @@ -294,7 +294,7 @@ static long sw_i2c_write_byte(unsigned char data) Need to update the comments at the start of the function as well. 234 /* 235 * This function writes one byte to the slave device 236 * 237 * Parameters: 238 * data - Data to be write to the slave device 239 * 240 * Return Value: 241 * 0 - Success 242 * -1 - Fail to write byte ^^^^^^^^^^^^^^^^^^^^^^^^^ 243 */ 244 static long sw_i2c_write_byte(unsigned char data) > if (i < 0xff) > return 0; > else > - return -1; > + return -ETIMEDOUT; I don't think -ETIMEDOUT is the correct error code. Maybe -EIO or -EINVAL. regards, dan carpenter