From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 890D436D4F5 for ; Wed, 4 Mar 2026 22:53:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772664829; cv=none; b=e8ENHf3NP00PTyVD9nUCqxP+lpGxCkektfm94+Ma+4EVSA72tj5l5EUYjYWRD/rlinqWMdRutNm3HZa97sidnoWgNT2aDzgfM5NV1XSWWxWehPtm5HXjZPPBUjBrTXeicQj2Ke5A70eNU1RuKStvFW+OoYlQGixKR9bbC9swMa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772664829; c=relaxed/simple; bh=gY2oHabocgLq7QIu9wm2Y3e+Ox74lNNlJ1IsKxSE+Qs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K+AN8V6+wAXUmhoy9qiQjYQ9KEVxNF+zS/OpOgoGwXU/QwDd1AM6n9vD+bDvF0AJVRFoGjiD8UaVcWnmZzx8+R3qDAbUeL6/rdWBUYVxjjXPp8Lecdn06y3Z5MhfRshvQMZZY1oAm9eSMG2yd6DzrQZ7EkARWUUaySo9XM4s7wM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=LeBdyAXW; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LeBdyAXW" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3599019ae92so2037693a91.0 for ; Wed, 04 Mar 2026 14:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772664828; x=1773269628; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L8eHM5aNTjyRJDFKy4QnyVedRObL8RR8aOfAsHzSyPQ=; b=LeBdyAXWhiW0qtYOjl3/U7Blk2PAYpwA9gRnaRsXe/XXaPfcl0MxvGGzmPvZMXDLQH n39cr/pTsPKTNT4tTSLW+0t/QzYZDPWLq47TDw+yMh8xKHWECAXCtHJd079bkM/WsXu5 /6ImTgZ+5KIrn2uY5kp7nZcglx1U0gNVINN2+uVYoteYP06U48B1xp6bWDHTSR7BZp3J OAQx9nc66mCp3lA5hhzuzHWY+VNCTxBehY2RHE0zTKAraba7j0uHUXrNAi1EQMknf0JA 4j7HUEAL0CnGrUx9EqKGhbaOXGNPe4rKVFAHKbZ6iqWtgJPuBBNOP6pqdjbIEfZoDQ7Z BxQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772664828; x=1773269628; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L8eHM5aNTjyRJDFKy4QnyVedRObL8RR8aOfAsHzSyPQ=; b=nAxmyKgMYA1bsu0QwGydmHoTrL1XDpmapG8qSN6d3NNzF8eSPBaXV9knH6A+TRviNw Oa+5JGjIu5JrVwM5Y+ULdBNK7p/NFjI0BoH4/mNxe716qGjIuOICZU5xpExvKRkyq8py /hDBQVSSVNLwWw5T6tMM1QBIeTkzBpqobehLHl2tK3vXh365x9paE8rVf5L94eRj2gY8 ZQAZtMp5LC00mG3Aw+GQMC3lafK/ZPhKUXi0Kn5mcGOs2aF7/J2h2OL0QHVX1oGl7QaA fdRn9JgX/jEOjhN7gCsNDltPglJm2A4tk7jP7p55TE2ivxKsBkWTDtGkTt29yJFgp3w8 HPzA== X-Forwarded-Encrypted: i=1; AJvYcCWnbe8xLh04Btbx5aVfUzd1OGu8y8/w20EVNW1j58H2R6zNHpK3QTK76bg6XaHl4GMPuNV+SX/7r/uzw7g=@vger.kernel.org X-Gm-Message-State: AOJu0Ywi2ZZwEjqO44AXpakkVfb/IeV2IE+7KbdEgo4XQgbrGs+odTSc pICjwItNZrTMIsCAGiCCuf5PqD5b8crl0O/4/JrKGeN1YimUxOXerD/pzyPB8G9+lw== X-Gm-Gg: ATEYQzwFrnjtxF0P+pS+DVwaKYPpq1f8vE1SuQN0ncZWAxVqjmuW9J8WLP2QjnpTl3w F9ZMDETcqb7rU1/Fm4CoDM4SXPa2qC2gOp347QEcGuL/h5ZlnRaL9y/ERCEb3sRcLz0bE1n2We1 f1wLfSZDIur6l0Bobzl2jcvQEvpXuIS2rmeHqs6JkY66z6gIJ7Pr7vEZueev55M+LG7rHgFdwCl RTt8t7TRTfUjumgIhmKq/UsJ7pD4e6e/pXoijydUBBlAR29CzJJJ0lkBQ3eqh95qUu78ohVtsYe S+ap/9OJ1qP6PsYHhvjHxvjqk0RQ+ts6Z1QrLIDMrmcwldNNWcBn82N8JksEzCege4u0ePQh2Es 92M8ckNhkMp4L6F0j6fnUphrFg/dD6qRHhQmZtm+kmrBuAVHcVRlDIg1dbD2JqSCoLmIpCuM+vl Io/FS2XLgoWjcugaF4J6CJ4qzdZoMVN026o/Jkyw2x1ABFyUbe3yaxjCCyZetabg== X-Received: by 2002:a17:90b:2b4d:b0:359:8de8:121a with SMTP id 98e67ed59e1d1-359a6a4a45fmr4051852a91.17.1772664827371; Wed, 04 Mar 2026 14:53:47 -0800 (PST) Received: from google.com (239.23.105.34.bc.googleusercontent.com. [34.105.23.239]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359a8f3c23bsm1216444a91.1.2026.03.04.14.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 14:53:45 -0800 (PST) Date: Wed, 4 Mar 2026 22:53:41 +0000 From: David Matlack To: Raghavendra Rao Ananta Cc: Alex Williamson , Vipin Sharma , Josh Hilke , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 3/8] vfio: selftests: Introduce a sysfs lib Message-ID: References: <20260303193822.2526335-1-rananta@google.com> <20260303193822.2526335-4-rananta@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260303193822.2526335-4-rananta@google.com> On 2026-03-03 07:38 PM, Raghavendra Rao Ananta wrote: > + ret = readlink(path, vf_path, PATH_MAX); > + VFIO_ASSERT_NE(ret, -1); > + vf_path[ret] = '\0'; ... > + ret = readlink(path, dev_iommu_group_path, sizeof(dev_iommu_group_path)); > + VFIO_ASSERT_NE(ret, -1, "Failed to get the IOMMU group for device: %s\n", bdf); > + dev_iommu_group_path[ret] = '\0'; ... > + ret = readlink(path, driver_path, PATH_MAX); > + if (ret == -1) { > + free(out_driver); > + > + if (errno == ENOENT) > + return NULL; > + > + VFIO_FAIL("Failed to read %s\n", path); > + } > + driver_path[ret] = '\0'; These can all write off the end of the buffer if ret == PATH_MAX. Also there is an inconsistency in these calls. 2 use hard-coded PATH_MAX while the other uses sizeof(). Perhaps add a wrapper to handle all the details? #define readlink_safe(path, buf) ({ \ int __ret = readlink(_path, _buf, sizeof(_buf) - 1); \ if (__ret != -1) \ _buf[__ret] = 0; \ __ret; })