From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16A323DEAF5 for ; Wed, 4 Mar 2026 19:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772652949; cv=none; b=b6U+Er95RGWaKZROv5B4/QvWJpnSPqExmFiLUDCn6ToLcvjLIBugZZN5CFSEHRN/frrwDwfgLHnys5wFIQI/P/c0c5PNq+tG1JOmXpVuaOqZnQP9hb86ONFXxGQFkvY/WVLnnkItHO8Ami9NaCHbBu4Z/Dhe2Xr0JjCgEQ4BB4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772652949; c=relaxed/simple; bh=lbIDZrp7+cxynSUHaoYLzZS7n3SGEL/qayDgycMJJBo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PqFbJGy7oJr6a2sub7QQ9udebbTOs3TCH85AeAFK49YKPGgnUCxNXLmK/oWVYrW1Tg78FeF2d7ZWS6UDaSQwPd6A54LFfMr00EwsLA6jL4wOb+i68+pnmOGVPjmZnfW+dH1yUhBfPfuNXL/c/TZC11k22ViTumEgU2wM6pt1108= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DOJlf8bF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GdJul8DT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DOJlf8bF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GdJul8DT" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 624HHEMf3837984 for ; Wed, 4 Mar 2026 19:35:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Cg8b3VUqbaKdYh3k3ySRyeTG Ml5pXbzZIMHk7oalclY=; b=DOJlf8bFM8TYi6OThYvb2YpxJNA+K58Yjly+IUEW KrQBzOeKex2sPl5vu4eX4RVQh1dFZ+SutH2eQP/cuhUmTqRccE3zRtId/VoRjhsP 9zrErhdZ4u3H6vT47W18kQJoveg9SkflkJamDykk/Nzwtldm8LV0wTYJ8Psy7TeS nS05bVd9MoAJhHcKJpSfN8gGwW/bhL1Bu4M7GF7rFl3w/gMzDc0tni/xgYPY04UJ YBT50rjYc8CLxfE4TVSsoD1VSMqWJXZnSd2lNaGpQtgiuDXlqPwrJHLtjiMa84V+ OapDA6JPicDEvHIXcdfNcIr7RCMLabM8Py8UYx7VMuEBsw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cps0m0e0f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 19:35:46 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c70e610242so1232216885a.2 for ; Wed, 04 Mar 2026 11:35:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772652945; x=1773257745; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Cg8b3VUqbaKdYh3k3ySRyeTGMl5pXbzZIMHk7oalclY=; b=GdJul8DTsfNYX/G0ZC9I4ydEX2CJJvqMC/IGpAOTHi2jknMLmMMjh3XII6H0VchAVe VCqNAVphAqVquh8drju/LPeNsdwzwynhXbUM7G+nCcJiEQG+r+TZTDci9FnYx1A83tr7 /EtsuuOTzTNnTCHzfMLZxojVjR5uviwK5Eny2YiBVy2XNmIGSMr2Joez1C3iy2Uv73Hj M92mqloxG/JiGvJItZQw8TP0Jeq8SFdWUvbA6blkqnwYIsjTPsPM0xFhZ9wj2cLPKQ2A WyoW0BPj20CKvT9EI3iytWuN8inl6rCxkYC7+CxiNsZSEStWKeu2NmVDUqUZbVuXbq9Q 86Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772652945; x=1773257745; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cg8b3VUqbaKdYh3k3ySRyeTGMl5pXbzZIMHk7oalclY=; b=FsuwI6i0gbMS+FgNr7TzM3rKDqSLWeFLVNzCFKheZjnnOMbW/gpNL0NtihdoljdBd/ AG6yg/POvr88mTUqMWsMsCYWYIHINgY3xqurtpnsTyN/1NrlsrJOpIazDwNiMqcPt+et nqGghNtSUFx9vbiw+hT9RzLs/HlZw0ZFY5WLqGxxt93wqBpYTr8xou2glBR5LRqmzjA9 qYIRuKZ2Ie8gXHn/6dFvUYgQEZL9tjLkGOBmwXqOYGzkpWQHjeY3RJ1n9vrXmfW4s4nC 4zaNP33j6a2koemFrdJ0iqMYwVKRFN5UqTmGKAcAWONJziHX2R1hATD+ofEDKgV43rBE lIlQ== X-Forwarded-Encrypted: i=1; AJvYcCUVUuozEpzZ7t4UwN3KBgBSQdKQdTsYIYtv0xwzi4oIlIwJT/G8AYbVt/6o7Hw6RqBrNBQvkKWHzo0Pt50=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8Th7dljRZDybA1L+Ip4MUSIzPQfAUtTJOneregU86UHb0yqS1 YC1XfaKxzRqX671epYPszuqaK+yiKDkO5v8SbrD0aMngY4ARRVWfdMkCQpXdG4wYJ2MqNrfBus+ ztD68V+y78RclsFGIAvMKIFw/ua+Sd2kQCRE3uzyG5+H8RJOndX0ULycqxEaMwniF1SU= X-Gm-Gg: ATEYQzzxwQEUkfEYRZ9OsB/uOZcdwZdjX23BweSwaSs+eFQE9Rd7PRLi9vskcWg86Je rmhLCjLcBu+1VAVTiVZzTH5TA3Fz5+GjIz6Ba+Y+Fxzz7wzoRPPDzJEjafCTpNTIxffVI7VeIUo gY9PiTITdpCfi+9N6y3wHQ3ZGpMeE5XC2AHdeuXjeV2mcS7iaPVENFHo9rcGRHiz71ktiHDnbY1 tx5Z5OXBgL7uHw4nc0Be3dstlQqkNJvXv/vp/UnR0ySYS9wFLssC8Mb8l4vMY8Ul2YEZ4drvNo2 DDJmoOcnAax8bbJ1oZkNriRmiIsjnmGiturP/ERjgkvkZX1Akn+Ceu8NgtqPk14GQyYR+PyUsgo CXhpYc2JUqiYk2+GBHDAvedvSgaTz X-Received: by 2002:a05:620a:d8d:b0:8c6:abc5:f15e with SMTP id af79cd13be357-8cd5afaaee4mr381210285a.67.1772652945382; Wed, 04 Mar 2026 11:35:45 -0800 (PST) X-Received: by 2002:a05:620a:d8d:b0:8c6:abc5:f15e with SMTP id af79cd13be357-8cd5afaaee4mr381207385a.67.1772652944927; Wed, 04 Mar 2026 11:35:44 -0800 (PST) Received: from mai.linaro.org ([2a05:6e02:1041:c10:ee0b:246c:2dae:77b9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851884225asm71621215e9.6.2026.03.04.11.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 11:35:44 -0800 (PST) Date: Wed, 4 Mar 2026 20:35:42 +0100 From: Daniel Lezcano To: Chen Ni Cc: daniel.lezcano@linaro.org, tglx@kernel.org, wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org, p.zabel@pengutronix.de, mripard@kernel.org, mans@mansr.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] clocksource/drivers/sun5i: Handle error returns from devm_reset_control_get_optional_exclusive() Message-ID: References: <20260205084037.3661261-1-nichen@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260205084037.3661261-1-nichen@iscas.ac.cn> X-Authority-Analysis: v=2.4 cv=e6wLiKp/ c=1 sm=1 tr=0 ts=69a88992 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=7EzGa34QA7hzBqsRmqMA:9 a=CjuIK1q_8ugA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: 6q--qa5q6YLHx0BUc1PtBege-8SlQ_GC X-Proofpoint-GUID: 6q--qa5q6YLHx0BUc1PtBege-8SlQ_GC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDE2MCBTYWx0ZWRfX+z2Zza1RdEXo Yw43MYixJhUzaa4VFJt9waZIMkWltxNV/JelcjfpqiL9PLMxgdiv2IGT8LIkxrslEE5J9EaJwlE 1koSmlshlUgluRDQ2wYC4L+jnzNNnvb3nAUg3dkfhtP7q6XyoQ9CafSc6L4GXZ4rhkCPB973pPZ 5Y4i5A0ZDyaD5jdnOaXw+AUYGLK8gGTrjkWobnqZgH6SWyiL/Yb2ZCCY8L7SbUknZWwdwuQyYzs Qdnvp3ICNohqtpLT0ZMqwjh1GArUircyu7XqN7LyL1CXfhqccbUlJwJEoGeP9Dpr9ZhHoFZBRWD pPwXhiXvldgpf+ep/qisltZj0BNdGhxFgVDPUv2lapYDlEVLEO4Ox5aHJK9maK1o0GU/M+XJUH2 xq9ZErJX0UqiQDg9Ze7GtOhNOZSe3En7Fc8tZGCof04Zy9rpYh87HalGaYCfTV8bRcaN7dz+kXD fCa4I9o5chVFQiSY/qA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_07,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040160 On Thu, Feb 05, 2026 at 04:40:37PM +0800, Chen Ni wrote: > The devm_reset_control_get_optional_exclusive() function may return an > ERR_PTR in case of genuine reset control acquisition errors, not just > NULL which indicates the legitimate absence of an optional reset. > > Add an IS_ERR() check after the call in sun5i_timer_probe(). On error, > return the error code to ensure proper failure handling rather than > proceeding with invalid pointers. > > Fixes: 7e5bac610d2f ("clocksource/drivers/sun5i: Convert to platform device driver") > Signed-off-by: Chen Ni > --- Applied, thanks