From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1570919E98D for ; Thu, 5 Mar 2026 01:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772674540; cv=none; b=IFiIAQPpOpLK/HTw4JDmv+crEERxdeO2f7Guez63KDq47Y1cZbA/FcR2OmD7lIb8EA/w1A/HTxASrvhoYrAjLngSyrckJhI5eFQmTONUbc42GCvKbDVOqKhVBPND8rwiq8oFWUUgiXbxViJR4Aewrb+kdw1U2iHGYPKtu6SWaRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772674540; c=relaxed/simple; bh=nU+kiMy3ux5LITsewJpWfREDqwcjohElsw+dahV6WtI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=YAvAxEd1J8WBjw55JigUTU2s44QHhZYMhJuN7HxhuCz5WCcQ+UUp48Nj4JH402Klsgh1ptoHVMjvGfHhzUr0bY/XICeHFJxKjJuUZSbeW/NYnbFlATPDlCSqsB97dEQJvAEVuAeRCN9/pEujY+gabkl5I7mmBqXUibacZEkPARQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=xpt2H0j3; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="xpt2H0j3" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2adef9d486bso66275325ad.2 for ; Wed, 04 Mar 2026 17:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772674538; x=1773279338; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=eToFNrL4npkETfbdyyrNvZSNlVUc+rj5T/HrzOpoia8=; b=xpt2H0j3d7evFV5Ym8P3dKjOAK8buW7Ui5VMfKHun3SKATjZiDfdfVYWrLiayRiCFW PIKbMl8oMmLYQyw54NqMOPAhSNlLttYk06mpyFgQh7HuBVHx2qEzB2guTh9lZA+oWOI5 oGTrl+6cWPG1OLS3O/lSi24fibrvSRvAfeetuhD4wkeRAVwV+yTN+vc0judfNgJTujfH SakpH5frJah533ZEqSfYopJJWkVU9gpJZgAyxcHetMo/KXZ9RqP1fuBmUWu7eACEcEhX e6GfWxwb1By0ffT+F+sH+ClzL8AhgUE7m/UOIUl2AGv/qOPkbbgHmKjIpvJhS1I9qA2q 9kWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772674538; x=1773279338; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eToFNrL4npkETfbdyyrNvZSNlVUc+rj5T/HrzOpoia8=; b=i7JaR1tl8O/sd5c0CjEzPNsz+TovAmBxeD6PYJ7snFkwiXo0BNPfNvjAMyE5/xZz1w VJXPt8miaUHWZ6/MROJt0XKxcSPGSnBX+D/QFICJc6wnMUQzt613gkf5a/XzrdxvmJ85 zvObBPYV/gBsz1g4C/fLDEvpFrnvrzfQB3Iz/kbYtp3oMl9ZLf5wfAM6X+HuUKZ748Ft 79XECcm9DMvpzAY6xfuOEtY71QSL3dTw61Kvjsipr9zO+EgWnWRgdX4C5HKBtXWEIZ49 pj7mIdUJHfcs2ZrL5Vw1zfelAKXUMDoiN2JIcMSMZJ/uQj/XCtezvGQpGda6UqcjtRjf nu+A== X-Forwarded-Encrypted: i=1; AJvYcCWI5aAelpbwubwp1sYIXESGuBQRRPBhJ5+iA/r40ukABUlaUhj7dw1hMhJl/NJSekgSIOdCyv/SbwkvSbY=@vger.kernel.org X-Gm-Message-State: AOJu0YxZYTfdy2qRlfZGe5OcRKwuREJ8mPeIytKN7wySg15ifmSyXVCO ttWne+MWegOfDpFZ8Kr12fAZtc6NyILJhg/yvmjqQ1j/2v7xvxhbvs77QkxhMXR1yiguKvVsoKJ V+Fef+w== X-Received: from pllx22.prod.google.com ([2002:a17:902:7c16:b0:2ab:194e:4d54]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:da4d:b0:2ae:47f9:de12 with SMTP id d9443c01a7336-2ae6ab729bemr34506245ad.46.1772674538033; Wed, 04 Mar 2026 17:35:38 -0800 (PST) Date: Wed, 4 Mar 2026 17:35:36 -0800 In-Reply-To: <20260112235408.168200-2-chang.seok.bae@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260112235408.168200-1-chang.seok.bae@intel.com> <20260112235408.168200-2-chang.seok.bae@intel.com> Message-ID: Subject: Re: [PATCH v2 01/16] KVM: x86: Rename register accessors to be GPR-specific From: Sean Christopherson To: "Chang S. Bae" Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, chao.gao@intel.com Content-Type: text/plain; charset="us-ascii" On Mon, Jan 12, 2026, Chang S. Bae wrote: > Refactor the VCPU register state accessors to make them explicitly > GPR-only. I like "register" though. > The existing register accessors operate on the cached VCPU register > state. That cache holds GPRs and RIP. RIP has its own interface already. Isn't it possible that e.g. get_vmx_mem_address() will do kvm_register_read() for a RIP-relative address? One could RIP isn't a pure GPR, but it's also not something entirely different either. > This renaming clarifies GPR access only. But then later patches use for Extended GPRs, so the name becomes a lie. I also don't like unnecessary use of acronyms, even though GPR is ubiquitous in x86. Everyone looking at KVM knows what a register is, but only x86 folks will know what GPR is.