From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F03C0140E5F for ; Thu, 5 Mar 2026 05:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772688829; cv=none; b=fxiERsAjajm2NzhL2OZhJpA34KEI7Hcz//z9eizMQkmAQaFPhQQc5I4DZ162sDf1gmS3jiHKMSBI6VgSwuh8hMXRgh1G5ASdumeSrp3V+mcKl+csW3vLhncDkjesoZ2i/HvYRBB1rx5KtksuBhRO77PnwvMxXX9ZGwo19b16Uq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772688829; c=relaxed/simple; bh=wj6XVJR7daBU7N60b0ABVb/8u/aeymIukhxPfV3iPe0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=irme+QLGtSN0kFtTsOGzsBose2bYGIB+QNa9v5qAC7r3Aw53Eb6pS8H7xAVg0ugXPuIJhm1aQO6jnHzTwad2NHRz5rBndiMfPBH5TLlxjOYJV0Cyl+epARFzAt2WXNpySLynuWwETm8xzWo5jtD45T7W76IMgvT2YgpCpPDsrIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V7VLctsw; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V7VLctsw" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-439b8a3f2bcso3163651f8f.3 for ; Wed, 04 Mar 2026 21:33:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772688826; x=1773293626; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Fhxvhu2T/q45ENXvH+eUJLMEREATBu6EpqQKx+HGiRE=; b=V7VLctsw07sgyiUo/+n02NUkyj+Pi7wucaxCrYD0Jyimgwj9OyCQ+/7q+crIFA0OhM IwAKEC5NWyV3Fvp1Jrf3NMvamLy7/pAZj+3VUvT3ovV1X0gOLM1QRToMxhGtEEFPZQiF e513tUXLUdKvdYQV40n9KfhnooIzRmLlvHZo+pfnxeJtepWRQnJJQofZj8sMpmaYs598 Qn5dJiKdOWKisaGC+UTfU5ilRZ8UlEnO1CfPVCONP5CyX1oNE/xfTQHYQIq+CbkQ0XsW eWbK4UB8kkGrJPLfD+o5e5ADijhqLLWwvR9V5qOXnvHxUVCi+VMCV+apr9l4g2pf56nl /4rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772688826; x=1773293626; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fhxvhu2T/q45ENXvH+eUJLMEREATBu6EpqQKx+HGiRE=; b=lk4v9mKfvZV/n7LfeQmxPJSumJHApQX7KWOn63F0RYRZbiL2oPOP6RBQ+tdOu8bh7F JXzI4cMUVFigCNpH9BJpb9BKrFIgCjDlD3ZgQwUGu7agbfWGeU59mIw4TxXNJzg0ywBK 26hxvXVGRfkGYzeymgbff4PcKvYo7cEk6ASmlfRJ64J5nS4QHnw5RJaFQ8tUEdDxTaUG RTgL9t1fdjzooqve5T8LPHOF1TgRwYCsX3Ld+T1459XfUnu7LpNFpVf6vI/JnuvCmRyR AdGOaLPlGTCtoIZ6QvzDKvuCd0kDNcf8y1iGbAzeU0eGl/kCc6D6/Lj5SU4w5w0QDIjA ccNQ== X-Forwarded-Encrypted: i=1; AJvYcCUonF49KBkk5MINIDY9eY2LDYjbV0a8DqfbVcvgKtjr6vf79GP7HY2ybamEjbqMSc2uxCU2c6PjAH+fwnw=@vger.kernel.org X-Gm-Message-State: AOJu0YxkKDQ129IsIaUs6HY5jnnMTF2mUuzLE1OBvWpHeR2sdSiGhKxg wiboqdaPSxB13fxNg9cHdQauRQJZ+Ut9iMLuAV0nDdHNwjwztjR8SM53W5+h/i+SWEE= X-Gm-Gg: ATEYQzyU5iID09Q8IWPU6pKZ/kSzXlQjMdRCqxBfANYezQo7pdpFzJUmKzPQKiNl4Dn +ns/OAE2t75abOUxby2TOlzf/7U2TgEn0sk/c2XfB61fFzxZp4pMG8i2YEF6Zv7IyfNjLMTUSz5 TSfh9wAwH2ODGYdZxmf6V7oJhhOtWdSYAXz5cTYfICuRAgXWXSIsr5duH40QmvvRdxKoJKwAFVD BPNgWi6kPzYeU7HxqPZTiSsuZccEGA3XIZNZ6/32eNbTPwdQS47LwG9OOb9/siXLA8zDA16C+wS vo2s3eHkLXn/zGnpaepcsajIjnqIuI7JW0LtRqkwhBPAbEPd1qRkUD+yxhlcZtoSKW+c6+7sYRa Xg75mHLN9WcOK7WKyv+5UQcEpZ0Ote+u+rC6kKSlc8lVnO+d5T259Bf6IIMWDoxQWxNw2654fkO 0hk6wbs1MGzYHa3RATNiXPhDMI1VBO X-Received: by 2002:a05:6000:2401:b0:439:ad72:9900 with SMTP id ffacd0b85a97d-439c7fffc62mr7932444f8f.29.1772688826250; Wed, 04 Mar 2026 21:33:46 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439af926c53sm40217958f8f.8.2026.03.04.21.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 21:33:45 -0800 (PST) Date: Thu, 5 Mar 2026 08:33:42 +0300 From: Dan Carpenter To: Soham Kute Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] staging: sm750fb: hw_sm750le_de_wait: return -ETIMEDOUT on timeout Message-ID: References: <20260304173529.192067-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260304173529.192067-1-officialsohamkute@gmail.com> On Wed, Mar 04, 2026 at 11:05:24PM +0530, Soham Kute wrote: > Return -ETIMEDOUT instead of -1 when the DE engine poll loop > times out. The callers check for non-zero return value and > propagate the error code back to their callers. > They don't propagate the error back. The callers do: drivers/staging/sm750fb/sm750_accel.c 87 int sm750_hw_fillrect(struct lynx_accel *accel, 88 u32 base, u32 pitch, u32 Bpp, 89 u32 x, u32 y, u32 width, u32 height, 90 u32 color, u32 rop) 91 { 92 u32 de_ctrl; 93 94 if (accel->de_wait() != 0) { 95 /* 96 * int time wait and always busy,seems hardware 97 * got something error 98 */ 99 pr_debug("De engine always busy\n"); 100 return -1; 101 } They return -1. Propagating the errors means: ret = accel->de_wait(); if (ret) return ret; Also this is a v3 patch, it needs v3 in the subject and a little description of what changed. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter