From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1ECE1DDC35 for ; Thu, 5 Mar 2026 05:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772689897; cv=none; b=CDpsNoo1/9SBHNYDf5eOiQEhKLknbLd/H/eJtaM1RleIYLNFQJcHsigGkhy4Q2ZgzJWR+CQKz4WAJKqe1gQkDuFdJRYsiShLgKkhfqpJVXKnwFZpbJ34yj5OozIpoG0yENCkArGNAFVVaiMqcH9Lx0JtoDTJZNTsB+h0r8QQTN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772689897; c=relaxed/simple; bh=XpT+4mClh9KDy3KmIhOdA2p+xis/Hm/w4vJupFwmYhA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TVJVHBY6NcLEcjQoErchP9TOFkB7pkIPCIDOA5vRooXn6yZ4eTOQLnO3a043YM2b6S+JocszKXG42pvEzg+J4M65bMnmCbCfd1/sNIq3I9wZWE5WeZnwzkq1taJ0D4GaH5znIgLFs36z04db4BlU5nBuLMlIHSkEgyrOLUNPmO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ssiNPBd4; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ssiNPBd4" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-439af00d33cso4362254f8f.1 for ; Wed, 04 Mar 2026 21:51:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772689894; x=1773294694; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xC3MPuwXTtW5386fVJjonKTkR2NFkirsNB+NgUfOWiw=; b=ssiNPBd4riOJTiGv9qgtEhGVSivki7dOMSE1Za9FRLQ7XMQqJmTY73hL7YZyYdEWgo briqKtLJ/0msWUxImGMpx7eK0u2nJrRJbf3wiPQ6Z5plGmeYgikM8ChxzTYgtGmDgigw vqxxYRRzr9gd5Lo89TA6igJ9M8Bbj+EImF8yOoxXt5fbhwHg9tJyxtZAe+xVG5FerXrX 3msiBmSKiQcVakEj5XQh2q+fpw7WPIbSJBUupKaG/Jl++g1rk1OHmEICEmih7yWiCpbY U+Neu+iq30/VYTbRmedDxmSro8mIvQzjUNjS26s6qBzMy656uwsTgPkHDh/EbQjuAcAN MvZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772689894; x=1773294694; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xC3MPuwXTtW5386fVJjonKTkR2NFkirsNB+NgUfOWiw=; b=MgdnWUtblEt87uJdA2uGhp9kWnyvNeOPW8+/hAa5mHJqazfXK/2bT1iLwCp3IMqcAQ aicA8UvZdzE3UU6QYjk9lnJWGQD7nRr2oB0KNlzgJgbc0rdrM9Tc14jFnA5/2EUNrH6u K9NGYxbd9oUtzI8sCEthB1pnOMouleHl8yvBxpptoWnFXZqDM9E3j01SFUsGiB1FLBHe Nghx9qobW1R5CUDyje/YwC1b1KcDQl52dXtVcGUbUUe+KgtheX973DS65EJvy7tTIHUZ E32XaXzgpXvFPmU4WrVC1klvAQVeVMK16FOjE2e9MaTJM7H/9cTt82ovVsjFJLHTfnQm ltBw== X-Forwarded-Encrypted: i=1; AJvYcCWWUNGTc9zuUM3fZi936Gtc94/DyE54f4yL93hJnf2JVr6N3p65t2s7usw4fE6iDnSTd0aqKR2tzBdSsYg=@vger.kernel.org X-Gm-Message-State: AOJu0YyfYGyezpFIdm/3Eat6VCm0bE6o+rH9+ZQIZZbVCc1L7tAXTUaI Vis3vrl0zBwW5Pw0FpPakKKPjuETiaQGH/8VX/9tvELOvesEc1HzC/RvIKJPw54s0lc= X-Gm-Gg: ATEYQzxBvOGm1aFO0RnQCwXXeAoaz3WcfwrCI9JgOSF6gKF9DWrtyK06UwhVzWQyrK5 6181KkLSdgBtbCLoNqPr2e+P2LNb0pNW4BxEevXBkw+INHBxYx8dZAkWDLydOnnnYwLdLycUTJ1 DwdgTNFxK/VfYnY9ppHS2F0ccchJPXmr/q9Uxj3XEsyewwcFpjkOwjNqas7NX2pDp/b+0jMiCcT QEibfOccQF4ov80/80/zTFtex33Sa+9aK9AMn2PIf8To1qr8PoLP8LPF4eVeEQ2s+xOAcONxTt7 WVRMV4wSnayhJ+eycW4y5qN7VPAZeW8RkKjnfc46mbw6BPrTZ/lO6Ljo41XzCEgl3XnnIfiIijZ vfMzP72PWrYtt8Wccay7XPTvUFJwVCbQSCaQjEajNyUlh5ToDDMjSWF8y89DNoYHNNk6Qjnl00U Ybt6/poOJmU9AMNXT+yC5PWDpEBb/9 X-Received: by 2002:a5d:5f94:0:b0:439:beee:43be with SMTP id ffacd0b85a97d-439c7fadf94mr8866940f8f.24.1772689893946; Wed, 04 Mar 2026 21:51:33 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c60f764sm50610655f8f.3.2026.03.04.21.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 21:51:33 -0800 (PST) Date: Thu, 5 Mar 2026 08:51:30 +0300 From: Dan Carpenter To: Alexandru Hossu Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] staging: rtl8723bs: replace alloc+memcpy with kmemdup Message-ID: References: <20260304130706.37347-1-hossu.alexandru@gmail.com> <20260305010917.40320-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260305010917.40320-1-hossu.alexandru@gmail.com> On Thu, Mar 05, 2026 at 02:09:17AM +0100, Alexandru Hossu wrote: > Replace open-coded alloc+memcpy patterns with kmemdup(). > > This simplifies the code and avoids manual size/copy handling. > > Signed-off-by: Alexandru Hossu > --- > v5: > - Move version history below the --- line (per submitting-patches). > > v4: > - Drop unrelated DT binding changes from earlier attempts. > - Include both rtl8723bs changes in one staging-only patch. > - Wrap long line reported by checkpatch. > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +-- > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c > index c9cb20c61..6e03d3d8a 100644 > --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c > +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c > @@ -583,11 +583,10 @@ s32 sdio_local_write( > ) > return sd_cmd52_write(intfhdl, addr, cnt, buf); > > - tmpbuf = kmalloc(cnt, GFP_ATOMIC); > + tmpbuf = kmemdup(buf, cnt, GFP_ATOMIC); > if (!tmpbuf) > return -ENOMEM; > > - memcpy(tmpbuf, buf, cnt); > Delete the extra blank line. Also this doesn't apply to linux-next but I haven't investigated further. > err = sd_write(intfhdl, addr, cnt, tmpbuf); > > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > index 7cb0c6f22..0ae7b6389 100644 > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > @@ -1430,13 +1430,12 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *padapter, u8 *pie, size_t iel > goto exit; > } > > - buf = kzalloc(ielen, GFP_KERNEL); > + buf = kmemdup(pie, ielen, GFP_KERNEL); > if (!buf) { > ret = -ENOMEM; > goto exit; > } > > - memcpy(buf, pie, ielen); > Extra blank line. regards, dan carpenter > if (ielen < RSN_HEADER_LEN) { > ret = -1; > -- > 2.43.0 >