From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F280222425B for ; Thu, 5 Mar 2026 17:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772730211; cv=none; b=IL1uaLSfWTztMt9JMHvDBZ2R8BMNOhX/IluYRE75Odvqo3g9Vl6/bKzI+WTFQB68bIAOTCNU50mcS242oH+YLK4AHTk+ovV5vXwkocl5wS4rL+eAtT8N1JfB85pJUS17s/3V03/hSOLvj2uzDSdlvednL2w45jNLsG+laTQAIRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772730211; c=relaxed/simple; bh=Lk5kDxiQiRVPjUZWnHp7RfhsEQR30AsFaDlfPGXFRls=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JjTkaJNr79BhC+ib5k/cpBLifAd9Zsyv5dOETwtS7Y2yH1/igiqm4M667s5HU0Sum1D1IgeJ5TRm7T2Niyw+7hnvfhh65F571WzdGvUZK35BaHT0gPlLV3hdHO3lUt6sDEFpso76ddnqaIjgdC5/vGMKplN4wOL0jaZa96N0O74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E74A91DB5 for ; Thu, 5 Mar 2026 09:03:21 -0800 (PST) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9FAA13F8C6 for ; Thu, 5 Mar 2026 08:56:41 -0800 (PST) Date: Thu, 5 Mar 2026 16:54:38 +0000 From: Liviu Dudau To: Akash Goel Cc: boris.brezillon@collabora.com, steven.price@arm.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, nd@arm.com Subject: Re: [PATCH] drm/panthor: Correct the order of arguments passed to gem_sync Message-ID: References: <20260305110723.2871733-1-akash.goel@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260305110723.2871733-1-akash.goel@arm.com> On Thu, Mar 05, 2026 at 11:07:23AM +0000, Akash Goel wrote: > This commit corrects the order of arguments passed to panthor_gem_sync() > function, called when the SYNC_WAIT condition has to be evaluated for a > blocked GPU queue. > > Fixes: cd2c9c3015e6 (drm/panthor: Add flag to map GEM object Write-Back Cacheable) > Signed-off-by: Akash Goel Reviewed-by: Liviu Dudau Pushed to drm-misc-fixes. Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_sched.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index bd703a2904a1..a70f1db0764e 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -893,14 +893,15 @@ panthor_queue_get_syncwait_obj(struct panthor_group *group, struct panthor_queue > > out_sync: > /* Make sure the CPU caches are invalidated before the seqno is read. > - * drm_gem_shmem_sync() is a NOP if map_wc=true, so no need to check > + * panthor_gem_sync() is a NOP if map_wc=true, so no need to check > * it here. > */ > - panthor_gem_sync(&bo->base.base, queue->syncwait.offset, > + panthor_gem_sync(&bo->base.base, > + DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE, > + queue->syncwait.offset, > queue->syncwait.sync64 ? > sizeof(struct panthor_syncobj_64b) : > - sizeof(struct panthor_syncobj_32b), > - DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE); > + sizeof(struct panthor_syncobj_32b)); > > return queue->syncwait.kmap + queue->syncwait.offset; > > -- > 2.25.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯