From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit
Date: Thu, 5 Mar 2026 06:02:51 -0800 [thread overview]
Message-ID: <aamNC9JwxBNBBTmW@infradead.org> (raw)
In-Reply-To: <20260304185923.291592-1-agruenba@redhat.com>
On Wed, Mar 04, 2026 at 07:59:20PM +0100, Andreas Gruenbacher wrote:
> Function xfs_zone_alloc_and_submit() sets bio->bi_status and then it
> calls bio_io_error() which overwrites that value again. Fix that by
> completing the bio separately after setting bio->bi_status.
Looks good, but can you drop the pointless goto label renaming?
I'd also be tempted to just open code the split error case instead
of adding a label for it.
next prev parent reply other threads:[~2026-03-05 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 18:59 [PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit Andreas Gruenbacher
2026-03-04 19:53 ` Darrick J. Wong
2026-03-05 9:05 ` Carlos Maiolino
2026-03-05 9:47 ` Carlos Maiolino
2026-03-05 14:02 ` Christoph Hellwig [this message]
2026-03-05 16:20 ` Carlos Maiolino
2026-03-05 18:09 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aamNC9JwxBNBBTmW@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=cem@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox