From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C8CF246BCD for ; Thu, 5 Mar 2026 14:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772720434; cv=pass; b=A76JQMu5P0pV5QO9cY3Dg6M+soRK51MWVHaWd1frb9iHYWrmvvWYmmp0IgbJHVfLIQt8ZRR806wFhnI8K7B5eaqmh8LQWUH0JPEysp56uLAHKdqhMwI1B5l6UzLvHIWgLop0Y8bkehAwHDu4qJN9rpl4f5mSal9n166IY6DRIEo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772720434; c=relaxed/simple; bh=2FgILoREZAoLlR+DOAYVj76cN/6xIVvADfEkfGNT3ac=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GuUFPP+BsgBudffmsqTFAxIor+wF5BXWUiwxrfMnvzqGBtkttkzG3y6C2EuLp5l+oUbNAGKNMpFCcF9RRcRuzH9/lwB2qJuwMwJkJMZFUl931PGb/YNQ49g1zl9yrDBDOpUBfa7VFeXxx/C40lRKrJmKg4XFzRsCPk4YpxrZg1g= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ziyao.cc; spf=pass smtp.mailfrom=ziyao.cc; dkim=pass (1024-bit key) header.d=ziyao.cc header.i=me@ziyao.cc header.b=NZYJo+ix; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ziyao.cc Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziyao.cc Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ziyao.cc header.i=me@ziyao.cc header.b="NZYJo+ix" ARC-Seal: i=1; a=rsa-sha256; t=1772720394; cv=none; d=zohomail.com; s=zohoarc; b=iChzT7an4CDA50iO2J/RWK6/rLetlJ/sHiZSMdW2V6DJA9YoyQ/ciYwXoi5ZeuWbPiABf6oEZ1hynyjiskc8ekUUjHgcUU+FWrhBSRN7P5dHm4YaMMrXq3RBrVLCu07daNg8v7i5vYxVFvYqve0a8vqUpNftw58YjjEgH6l9qUA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772720394; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=8EH2Wdz/ApHNOs3hATivokwXwEicdZ6f1t/bCh0wnPc=; b=ajrciUiaY7yKwnFzPePJEZ/e7kf69hnwcLiL/RL2yVA+H1PeGwnZHumQrYrUol+9+q7pCnj3X5kypqfUd5ZkHD4xVXoH03JDBvdNPEedkM+PDZVKnKyDlnib0RHUHeJSUe6vRC4jjUBbg/0n3pe6Q92gPskr/PIf+aMFVZWQBnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=ziyao.cc; spf=pass smtp.mailfrom=me@ziyao.cc; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1772720394; s=zmail; d=ziyao.cc; i=me@ziyao.cc; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=8EH2Wdz/ApHNOs3hATivokwXwEicdZ6f1t/bCh0wnPc=; b=NZYJo+ixpOXK6Jsfb8yZWAb1aSXJI0cN/r2Gmi+N+yEe3ueDX/IIv79RibIKudyG xuisfH5OV3PqlB3WamjouJl6m8s0AjwAGozuCPIFPSrOPeIrMCOB0gJe0gZIwC0GsFP KDbx4CR5goFQYjMOKTADEg8wJB2Ybz0+DIUAw9LU= Received: by mx.zohomail.com with SMTPS id 1772720392171171.00297458267767; Thu, 5 Mar 2026 06:19:52 -0800 (PST) Date: Thu, 5 Mar 2026 14:19:37 +0000 From: Yao Zi To: Heinrich Schuchardt , "rom.wang" Cc: linux-kernel@vger.kernel.org, Yufeng Wang , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Conor Dooley , Ryan Roberts , Sean Chang , Anshuman Khandual , linux-riscv@lists.infradead.org Subject: Re: [PATCH] riscv: acpi: update FADT revision check to 6.6 Message-ID: References: <20260305091433.83983-1-r4o5m6e8o@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ZohoMailClient: External On Thu, Mar 05, 2026 at 02:00:50PM +0100, Heinrich Schuchardt wrote: > On 3/5/26 10:14, rom.wang wrote: > > From: Yufeng Wang > > > > ACPI 6.6 is required for RISC-V as it introduces RISC-V specific > > tables such as RHCT (RISC-V Hart Capabilities Table) and > > RIMT (RISC-V I/O Mapping Table). > > > > Update the FADT revision check from 6.5 to 6.6 and remove > > the TODO comment since ACPI 6.6 has been officially released. > > If I understand the change correctly: > > After the patch QEMU v10.0.0 will stop to boot Linux via ACPI. > QEMU v10.1.0 will be supported as it indicates revision 6.6. > See function build_fadt_rev6() in qemu/hw/riscv/virt-acpi-build.c. I don't think so, this condition only decides whether an error is printed as firmware bug when the kernel encountering pre-6.6 FADTs, and the rest boot process should remain untouched. So it in fact breaks nothing. > For Ubuntu this is not an issue as it is on QEMU 10.1 on recent releases > (https://launchpad.net/ubuntu/+source/qemu). > Fedora 43 also has QEMU 10.1 > (https://packages.fedoraproject.org/pkgs/qemu/qemu/). > Suse Tumbleweed has 10.2.1 (https://software.opensuse.org/package/qemu). > > Stable Debian Trixie using 10.0 will be impacted > (https://packages.debian.org/trixie/qemu-system-misc). Debian Testing has > 10.2. > > Acked-by: Heinrich Schuchardt > > > > > Signed-off-by: Yufeng Wang > > --- > > arch/riscv/kernel/acpi.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/arch/riscv/kernel/acpi.c b/arch/riscv/kernel/acpi.c > > index 71698ee11621..ff681db9f4f1 100644 > > --- a/arch/riscv/kernel/acpi.c > > +++ b/arch/riscv/kernel/acpi.c > > @@ -85,12 +85,12 @@ static int __init acpi_fadt_sanity_check(void) > > * The revision in the table header is the FADT's Major revision. The > > * FADT also has a minor revision, which is stored in the FADT itself. > > * > > - * TODO: Currently, we check for 6.5 as the minimum version to check > > - * for HW_REDUCED flag. However, once RISC-V updates are released in > > - * the ACPI spec, we need to update this check for exact minor revision > > + * ACPI 6.6 is required for RISC-V as it introduces RISC-V specific > > + * tables such as RHCT (RISC-V Hart Capabilities Table) and RIMT > > + * (RISC-V I/O Mapping Table). > > */ > > - if (table->revision < 6 || (table->revision == 6 && fadt->minor_revision < 5)) > > - pr_err(FW_BUG "Unsupported FADT revision %d.%d, should be 6.5+\n", > > + if (table->revision < 6 || (table->revision == 6 && fadt->minor_revision < 6)) > > + pr_err(FW_BUG "Unsupported FADT revision %d.%d, should be 6.6+\n", > > table->revision, fadt->minor_revision); Here pr_err() is the only statement enclosed by the if. > > if (!(fadt->flags & ACPI_FADT_HW_REDUCED)) { Reviewed-by: Yao Zi Regards, Yao Zi