From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E03B31F3FED for ; Thu, 5 Mar 2026 16:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772728250; cv=none; b=ZA4rt23dl3ccCbs1XT6FwFuaV0vElt+xvs2Jq+6zFtCdgLPdDBQAPhDRtuwp+bHpu6eccL6a4aUNZPVqQeJosDeUlIfRFBYD8NpKafot9HGSa4NcIGbav/xixhcPBfCwaOHgUFux6EtAMbN4cJ/XSVr/W9IlD/XWdD+DN5JeNZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772728250; c=relaxed/simple; bh=Jj5jf+rN0Jgq1wnZ1221vZG7gvCfoAzGJxGkRGCmPr4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QR3fkyOdDoz7768UyfoTF5/vW6GI/PO6JV3nl1zDRRsIWKKa7D/WQRTGUpuTkDQ30P+RBAseAUhBzW54SqVErQxTu+YJuYh7RyVfpzJiVdffHBgsBm/MaaWlmrM1AFfzNRJWe0mZ6XLnBL8OFhOSTpF+5HvRQGmsrsw73rUmZyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=O4Kajwi5; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="O4Kajwi5" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-439b94a19fdso4427190f8f.0 for ; Thu, 05 Mar 2026 08:30:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772728246; x=1773333046; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wecMzxUhSry0xK7CAZ67a+eo784PL38etV6eDTIVF8U=; b=O4Kajwi533DDhw93eJ/9kNsnQzj8r0uwWxBye+0kdTQtopFuciGzGiqE+p7NM3a7Un Mz4WOGWR6qlarMbo27rJ1N9eOlC2FF3gGf5YoBfq+739AD9Uu7m984WU8T6nACasUGhE fef/rsec5RbS0y4LrAGqbKUDDaQCM0GRrI/Z4EnCt4bU6apxj+ZicsthejLywBFr8xHi ds2zbYK4B38O2QK2+y6dGXC1DVudAxxacnjy1LiXAdHIBowyXrIADxIdJcyOmEvD+Eao PdbOiB8ZZgUDtriIL4VyVnOwhgRuIP2dmKvo5Z9CC097pYpULPKJ0FMq0tE0gLaMKYyX LGTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772728246; x=1773333046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wecMzxUhSry0xK7CAZ67a+eo784PL38etV6eDTIVF8U=; b=SCXVrkEV3q4yffd+OPTW1lw+ZwY1nGdZLam1r2hwua1DS9oSzuF09iqNL0pFMeGR0A XVEmShyoeGJABB5wG0XIVPSgCpSdcBZ3dWImgGCq8PBxDMm+0dsu8XZIWc/J2wgKswpg gsiUIa0krAauWLHm03nLBhoD8rWjn0KN/Yw4dJO65dfvxQw9Z37rfyloiP4X+RXhDt+o aHkh0vvE4Q6mRMZwPXZ/zVyi11R7qJFpOLohnyOnbk6tg6fNc3ylvNdIm28p7Dn1TwFL g1BhwL4pvU2l9N2CZUWRHNf3d7T7cKtLQhwvbbVCrf4ZCmcy4z3/2qcZQn423ZFQ5RrD gH9g== X-Forwarded-Encrypted: i=1; AJvYcCVaTKhkyktp46p5cl6W2KSvdrT0siu6ENmtjOJEFFpSY9JYXZ/n29Wgg/pGbT9uoPVlmUMc4ltf83qo9Vo=@vger.kernel.org X-Gm-Message-State: AOJu0YyzGZ8LylEbKmCsbZjWKhXquEM8e8MW6ZrAu41rX86l6Vx8Ui95 eBauTuVobPp5COevu4wyLLiY24Vhqtb3vwy86uWH5V4ESNNPqU55LJX8bQdKBgF3Apk= X-Gm-Gg: ATEYQzxxiiRAeGeuxAdj69P8fNeEve0/l1AZY92M1Qb9lSVIgVdiUKhO71C1KotEwEx G4/ZN/Wco9Nu0NJ6KSXxLJxhSmS5T/1/uSwetny6EQ568PHqbeob93opnkwCWwUJPejFB4ZsZZr DGCc4WM2nNXAp9Y5gQttX7hiMZBGAEYGv8y2zj7ExE02QqAL1cpb9ppMp6xDtMEO3YQxmf5Xl0n d/9ex9dVCAPChVPEv6+3BBgiUaDqDzzxYJK5oWBwQ7q0WvyGREUjb1OrNtdp0hqaS9ZTtxWJuq+ 0VzJjzPPtjTqMxCIR767a9DXyCPcbXiruKAERl/7gRDRJ2NUQL82jF6OJCpC1pIf+K7Nm+1zN/q LZLN5esY4r/07l//vUcJdv3zmL/2wTptHRWALh8paUn7NzIuGOWpaIqsaAaPI9hRMdr8h7AXwAs ey20BUEYbQAkMQ+1WqfH1EaE3jN/9ssf1nHUbNg9fwrpGY9nZ5SOWL2b8p461LWMUwhaDeJAkZy 0I9dmGThTJnA+U= X-Received: by 2002:a05:6000:2c10:b0:439:b1c3:84bc with SMTP id ffacd0b85a97d-439c7f6501cmr11965699f8f.7.1772728246180; Thu, 05 Mar 2026 08:30:46 -0800 (PST) Received: from localhost (p200300f65f20eb04a10d5fdc728271aa.dip0.t-ipconnect.de. [2003:f6:5f20:eb04:a10d:5fdc:7282:71aa]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-439bb69e098sm25537393f8f.9.2026.03.05.08.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 08:30:45 -0800 (PST) Date: Thu, 5 Mar 2026 17:30:44 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Helge Deller Cc: Helge Deller , kernel test robot , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: drivers/video/fbdev/au1100fb.c:448:46: error: implicit declaration of function 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? Message-ID: References: <202603042127.PT6LuKqi-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yo2bgx5vsettjtxq" Content-Disposition: inline In-Reply-To: --yo2bgx5vsettjtxq Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: drivers/video/fbdev/au1100fb.c:448:46: error: implicit declaration of function 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? MIME-Version: 1.0 On Thu, Mar 05, 2026 at 09:57:29AM +0100, Helge Deller wrote: > Hi Uwe, >=20 > On 3/5/26 09:07, Uwe Kleine-K=F6nig wrote: > > On Wed, Mar 04, 2026 at 07:23:30PM +0100, Helge Deller wrote: > > > * kernel test robot : > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/li= nux.git master > > > > head: 0031c06807cfa8aa51a759ff8aa09e1aa48149af > > > > commit: 6f366e86481a7503a821de82930df517dddd4047 fbdev: au1100fb: M= ake driver compilable on non-mips platforms > > > > date: 13 days ago > > > > config: mips-randconfig-r052-20260304 (https://download.01.org/0day= -ci/archive/20260304/202603042127.PT6LuKqi-lkp@intel.com/config) > > > > compiler: mips64-linux-gcc (GCC) 14.3.0 > > > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci= /archive/20260304/202603042127.PT6LuKqi-lkp@intel.com/reproduce) > > > >=20 > > > > If you fix the issue in a separate patch/commit (i.e. not just a ne= w version of > > > > the same patch/commit), kindly add following tags > > > > | Reported-by: kernel test robot > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202603042127.PT6LuK= qi-lkp@intel.com/ > > > >=20 > > > > All error/warnings (new ones prefixed by >>): > > > >=20 > > > > drivers/video/fbdev/au1100fb.c: In function 'au1100fb_drv_probe= ': > > > > > > drivers/video/fbdev/au1100fb.c:448:46: error: implicit declarat= ion of function 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? [-Wimplicit-functio= n-declaration] > > > > 448 | fbdev->regs =3D (struct au1100fb_regs*)KSEG1ADD= R(fbdev->info.fix.mmio_start); > > > > | ^~~~~~~~~ > > > > | CKSEG1ADDR > > > > > > drivers/video/fbdev/au1100fb.c:448:23: warning: cast to pointer= from integer of different size [-Wint-to-pointer-cast] > > > > 448 | fbdev->regs =3D (struct au1100fb_regs*)KSEG1ADD= R(fbdev->info.fix.mmio_start); > > > > | ^ > > >=20 > > > I've pushed the patch below into the fbdev git tree. > > > It should (hopefully) fix the issue. > > >=20 > > > Helge > > >=20 > > >=20 > > > From: Helge Deller > > > Subject: [PATCH] fbdev: au1100fb: Fix build on MIPS64 > > >=20 > > > Fix an error reported by the kernel test robot: > > > au1100fb.c: error: implicit declaration of function 'KSEG1ADDR'; di= d you mean 'CKSEG1ADDR'? > > >=20 > > > The header asm/mach-au1x00/au1000.h is unused apart from pulling in > > > (for mdelay()) and (for KSEG1ADDR()). Th= en > > > the only platform specific part in the driver is the usage of the KSE= G1ADDR > > > macro, which for the non-mips case can be stubbed. > >=20 > > This paragraph is copied from 6f366e86481a and doesn't make sense here. >=20 > Yes, I noticed that later and removed it already. >=20 > > I'd write something like: > >=20 > > arch/mips/include/asm/addrspace.h defines KSEG1ADDR only for 32 bit > > configurations. So provide its compile-test stub also for 64bit > > mips builds. >=20 > Ok, added. >=20 > > > Fixes: 6f366e86481a ("fbdev: au1100fb: Make driver compilable on non-= mips platforms") > > > Reported-by: kernel test robot > > > Closes: https://lore.kernel.org/oe-kbuild-all/202603042127.PT6LuKqi-l= kp@intel.com/ > > > Signed-off-by: Helge Deller > > > Cc: Uwe Kleine-K=F6nig > > >=20 > > > diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1= 100fb.c > > > index 1a04154bc535..3b104d377d28 100644 > > > --- a/drivers/video/fbdev/au1100fb.c > > > +++ b/drivers/video/fbdev/au1100fb.c > > > @@ -380,7 +380,7 @@ static struct au1100fb_panel known_lcd_panels[] = =3D > > > #define panel_is_color(panel) (panel->control_base & LCD_CONTROL_PC) > > > #define panel_swap_rgb(panel) (panel->control_base & LCD_CONTROL_CC= O) > > > -#if defined(CONFIG_COMPILE_TEST) && !defined(CONFIG_MIPS) > > > +#if defined(CONFIG_COMPILE_TEST) && !(defined(CONFIG_MIPS) && !defin= ed(CONFIG_64BIT)) > >=20 > > The condition is equivalent to > >=20 > > defined(CONFIG_COMPILE_TEST) && (!defined(CONFIG_MIPS) || defined(CONF= IG_64BIT)) > >=20 > > which is logically a bit easier, but I'm unsure if it's easier to > > understand (IMHO both are bad). >=20 > Yes, both are bad. I changed it to your proposal. > > > /* This is only defined to be able to compile this driver on non-mi= ps platforms */ > >=20 > > Maybe adapt the comment here, too? Something like: > >=20 > > /* > > * KSEG1ADDR() is defined in arch/mips/include/asm/addrspace.h > > * for 32 bit configurations. Provide a stub for compile testing > > * on other platforms. > > */ >=20 > done. >=20 > I've updated the patch in the fbdev git tree, which you can find here: > https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/lo= g/?h=3Dfor-next >=20 > I'll keep the patch a few days in there and will push next week. https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/comm= it/?h=3Dfor-next&id=3D93bf32c3d571a9e160306659cef096fe4f79a7f0 looks good to me, feel free to replace the Cc: for my by an Acked-by: Uwe Kleine-K=F6nig =2E And let me note that "fbdev: au1100fb: Make driver compilable on non-mips platforms" is very accurate :-D. Best regards Uwe --yo2bgx5vsettjtxq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmmpr7EACgkQj4D7WH0S /k4sOQf/b3H264Z6fTdkQ/zRLaCAPsWHccANfwe/Gi3b3K3khgUp0/UICFFBlCUe JbmZIdy4dpsTh0vB1rIbsVek+cZI5jKePPaRTYYdUjx+9rqd9h+A85cHuvxaqYb0 6LrsTd/6dvDNPdRwU+o0WWPcGsdRgZj/R58Z1zax5+f6n8nLiq/QSwwHUmV+qSMY o5Nmdx5cDhnTxKxm+g7EK1nuhZx4dAmy8KXUe3R+joNOtVhKhxnkt6/Zn6vXTpFs Ng3J8CS9JEHYPJvb5Dy9wWfYO9xpckzpZxb9aFTGtUeH/v4UhKpkgvDzRl8fU60D 8wMeC66Tf2c/8i+CaiJAAn8if6yzEQ== =TEf1 -----END PGP SIGNATURE----- --yo2bgx5vsettjtxq--