From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09BC32D7DEE for ; Fri, 6 Mar 2026 00:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772757622; cv=none; b=SJwjhBTe2GHxQGsAcFvHQHs/4RcV+BXnK5HL7ZOHCh5POZhEEnLWbiD7F5CKNjc/TUhUFZAo6PWzAgbp/J4lgesRjtfQ39KMs25IduMW0OTjgeordrbVMOB8rudHQ/Q0E+RVh1Ecc7VM1uUIt277ss/Xo9KyimxzxfQcowFZuPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772757622; c=relaxed/simple; bh=jGeYHXh3LlQv45gi9ZQhGp4yio/AGub7iPItilfYkQw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p5D3UqdF/01ZxYwOiSx9xmKFj0Q6cpwgzceDODoHOgma6hrolWiArIFU/eaMPOyQSPGNYFqUGAwx85diQH5cgmvgq/Ab4M8ZOjKwmva1Qeqbvsmk9lBCJ/PFAlv71p9s23IonPcqT+Rr15apMQS+IghyhRRjKa1v5WmrTqxs36E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SKkm3pnq; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SKkm3pnq" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-829781b2b01so1472915b3a.2 for ; Thu, 05 Mar 2026 16:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772757620; x=1773362420; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Vwm3wwvpSH+RZbikS9WmeaWeWABu5ZF4Jeo4IRWuDNQ=; b=SKkm3pnqrONZcf3GIeifQ7+UrEb7eTV+U5vW/z38cm3jO5qEj04huTGCMu/OK1yk8I SQtI1MNtP4k9YMJ2K0vgOvoScrWY3xdhc7vvjbevVLEPc5LmRDU4FJxm8U0tumeLDtcn FRL1k6XITPzcUPaes6TXcI9sgb4Cv0JwngTmh6rlSNuR602spK/R+dyDz2nF+7OaR1iD 9RUYEGJj8/jKlllfBtMOtXJXLASerAJItIhHRLVvB6P7RaHo4uDbDhKy9UcAXTjWOwr/ 9uE0hwFdw4ZIhYItwESX7Ytvko7MXMllqf7B/RExJgxpSFfBy8UUYjjOkdCYDn7a25JV GNsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772757620; x=1773362420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vwm3wwvpSH+RZbikS9WmeaWeWABu5ZF4Jeo4IRWuDNQ=; b=ThlxE840sZ6n1EyiARsvMk858mogMmmDgFDX+WJcQitU+ILoXMdNfAh3T/musOad9b Qfa15hakkHC9olTpGe+jCz14jQgfFcUou2S0RyPcQ1kUXFH9ACqRdSDyj0Jj1hFPJxbM tMFw7Ygn1pEOyQQV9eYjCCFPV8y+btmRTaoLuq6kcgRcpMwCCsI5ZF0XeT2Y72jaGWQj JX0KvUpdOsk3X/2ZBR6A3qu8Ps5aN4mU2ZShNfbjZuQ+weXmXpZuoYcC1dXXXDaKYaps Rh+07LjGDIrdkdzEuWN+cm/aZX9KondBqJ3+Qo22PMdhBed+R0V6hkyum1b8/9vaCcFo HKkA== X-Forwarded-Encrypted: i=1; AJvYcCVieujEZiKwhNtkv95PDBmuDcYQSbjnxbNA/VqB1JNmQtXbiKHYH5KS7nDQC5gegc4zBYExMarhrrLj+pY=@vger.kernel.org X-Gm-Message-State: AOJu0YxmJHIXpB7ZAZw8s5+dICrXI+30bomOTj8PGc4bdKv/w2+VUvij nqrkNmutFwab/62GwKyQq0176yh8/BjACLmaikMK9mWHot37XI/VDOcC X-Gm-Gg: ATEYQzzCpTWhkUKYTfm6F2phulqVo262/aq+XlRS9HT/PPaPGczZRjNQacBl3Dgp9u9 C0c4u+bwMNm0ooW/rKssW7cdPHqRgoLCEu9JikNwNE1VKKvEw/u7fpXzu8bchDWKsVEq20fhQP9 1fDFQbqlugBqc1ptTADpS0hg6f+fetCRpPk9U4RuaJtmnz/40RkmHJ/wQTavnbpUi0xK93SM5iE gk934s9Eovt5aagSFnjzzhWgllK9Y1BtQYZUMWTQEjDdQxZAI1o1L1e70yXvwaVS9HA9BXM/SRn AvLJDIvPVEPnO6XtyK0SLSaRSvnMNbRigKfwmhoRIH3JE5ZNbS9D15km9qCXxeeSRxTUcb0NS4K brPkirjKRgw3iOLp/mztILZflJMCndQhAHYnZaW3KJnaxjEtPvoRZqoKDbC96O32WYAyP827svn Iu/R59XS+oGEYrDw== X-Received: by 2002:a05:6a00:9510:b0:81a:883d:cd05 with SMTP id d2e1a72fcca58-829a30d0307mr163580b3a.64.1772757620313; Thu, 05 Mar 2026 16:40:20 -0800 (PST) Received: from localhost ([27.122.242.71]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a01080fsm22107684b3a.46.2026.03.05.16.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 16:40:19 -0800 (PST) Date: Fri, 6 Mar 2026 09:40:17 +0900 From: Hyunchul Lee To: "hch@infradead.org" Cc: Viacheslav Dubeyko , "glaubitz@physik.fu-berlin.de" , "frank.li@vivo.com" , "slava@dubeyko.com" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "cheol.lee@lge.com" Subject: Re: [PATCH] hfsplus: limit sb_maxbytes to partition size Message-ID: References: <20260303082807.750679-1-hyc.lee@gmail.com> <5c670210661f30038070616c65492fa2a96b028c.camel@ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Mar 05, 2026 at 06:27:34AM -0800, hch@infradead.org wrote: > On Thu, Mar 05, 2026 at 09:29:33AM +0900, Hyunchul Lee wrote: > > Sorry it's generic/285, not generic/268. > > in generic/285, there is a test that creates a hole exceeding the block > > size and appends small data to the file. hfsplus fails because it fills > > the block device and returns ENOSPC. However if it returns EFBIG > > instead, the test is skipped. > > generic/285 needs to call _require_sparse_files. > The generic/258(src/seek_sanity_test.c) is considering filesystems that don't support sparse files[1]. int test_basic_support() ... pos = lseek(fd, 0, SEEK_HOLE); ... if (pos == filsze) { default_behavior = 1; fprintf(stderr, "File system supports the default behavior.\n"); ... The issue is that there are some tests which write to offsets larger than the block device. How about skipping for such test cases when dealing with filesystems that don't support sparse files? [1]: https://github.com/kdave/xfstests/blob/master/src/seek_sanity_test.c#L1244 -- Thanks, Hyunchul