From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AC6B3368AF for ; Fri, 6 Mar 2026 05:46:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772775999; cv=none; b=GKBlcWfy6L4t871vxtIFeMVBj9jolh86I/JDAuSzOKu53Pd4fxZCySCJl3esGu3Qw/xYDbIy1g7dQKWrOamX/SH5XMpK4Iu9As4wPHJxGYyPUCghN8/wL7RGe3Hfad9psK/R5PoN0TQdknkjfmVIe50w7UmPmsZCbaHbLQwvA50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772775999; c=relaxed/simple; bh=zzdM36DZXzpqXW2HCeVuTJfRUIds6cQ/vA2K83YiHiQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=atlzjy6yiM0XU4ea/ihsKx68mRZnmUFOtk7uC9K2w2WbJ0d1YWI2zwWD0SlLjKNfzM0Q5pQYAdYS7XrUWJdsIv/YscZ6oQFAP/YcT11JBSZnts8gMxFePsm/r0/fvUVrQwEnNaBj5wr7JUpNAdnmMU7u6uqlKsYDRYry6SvMlF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AWrVqOSC; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AWrVqOSC" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-829781b2b01so1592684b3a.2 for ; Thu, 05 Mar 2026 21:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772775997; x=1773380797; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8/SUdjzXEhgvW5puvAWCH8rFOth0bt7gLsKBvzrE17w=; b=AWrVqOSCF4tVsH3LKrViS0TBB/mCu+XfuJLol9byqdNwtRINAUv//iKW+aoip1jfRt dmR7waQY43sMsRDjIgZLU9mBhJ7RJ+KaZr95nKslNdwNxrMWS6GBMlan2DI6JnXzDjha Wazc/ANKIq3syQxP5u7N43MZnD4iCfybFbTIZILDhOu4Ukz74x+HpuBVCkUgBCNQMnhC 8UmN7yOHo53i7Vg4eaMkvD9m6B8HbHHqT7InQomZpVDV1YQxxLD+KKOLr1WEMBjCNW1v ITc/VlT2RLKSD0A4kPGpDFE+U9eABBuSTIy4TbqVOnKaMcbxmEQOmxkyaavC4hi9GWzr Km0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772775997; x=1773380797; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8/SUdjzXEhgvW5puvAWCH8rFOth0bt7gLsKBvzrE17w=; b=jsvt8jWZ14Nbb4E6F/3klPEz4Gp0wMjP9qlQG5xj/QlscghWtVoaO2q7FJPlp+tVdd WuOHnPKtgb7bla9zNzfSAwZN7D9gc0qtvrr/B7eoJ1L9DSKPIKaBTb/gAL5N7KlAJAn9 JhJR1qB33dm3CyRdryPt/ecvwt8ryonXbeQLbYFIf9hF9Nyqtj/2st1YTk0ndRPurkEq Mdw0CIPp9lG7C+RcfqztoUoekoRFLH0UPsW8BnBybBsyAj/idjg2yVq11PnAtjs6CcQk PKZWiUSbVAPhtd7TAfwvP9RDUQY2hErrcFqCMOC1DGSZbr+GM/F8zA+Ve1PcXaJAsSYP Hcqg== X-Forwarded-Encrypted: i=1; AJvYcCXFWUCDb6RUHJCDlbaYVfrqxPgksJQ68K0uvKY0JSxsajuqjkewQf/QZDUpdGaFZEqUcEzstAgyAFbaWf0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5ViiEo4AeyKZAdYPlXMVWTVmuckpTLZwfpc2tMX7xMURDQ/7l ErdLzUMxfQ2SMCPhyn/rGwK359nOjpkCrPOJGb1JPffhSS2qgX55PSwK X-Gm-Gg: ATEYQzy39evp4PyWQzdMe2ELXD+uJDRQog/iJNpmbrXUGfcTgz8l0XXjNtcfWEHF6wP ddLW2immSRyUhw4jNgBYL8CzPRjNhD+nLuc4i1RQcMlwYacQh68CpDxwNJxGkNL+bCOohmFy/YC jis4U7PV7w0mc/yo4WWlpjXKEuRhbhZxleu9tOlx7iT59UfW9u9E8JDQBPU0aCgt0R/pDiT0giH CpgAZkDab5wZZyjOxtW4SgmmwdOt3BtLny7l8ReoURo+oeXUXtG+q/oYY4EAl/u9oBk5rjpUNc9 zO5S6Up0dC3RfC1zMU3SY5HXeUoI5qaZHjg/CbUDPCStJKb4vlqVl21/B4Bhvwk6LqMI40bFOuJ 3ZFxSp99ALokd9q9I63KbJUR8Gua35KIY6EkfyLWsX8FnPJekHnZVEdDMa4xbe47e9rZYgbP1ls T7nCmbpqPJko/lgDlT/IjWVXTg/Xe7vYKz8zadB+iOv1lxbWsz0OTzCW2wphUEqNM= X-Received: by 2002:a05:6300:4045:b0:38e:9405:beff with SMTP id adf61e73a8af0-398590de607mr1154590637.65.1772775997179; Thu, 05 Mar 2026 21:46:37 -0800 (PST) Received: from eric-acer (36-225-117-207.dynamic-ip.hinet.net. [36.225.117.207]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e182d72sm424979a12.25.2026.03.05.21.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 21:46:36 -0800 (PST) Date: Fri, 6 Mar 2026 13:46:33 +0800 From: Cheng-Yang Chou To: Eric Biggers Cc: herbert@gondor.apana.org.au, davem@davemloft.net, catalin.marinas@arm.com, will@kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jserv@ccns.ncku.edu.tw Subject: Re: [PATCH 1/1] crypto: arm64/aes-neonbs - Move key expansion off the stack Message-ID: References: <20260305183229.150599-1-yphbchou0911@gmail.com> <20260305183229.150599-2-yphbchou0911@gmail.com> <20260305193847.GG2796@quark> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260305193847.GG2796@quark> Hi Eric, On Thu, Mar 05, 2026 at 11:38:47AM -0800, Eric Biggers wrote: > Instead of memzero_explicit() followed by kfree(), just use > kfree_sensitive(). > > Also, single patches should not have a cover letter. Just send a single > patch email with all the details in the patch itself. > > As for the actual change, I guess it's okay for now. Ideally we'd > refactor the aes-bs key preparation to not need temporary space. Thanks for the feedback. I'll send a v2 to address your comments. The arm implementation also allocates struct crypto_aes_ctx on the stack in aesbs_setkey(). Should I include a fix for it as well? Note that I can only test on arm64. Also, I'd be happy to help with the refactoring if you can point me in the right direction. -- Thanks, Cheng-Yang