From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDB0236829E for ; Fri, 6 Mar 2026 17:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772818357; cv=none; b=RCPLP8ug4r61kGm3IsEjrop9Y2SoMKh6k4Ts1JU9L6xUnEFLQb+SvccopQWBkU2ZjXD8vR/IpNoQ4kGOP7guGYC1JNIVz3RnhDq5YF06zeoWxNQ9DfDo/wYrQL6/EAjhBCBK6s5askLNaxl4ejRRquQvnP0PiwCYGdOhbZl6Mok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772818357; c=relaxed/simple; bh=bIxrx4KoLTRQn4XRd5Efn4xp/evATyJ+zwU3/uVKTz4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nX99quuXcAHhrbrb1iy0pMZKL8aR1JVMa/JzUaRS4b1xQXvueY3DxOuP/3e3WUInyQ5Od6x9se/7dWdFeGVjbAd54H+HxLbfc+dwB8uNM1yVx+YbzTpwHI9XPQb/b0bLsAHQvQI1Bqj7szalAJ3Qgg3qTdl9V6xYfb6DJylgiIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lJnLJBIc; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lJnLJBIc" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4837907ec88so109032645e9.0 for ; Fri, 06 Mar 2026 09:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772818354; x=1773423154; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=/vcQthuk1eWzIx9SkfXAplSVF+zzfp3bHB4lRD3w+Jw=; b=lJnLJBIc1ZBH86wfUNtyAfhXTbL94Kt2oQrsHurvUN2KFu8IXpFusZKKorF0e8v3fX aXqwJAL9RufrR4jNwJKB/KphH5EFn90w34anqjhWi8COeq6GuM2frgKyHOSt+xHBGXMe f7HTA3Pk7HzldbyQxam2WeZ3zusng+1aMPgOnRp5q1yc4i69hiaMrnaMb7/xHZU3mdXR 9csfD9J/EBfzrcjlgCOxTwzU2TZo1g+YVQmDlqVR5SnXljND3AdKhnshaG7gbJzjLkG9 9bsdkX5Ab4c3svjr9n/Na7AHK04hon7W3bQL0gm3Jm3pjXdPKa3aDLBf7KMvtj45MAI0 jhtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772818354; x=1773423154; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/vcQthuk1eWzIx9SkfXAplSVF+zzfp3bHB4lRD3w+Jw=; b=JtF4DvS0Wa38ZP3cc+jUopGAFOY/twB61wnVWCCjGc6F7VZrggNlQEPqZbNn+t4HTU jYtO/mMJFTS0prSoEqhDCF4cwK4pLToPuO5YDGoULtMVzvSkxMdSWiquI6zW//hvu/oi Pou1pAMI7wuW0tSMj+x4BG/9UeVaTbaHQoxthy4+c5b8UUldcbhwV47mbZary1EtGjdx hwLEiOIGTh1C2F4U7VQ7dTq8XAAwOzLdc5Z62gg3fPgq42BXVuoLHoOKEUsJqZRK5CaQ LbA+cfaG3yHsyDK2OP2s7IMDDKLA/X0V2bNf4zF7VUj7KbkCWOfS8mnphy7iZ/SlxR/7 uz7g== X-Forwarded-Encrypted: i=1; AJvYcCW7r/UCPSGKAgSOT24pABQazHc5XFtOtHRrWxC+XkhKmheY2bbxn+WCZPAcnYRiIviFB+o6mM80/KHlb2g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9tm1nRCoLaigmTa/0ASoHZ2aNx1v1BYwjQ65Dqbua+WxuSltQ 1EutNghtBeFtxv7ZlGmaZYrIpikK9UdIIrVSBbiDujoLIKXD3otsvZddCw7P2djBLyBxX0RRlX6 rSnKSnTvdNNVTAAa0YQ== X-Received: from wmc2.prod.google.com ([2002:a05:600c:6002:b0:483:43e2:3e67]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4710:b0:480:20f1:7abd with SMTP id 5b1f17b1804b1-48526978dc0mr46728455e9.31.1772818354024; Fri, 06 Mar 2026 09:32:34 -0800 (PST) Date: Fri, 6 Mar 2026 17:32:33 +0000 In-Reply-To: <20260203-inline-helpers-v2-3-beb8547a03c9@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260203-inline-helpers-v2-0-beb8547a03c9@google.com> <20260203-inline-helpers-v2-3-beb8547a03c9@google.com> Message-ID: Subject: Re: [PATCH v2 3/3] build: rust: provide an option to inline C helpers into Rust From: Alice Ryhl To: Miguel Ojeda Cc: Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Alexandre Courbot , Will Deacon , Peter Zijlstra , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Nicolas Schier , Andrew Morton , Uladzislau Rezki , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-kbuild@vger.kernel.org, linux-mm@kvack.org, Matthew Maurer Content-Type: text/plain; charset="utf-8" On Tue, Feb 03, 2026 at 11:34:10AM +0000, Alice Ryhl wrote: > $(obj)/bindings/bindings_helpers_generated.rs: $(src)/helpers/helpers.c FORCE > $(call if_changed_dep,bindgen) > > +quiet_cmd_rust_helper = HELPER $@ > + cmd_rust_helper = \ > + $(CC) $(filter-out $(CFLAGS_REMOVE_helpers/helpers.o), $(c_flags)) \ > + -c -g0 $< $(if $(filter %_module.bc,$@),-DMODULE) -emit-llvm -o $@ > + > +$(obj)/helpers/helpers.bc $(obj)/helpers/helpers_module.bc: $(src)/helpers/helpers.c FORCE > + +$(call if_changed_dep,rust_helper) I think this needs: $(obj)/helpers/helpers.bc: private part-of-builtin := y $(obj)/helpers/helpers_module.bc: private part-of-module := y at least it seems to make a difference for AutoFDO. Alice