Re: [PATCH 1/3] remoteproc: da8xx: Use dev_err_probe()

[Mathieu Poirier <mathieu.poirier@linaro.org>]

On Mon, Mar 02, 2026 at 01:56:14PM -0600, Andrew Davis wrote:
> Simplify the probe() code by using dev_err_probe().
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  drivers/remoteproc/da8xx_remoteproc.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>

I have applied this set...
 
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index e418a2bf5d2ee..41744f3f0252f 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -306,10 +306,8 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
>  	ret = devm_request_threaded_irq(dev, irq, da8xx_rproc_callback,
>  					handle_event, 0, "da8xx-remoteproc",
>  					rproc);
> -	if (ret) {
> -		dev_err(dev, "devm_request_threaded_irq error: %d\n", ret);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "devm_request_threaded_irq error\n");
>  
>  	/*
>  	 * rproc_add() can end up enabling the DSP's clk with the DSP
> @@ -327,10 +325,8 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
>  	drproc->irq = irq;
>  
>  	ret = devm_rproc_add(dev, rproc);
> -	if (ret) {
> -		dev_err(dev, "rproc_add failed: %d\n", ret);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "rproc_add failed\n");
>  
>  	return 0;
>  }
> -- 
> 2.39.2
>