From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2DC6346FAE for ; Fri, 6 Mar 2026 17:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772818489; cv=none; b=AoXDkYkSZQitYhVzG+a3ZGbE88Bwt6dx4joh2V+Am0U7Vq7zW+WFOpFrTY620raTN/Afs3iJhd5ScSvNEAvFhp5pXEqbQ+glv4hPpw0+lUTXQHBWhTRANxwANd9zRaCs5qza3ZiiqDwRZYR4kqjFFRAUE2GLp4pSW6RTfSImE64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772818489; c=relaxed/simple; bh=LIUVnBp5hbFOVSEmSvLbcJixaQOUSFJO5X3jFVJolf0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bi4REwIJ+EwIRBEVahDQJLoXyLE8A1XmhGuY4dJ29l4cssEtWgh/QSv2jhIkVaLObjegK9oCUzbe24IoNubYPl+cXhyd8fGoQim+fi8N1v/c0L9xGEMXbh16C0PoJDltn+Oom27Oe7M0W6gwLuXf+2qbCD42JKqoW4djwmfoqZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pRJ+zzgy; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pRJ+zzgy" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a8fba3f769so41968715ad.2 for ; Fri, 06 Mar 2026 09:34:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772818487; x=1773423287; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bsHwjpX3svwQqcv4ZOpNtbWOptDgn+RVXMCzx3rQGYM=; b=pRJ+zzgyhB5yLzaXpCouPqBxa8EMbpZJWaTm8N1HDz9GMTv1h246Hk0ru4vyIh1rVj tVWsSOL9O4tgb0gUS2UiOB8hnndkFvWaJGXCBkYugCnaijL9N/ETzlrPTeayvEshWEiU vqNk7SmmSIgJaYjMc3bPU+Wf8MWQVTfAS2ioj9Ust5rKoDs6AzAXT0C9g6GlIxsS0m7P Jh6ZDhtwLFKRR82SDMi8lxb4+3r3ulrksFuR3/rfipSeKaFe5ORs4r8UTzJkSDcnDJws YxiE7mUm/yQf2Gj/P5o+rbuAY0vvuXJ+aftF/4cNiKHoFxd9423LpPQj1paGy0lok3fd mzNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772818487; x=1773423287; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bsHwjpX3svwQqcv4ZOpNtbWOptDgn+RVXMCzx3rQGYM=; b=IDKXog+M8TdjNYnhHva0dKPm+VNHeK4XXaKiB9M4pzMmoRRvTbNg6dLmgyIlHEeOh7 FeFnnx6HJQwxIATOG/aMXA/RiVUC1iu7JqtJwr6N00ddYAe/mqApHarww7BTzeGU6sxX B0OmdHYxRo61+Clet92C0e8XeXon/9zHPfyOckm/GzTRbxZtIFMfVJyO92K7ROAYTmy6 NDBhkNxcaS+wbrX1BuAbGvSlSo5LQ7tF3GGE+CCc8eRXlA1mgaCaXdDkeJYw5olxlfDr pXvoNry1RPShV8acfhABoAIdJ0OHpsecKZ/jCJmQwF0inxChIQZ4XU1MUnJkdOly3tMU fofg== X-Forwarded-Encrypted: i=1; AJvYcCXASTGNZ3nNZZu+/0cVg2GrOq1aUcMlGv0M5TJ7xSMb1MfGwCuC1NFfwQm3nDyFynIc5Ma3GpSUXhe9CtA=@vger.kernel.org X-Gm-Message-State: AOJu0YzdUCaXqPzm03mRQVTe8/5pGpFgLlJgKQ7xnu4MrLCAegzJv39v q/6jY+3/uMBN61BNm9HGNvziG7s7lW6WAEpclwgQWfCtuqwv7RQMjvDJzbYzTN0AXI0= X-Gm-Gg: ATEYQzz8k5WECtrItmzW/gRIKf7vWsqfCmHbbAySC9mSeqJZ81/udLgs1GOox3v0VjG IaSXknmvuV4P1Cg1CXJMP/u27oYOs6UMIaZMwGH7gDRMs+ETB66h1K0fhFKH2oojdXott9vEeLj 8bmQbgwtYEy7Jb7i98CDLvuPnG0yWDBcml1BcpZi/Dul1LhH3HGJB4M5mgbhWn8fc8zrHV0hAKv +IKy8BT8tZl38q4So1nWCh5R6YteYg3GLPkB/FtuyBYATdR+hdkcA4mB4Bkf/DgNqH82ycr/BXG aLLyvC2OwbW8ccCdt4/6kkPMSTRgRn/q0MPcJxgiWIlDWtTZRLI7/xqHpCvvsJKRQq+JTzfodol AKDumAwG59IiGyf+1PAXjN2vzuD7Pa4L2RUlFtXdap/arilPcnp5GUGwOFIzTmVA9ivMZDJfesL CcO/I/9Ln9iOLQpa6JqJFHLtxvQ+g= X-Received: by 2002:a17:903:110e:b0:2ae:6457:3099 with SMTP id d9443c01a7336-2ae8243413cmr30310095ad.26.1772818487132; Fri, 06 Mar 2026 09:34:47 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:4b1b:60d0:c217:8ee9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e57cb1sm23272465ad.9.2026.03.06.09.34.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 09:34:46 -0800 (PST) Date: Fri, 6 Mar 2026 10:34:44 -0700 From: Mathieu Poirier To: Andrew Davis Cc: Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] remoteproc: da8xx: Use dev_err_probe() Message-ID: References: <20260302195616.312378-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302195616.312378-1-afd@ti.com> On Mon, Mar 02, 2026 at 01:56:14PM -0600, Andrew Davis wrote: > Simplify the probe() code by using dev_err_probe(). > > Signed-off-by: Andrew Davis > --- > drivers/remoteproc/da8xx_remoteproc.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > I have applied this set... > diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c > index e418a2bf5d2ee..41744f3f0252f 100644 > --- a/drivers/remoteproc/da8xx_remoteproc.c > +++ b/drivers/remoteproc/da8xx_remoteproc.c > @@ -306,10 +306,8 @@ static int da8xx_rproc_probe(struct platform_device *pdev) > ret = devm_request_threaded_irq(dev, irq, da8xx_rproc_callback, > handle_event, 0, "da8xx-remoteproc", > rproc); > - if (ret) { > - dev_err(dev, "devm_request_threaded_irq error: %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "devm_request_threaded_irq error\n"); > > /* > * rproc_add() can end up enabling the DSP's clk with the DSP > @@ -327,10 +325,8 @@ static int da8xx_rproc_probe(struct platform_device *pdev) > drproc->irq = irq; > > ret = devm_rproc_add(dev, rproc); > - if (ret) { > - dev_err(dev, "rproc_add failed: %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "rproc_add failed\n"); > > return 0; > } > -- > 2.39.2 >