[PATCH 1/2] remoteproc: pru: Use rproc_of_parse_firmware() to get firmware name

[PATCH 1/2] remoteproc: pru: Use rproc_of_parse_firmware() to get firmware name

[Andrew Davis]

There is a helper function to get the firmware name, make use of that.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 drivers/remoteproc/pru_rproc.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index 5e3eb7b86a0e3..19b107d29242d 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -1003,11 +1003,9 @@ static int pru_rproc_probe(struct platform_device *pdev)
 	if (!data)
 		return -ENODEV;
 
-	ret = of_property_read_string(np, "firmware-name", &fw_name);
-	if (ret) {
-		dev_err(dev, "unable to retrieve firmware-name %d\n", ret);
-		return ret;
-	}
+	ret = rproc_of_parse_firmware(dev, 0, &fw_name);
+	if (ret)
+		return dev_err_probe(dev, ret, "unable to retrieve firmware-name\n");
 
 	rproc = devm_rproc_alloc(dev, pdev->name, &pru_rproc_ops, fw_name,
 				 sizeof(*pru));
-- 
2.39.2

[PATCH 2/2] remoteproc: pru: Remove empty remove callback

[Andrew Davis]

The .remove() callback only prints out a debug message, remove
this otherwise unneeded callback.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 drivers/remoteproc/pru_rproc.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index 19b107d29242d..a4636c7bc6b7b 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -1078,14 +1078,6 @@ static int pru_rproc_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static void pru_rproc_remove(struct platform_device *pdev)
-{
-	struct device *dev = &pdev->dev;
-	struct rproc *rproc = platform_get_drvdata(pdev);
-
-	dev_dbg(dev, "%s: removing rproc %s\n", __func__, rproc->name);
-}
-
 static const struct pru_private_data pru_data = {
 	.type = PRU_TYPE_PRU,
 };
@@ -1131,7 +1123,6 @@ static struct platform_driver pru_rproc_driver = {
 		.suppress_bind_attrs = true,
 	},
 	.probe  = pru_rproc_probe,
-	.remove = pru_rproc_remove,
 };
 module_platform_driver(pru_rproc_driver);
 
-- 
2.39.2

Re: [PATCH 1/2] remoteproc: pru: Use rproc_of_parse_firmware() to get firmware name

[Mathieu Poirier]

On Mon, Mar 02, 2026 at 02:27:27PM -0600, Andrew Davis wrote:
> There is a helper function to get the firmware name, make use of that.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  drivers/remoteproc/pru_rproc.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>

... and this one too.
 
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index 5e3eb7b86a0e3..19b107d29242d 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -1003,11 +1003,9 @@ static int pru_rproc_probe(struct platform_device *pdev)
>  	if (!data)
>  		return -ENODEV;
>  
> -	ret = of_property_read_string(np, "firmware-name", &fw_name);
> -	if (ret) {
> -		dev_err(dev, "unable to retrieve firmware-name %d\n", ret);
> -		return ret;
> -	}
> +	ret = rproc_of_parse_firmware(dev, 0, &fw_name);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "unable to retrieve firmware-name\n");
>  
>  	rproc = devm_rproc_alloc(dev, pdev->name, &pru_rproc_ops, fw_name,
>  				 sizeof(*pru));
> -- 
> 2.39.2
>