From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7CF036681E for ; Fri, 6 Mar 2026 17:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772818515; cv=none; b=UyW//HB9xSCL7GHzVYQ7OI4X6mji3U33wjhnmdm6T3EjugP4VVEXGqtRdJUtaGvr18s7QUMqsmyK3o1Fqp46snZvfYQH3hpRBX1bN0MMzxqCi5k0cPhRtKRXBJM4bWVAsT6msQQTXQ5xJS8Nd8XnnxoObWpPgi3TCQO583JhhCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772818515; c=relaxed/simple; bh=fzatlw/sCgbsp4Zu7cdwZDd8/5isaVX+doRyzZoCul0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k7bqDjWQfKLFdkugFcmksy37HgjrZGyVgbdadxoahTiabBief9LZMFV++fJmuxFYvNPt8wbllH7N7MpSqHokozfdnZ894ZC4SAMMjEZAdxP+ec5kxtq1bzPP+rruZzKG5FuuqJWB8w0rrmji3SakGDoichWA9qDHJmAEqDMDODU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HMapg1Y8; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HMapg1Y8" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-35994d84c6dso2425960a91.2 for ; Fri, 06 Mar 2026 09:35:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772818514; x=1773423314; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eTcvKh0v+GT0/XHMN8tpZZrh9YCPVH8ZIPfysGX7h7c=; b=HMapg1Y8yXhsMQITWuju0F8lmHSGlqQo+O6r5FhdozvzD5vOe+u+JzWgdfrpxMO70R 5710+R6Wap1Qj4xlran6074QgaFbg9Sm659spKPXdOLpN3kJjOwrlNKJKk5qsNm6WF6m kKdJp9Kkyx7bOD7R+GCGg6w1rnBzNVp107xIKnGQfUHsNy+mAlXWxH7USjXE5yRobTJL 0Pl8KAlBnyVJAw10WDbjh8ey7xYzFI9+b1AoYcRU2TGayCvx0GDNiftmWfGvVTmtbOHL EJNEIOJGOnc7tXrNXZZ/HNK8+/EEwpsCikmqux3xA8HuioEzhpBKGrqp2ZANJXoWw1KF pwWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772818514; x=1773423314; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eTcvKh0v+GT0/XHMN8tpZZrh9YCPVH8ZIPfysGX7h7c=; b=VwMQqcviSvKPXxkoepkWHgeQRLAUJEotAtv7Hjj97INrYrGJwTIB37QXXSIHcs4Zq4 +MewAgDnpG638b6gFIovxWqiJzUOqjgvYuxQTJEZy7lYsjlOASpJyIffzCDOZnbuS6bv pCG5hafNY9JobJDh6/Hw1qpLXlzxR7468ZNEi+tIcUqcIhpsjmQsbnX62KhfDaPzvD0a qdn6Lgk/Q9AFSaAMKRCnX6wLnN1uO46ZONMUpGj2Lev9ZEMZwqN/3jh0BI3pUKWpHrr/ kRvzEVfWDdUYxDcPxWyLPE2rE7E682oQlJ3Hj1zFzT7X5r7MJHmRM90OZUwQe1Uo9ag9 OKpQ== X-Forwarded-Encrypted: i=1; AJvYcCWCw4ImcCuyALE/lWJ3jJWKebvfZD8jANR2V+lMPAm6Q7qWTkoNiKGRHB7yyI2OP4j2fUciUtCPK75Uimc=@vger.kernel.org X-Gm-Message-State: AOJu0YyoWJoCYQH98BsgLb9DRi1seltzUSDXaLn9RP1NkkwGJY0f9Vpp xjsuYPY2564ryXeDnjXXKxN+h4TDgu66Rwog27in9zCZcXtr7GXWMVMF9zLbhX4WCOc= X-Gm-Gg: ATEYQzzmPQZV0fmfZ8AGWFukFGonHWTCw+n5R/O55/7PlJSRLCnNgE4ntU49EZUJk8e 7hBD7GpPDeikivw0RUncU6Rxr2lnjnznU7tWK0l4bJ+UZAOGaqu3icC4CuHV3x51aGLyMCnQ5Ds v3mxXGzDCOeth+PUmngES/A0wHTJG29AMLeNeND+XMVc3W4UpSv2KHPWXub2FSj9GuArM7JFv2v 65KAsL0dESw6P/QEOfMjxYUrfgRVilLPTg8F8Y2QQAkH+/+AZ/wu1BTdaNSjPVhPv7x/D/+0nxD EIYrODVk9caMVAVM+nKTl0Of4JD9gp3djusXdgturdYWpgHi0mxzKz0q5wIGiy5hCe3XjZY8LGV lFbRmV5sgUdhbpbGNfSCklMVaglPBS8MCvFBHQTvSoxkDr+AVdg0w9zQAHEqL/U5I+CHwCH5vin OZ2+rsWqM0JAb0Pv+2CG7oh7rFjAU= X-Received: by 2002:a17:903:2ece:b0:2ad:ba04:40ca with SMTP id d9443c01a7336-2ae8247b5demr28807575ad.25.1772818513931; Fri, 06 Mar 2026 09:35:13 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:4b1b:60d0:c217:8ee9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f742a5sm25044815ad.54.2026.03.06.09.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 09:35:13 -0800 (PST) Date: Fri, 6 Mar 2026 10:35:10 -0700 From: Mathieu Poirier To: Andrew Davis Cc: Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] remoteproc: pru: Use rproc_of_parse_firmware() to get firmware name Message-ID: References: <20260302202728.322073-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302202728.322073-1-afd@ti.com> On Mon, Mar 02, 2026 at 02:27:27PM -0600, Andrew Davis wrote: > There is a helper function to get the firmware name, make use of that. > > Signed-off-by: Andrew Davis > --- > drivers/remoteproc/pru_rproc.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > ... and this one too. > diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c > index 5e3eb7b86a0e3..19b107d29242d 100644 > --- a/drivers/remoteproc/pru_rproc.c > +++ b/drivers/remoteproc/pru_rproc.c > @@ -1003,11 +1003,9 @@ static int pru_rproc_probe(struct platform_device *pdev) > if (!data) > return -ENODEV; > > - ret = of_property_read_string(np, "firmware-name", &fw_name); > - if (ret) { > - dev_err(dev, "unable to retrieve firmware-name %d\n", ret); > - return ret; > - } > + ret = rproc_of_parse_firmware(dev, 0, &fw_name); > + if (ret) > + return dev_err_probe(dev, ret, "unable to retrieve firmware-name\n"); > > rproc = devm_rproc_alloc(dev, pdev->name, &pru_rproc_ops, fw_name, > sizeof(*pru)); > -- > 2.39.2 >