From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0DB13EDAB0 for ; Fri, 6 Mar 2026 18:20:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772821223; cv=none; b=meUWOUKiHfVq76HcAJ6Ebv/1UPQkKfmnXrJBEkvdSeMKpa1xXkaijj9paa7Q7RIlJMrIfMWrYcujIvKAGr6swZToZJEgjo2nbnHXXhVFWg9PlEPYMxpPy8yYfiHQpz15Qn1Ye+dbzOhd22+W5r70a7X+vZvaOLYK3mYhPY/wFTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772821223; c=relaxed/simple; bh=XoUdcp4sZ9u9yg4lARLdJdb4aYqyVRFrJzsGslmOESs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pHI7NtQn79SeJETSYc5qYl8TAE0CS1uGTkSP++UQrmmRa43FsT7w/M2NA+7YvvE+gQlNTcpgJiJcw2LdSpUY+lY+LRa54+5mODAxfgA1zQ5Kh2oY1SXI1THKhigT3PGkf7z+N+uQVSZhRckcvYM0YvmOZ+khBNq6gFLnKTyoeGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=QJICmul+; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="QJICmul+" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-463f00cda04so6029999b6e.2 for ; Fri, 06 Mar 2026 10:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1772821219; x=1773426019; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=39xArBXSs4Whdyj6F5WRF6OsnU4hIyo+O+UjLfGtF8w=; b=QJICmul+pdmTPnZHJDzAOAITtJ28yp5mDYwa9oTL8ZyFndiFiSOr00VvEzBPlc4S4s H8CLznSDxypeOxBy0HVbR7z3ykm2m1m+XXDPzC3m23jWwM4lHRn4L0RlFdQp2156L2CQ KqCP/Q6WtyzOMSt7RCofu9+FoA8KvSTpf49snhZs4uwI2JPNbtjIKJTovlpwy+JPwzYp jt4Ych2qnsCJ5yuzxdfLJ7bEduzeVIsd0iv7jtSNmyBxznqx/vQHeq1xUxpDmhpfm5ie vUIxnB65PjIEUfHaLQX9E+ZCM0AbwnjJLN4Bsf2Y7fP4enFHSpENtgaoV2POFeO/jOwR YFFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772821219; x=1773426019; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=39xArBXSs4Whdyj6F5WRF6OsnU4hIyo+O+UjLfGtF8w=; b=AHgTvLlHiy7+OSrz8FKxeqYm1ny7JzfDV65Jmz3WYz0lAScWy/rVs0U1rhgTmIHfvS PefDoYm7AUI3+/FgYqB3RPFa4/aRv7k/J/kgJ/9F2mUXLzQYy+2Adzi1j2lj2KPSgA1x yRDYh9tJJFSpgvHN9YksT7Ag5t0Xs24d6l2affa5er1lV4w6LGn1AiFaHpasaAJmF9JZ zc8IkpMWE3tDnMc1z8sIMIkjNYrLO3MptFmCra6QpCNNOQIJ7zrZ66CPxCgKA/jwpQAQ UpMnwQIOeCCqPJfIrMU/OJVL48L70AHNB7h1yUPLaeWC/bq/rT3LLswSOp+GTZ3XXVE3 lhbg== X-Forwarded-Encrypted: i=1; AJvYcCVJQjk+FS2OleoLxrttR2hAPLPt9CrwAdy6n1w+MXMexDEqYBecw45Wniw18c4CFymT6HYVC0O9jTbZ8os=@vger.kernel.org X-Gm-Message-State: AOJu0YzrHg3KiBy/O9Ar8y2QbL690wywsz1fHGnfsJkf0g+Dq+hX+yRj 1GECko9CP4c9YUnx2awMNlyHAXqJ2I+CRIoQMckbgBvuXGlZL+asPArD+D7ZDLRMr0g= X-Gm-Gg: ATEYQzzuEVjliPk19RMbnllnrSPpFqK51oUKlfb2dDsbbPFkRpINnwqkg6HFOq4fDy9 IWjRTEcmELe5zZxEGn9RLYetsjxROH+K6Ji1tbF5HLzHOv+/VH7CT6d/Pdb8EE+8U1MeCu1Xgl3 t5u8amaZdYn9MoieAJEuBnLMS1nRosA6YSEdrbWB4aungVaW3SJRYpNOXgkdaFhKHWbSLdJqCQg y5KIuhwf8D1mqqZko7CbiZEQKyNaL1ue3yrOzYSHxImiVA+lv+qOPFjqt/8yAgGV6ZWXUlyBU5D W9sR/8QDgUkw1Z/nmJZaaKrqX94JZ9ZcOwEUDwvFH8gBJmvWUvAKXe+qIQerOKgwdUQ4q6rjxby yqvb4XAWN93jWRbFos2eCytiq7tRDNOi69T9n09V9zn0jPFl5gp4h57OgfJSpILl3CMjK5j53HU R/tbvj/Q== X-Received: by 2002:a05:6808:1641:b0:45c:8675:eef1 with SMTP id 5614622812f47-466dca16637mr1603487b6e.3.1772821219577; Fri, 06 Mar 2026 10:20:19 -0800 (PST) Received: from 20HS2G4 ([2a09:bac1:76c0:540::3ce:23]) by smtp.gmail.com with ESMTPSA id 5614622812f47-466dfac17b3sm1112878b6e.14.2026.03.06.10.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 10:20:18 -0800 (PST) Date: Fri, 6 Mar 2026 12:20:16 -0600 From: Chris Arges To: Pablo Neira Ayuso Cc: Florian Westphal , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , lwn@lwn.net, jslaby@suse.cz, kernel-team@cloudflare.com, netfilter-devel@vger.kernel.org Subject: Re: [REGRESSION] 6.18.14 netfilter/nftables consumes way more memory Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 2026-03-06 13:25:44, Pablo Neira Ayuso wrote: > > I see what is going on, my resize logic is not correct. This is > > increasing the size for each new transaction, then the array is > > getting larger and larger on each transaction update. > > > > Could you please give a try to this patch? > > Scratch that. > > Please, give a try to this patch. > > Thanks. Pablo, Thanks, I'm getting this set up on a few machines. I will have: - 6.18.15 (original kernel version that repo'd the issue for us) - 6.18.15 + this patch - 6.18.15 + revert rbtree patchseries I'll compare memory usage with those 3 variants and give a response. --chris > diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c > index 853ff30a208c..cffeb6f5c532 100644 > --- a/net/netfilter/nft_set_rbtree.c > +++ b/net/netfilter/nft_set_rbtree.c > @@ -646,7 +646,7 @@ static int nft_array_may_resize(const struct nft_set *set) > struct nft_array *array; > > if (!priv->array_next) { > - array = nft_array_alloc(nelems + NFT_ARRAY_EXTRA_SIZE); > + array = nft_array_alloc(priv->array->max_intervals); > if (!array) > return -ENOMEM; >