From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8125E29DB9A for ; Fri, 6 Mar 2026 18:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772821031; cv=none; b=nSlLW+jTPd+RiONcEsvL3mue7isD9SQmWXQYoSmkNfy22UyI14TddUgP91ae4tfky3yc/5ug7VVaoI4phhGMEdtV8grePRG/gcfLHC/tquEBfh5NwxnQZ/3VkCFx/jDBOvtRFuyrgvsbOFdv6OxGLkqBG1bkPgk+e5ZeF3jk8yE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772821031; c=relaxed/simple; bh=tSfUI3NJI4sLf/nmJL25/P/qckWuIbQ2wxSW9jiF/QY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Td4a4Cd+c3SMuHYQTdXty+0ETAyZCIHuQ8MRGL3yzH1WwAYMcOgyumaFdQnFR3liuYK9TxBimcrS7GTcpD0prd8TiXk82T3nfmHSrK7AjVU2AyPuJo4mh2Ssbg3/oYk4yAF7kTsim6ZQu7qH9hmFD0MFTAuqAv4rID+e6IgmhaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BDqqKVXC; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BDqqKVXC" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4833115090dso98654965e9.3 for ; Fri, 06 Mar 2026 10:17:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772821029; x=1773425829; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JKhWB5WYBOgtNloQxw0BE+V1Qr8Hll+qJ9pU1AjFn3k=; b=BDqqKVXCRaRrNa96j7ok/jk/5AKDKairm2dSXvZiesFXPu53lv15uF0sKbq/i2ZTIt fgzHHeOzl1BpmPcIz2Q/2skgHsPw6/CshJEJjQFv09FLBHJJXjSUAE/fYHUa/YS4N87j Tg0wQQoev1bMnzq7ssU/cnWSD66jo5fij3+OLv6xeL8o1Xsd19hQ7IEkq6CjG/hut1HD azGxtm2TJ/pkynJKZTzg/a5Diahw2+luGGY8nGR4Q2LGRj84xJnAtgicwERwt+OOWAm3 32FxHRwbdLBdgt9pBho6clooVUyF66UDNuoof+mJzqhWJ8Zkg7E3WnX3r6qFOXChG4OY d+Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772821029; x=1773425829; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JKhWB5WYBOgtNloQxw0BE+V1Qr8Hll+qJ9pU1AjFn3k=; b=skvxk9K13UqCEN8YloM7xTO2CB7O4Ly9kv99/0qI7b9PPMvQW7uVWXvlgXeFz2t7YE xoC4o39CB3GhJ6NxCVKM4zqXNOkWj+nFCkXTkltlBf0yGG1cOtZARIP+RCkTIN6ro5tm iDbv7hwX4cBvTxTwhMWUh+FaMukOb3ovFx5X27wpNl/ATAEcgjEd6YQjFf2uXhfNdAjS q3+WCxPJdTtHud6A6sSEryQQmHIb1W7KgY5l4Y2ARwWKqVKz2z+SHS8yOu9CWBW5ujG8 Zay1Qz22A9Gz6XYri2HJoh/VY0pOEWTy03dHX+5+UDP1v2raybMH39ZWf5dimu3/+nkV xskw== X-Forwarded-Encrypted: i=1; AJvYcCVgFxielN9Kzgrxi5fBLk2oRTvajzN+mzm6SvNYaU4a/spKQryXXh1DdM74lWcdQvn4AIO/ZLPwyDoelqc=@vger.kernel.org X-Gm-Message-State: AOJu0YzQVTzYSa1F10pEhptvnHW7GvHBxvLxQo+yfxIhnRoGeH8ol1Jq 4n5+M8esms6OVmaBfAaulCtRAk0PlRnzCV4QdP2X1ThMibZ9+wx70qYMlzOd1LfKQ84= X-Gm-Gg: ATEYQzwZfva8O/MxtOzyWskJLiHDpoSMYqNLdQumh9nqZLAX5gXUtpz8HD3mO6IU3AX Oi67BDptZnhySCBeBQrjkahbfXQzULu4UjSXxw69BFZzM1J7o9B5QKgpRNj0HNjHBykPgcATx9Y DFTBQoQi3ltFykFZRW9LAy8c24nBKueEVSsq6OV5MOYDBhLzasruF8xd/aGS2fyD0GFlelhz9hY cGhO7kKa/dcygUgh22LmOAX53OiS6pCVsFdb/x9VY4IS0HNs08ahi0ybk3kxPURRPVjfUE1jIS0 ge1FuGjJWDe0cPiJymidQLAkh/08vEAWgblTEknmvM9eXTbIpFuBaYuT7IAZM1icI2UzSymo0tT 9wBdD2kQ34tc5YW4RP5EN7T0Gq6Nk7geNSudKK8HM6QG8YHpM8ijwSKjGhpAaAfn5sM/DlDufzi 1qMSfCY3GdYQ5t0KfVF/6svrdNCiG6 X-Received: by 2002:a05:600c:c088:b0:483:79a6:e7e1 with SMTP id 5b1f17b1804b1-48526919935mr46682665e9.7.1772821028821; Fri, 06 Mar 2026 10:17:08 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fb27a20sm250849705e9.9.2026.03.06.10.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 10:17:08 -0800 (PST) Date: Fri, 6 Mar 2026 21:17:05 +0300 From: Dan Carpenter To: Richard Lyu Cc: Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: staging: ipu3: img-mmu: fix sign-to-unsigned conversion Message-ID: References: <20260306144307.670648-1-richard.lyu@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260306144307.670648-1-richard.lyu@suse.com> On Fri, Mar 06, 2026 at 10:43:20PM +0800, Richard Lyu wrote: > imgu_mmu_unmap() returns size_t (unsigned), representing the number of > bytes successfully unmapped. However, when the alignment check fails, > it currently returns -EINVAL. > > On 64-bit systems, this negative error code is implicitly converted > to a very large unsigned value (18446744073709551594). The same happens > on 32-bit systems as well, although the resulting value is smaller. > > Return 0 when the alignment check fails to correctly indicate that > no bytes were unmapped while resolving the following > -Wsign-conversion warning: > > drivers/staging/media/ipu3/ipu3-mmu.c:393:24: warning: unsigned > conversion from 'int' to 'size_t' {aka 'long unsigned int'} changes > value from '-22' to '18446744073709551594' [-Wsign-conversion] > 393 | return -EINVAL; > > All callers ignore the return value, so this change does not affect > existing behavior. > > Fixes: 26f5689592e2 ("media: staging/intel-ipu3: mmu: Implement driver") > Signed-off-by: Richard Lyu > --- > v2: > - Added note that this affects 32-bit systems as well. > - Clarified that all callers ignore the return value. > - Added Fixes tag. > - Link: https://lore.kernel.org/all/aarQeHfQuq20gXH0@stanley.mountain/ Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter