From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BD1B1B4257 for ; Sat, 7 Mar 2026 02:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772849234; cv=none; b=H8NA8+Te6hisYcVUBfoXKU6kBxti4ondj1RzkYDOAwu1OFUzuD3S41fRam1yImzlY9Tp2DtU4SVIe9lsXixFDZYf4KcnW1pJ0lQO0dlUeHQ9nmqN49pRcDq1BTtXg2Nh9GaAmSvvifGKFqr5wOhwRvvGOMJXXP3r/Meh7fF36mA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772849234; c=relaxed/simple; bh=zl3C3R9LMNZuD8fFBXpLcvHjwMV/uqnWTf/1hBT8wsI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IoOqqAUThrTf2A4Uaye69+tOrWUqniafNy2G5UmMnXA0Z50reBJ6MM9exMH4+I+d85++fYsY8MFmvTCmJoDNTgus+fNsWhBC4lkCTyVmmJoLYAbWaQlB9B/IHibq98m5Hf0MqhNFbgptELQVuGRnznOzEza1ddt765auhcbUEtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XwxBtjP+; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XwxBtjP+" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2ae4af66f40so71159415ad.1 for ; Fri, 06 Mar 2026 18:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772849233; x=1773454033; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4+UoRrpddV2Fy8n72X0PUQuiXrofIoHgnww81/fG+ME=; b=XwxBtjP+3acTVw1qfu1vBIGSen5vXPQ70icSX/Wfxi4Rw8jo8gyuXWXA+d/E4hZZ5i CTqZTMaa7n2CsNEpp9ZaiF4kK1RYtaTRYiubXa9aUHpx5BZJ4fdmAReQ256Hyv/hF+/m uxSrWC2OSd3M647XXb2pJ11duCMJIysXWVMpUqf8o/CuTt57nyVHGsFIdGT7o9aGkKxu mt/qpkx5+g7u79E9AqX+aIEZxf6ID7jgWs61g8SfZdI61WNlCcOOgd3v/qy09EFKEcWY 2fukQqOuvH2W0GYllUnv9icP3LAr/bhPw/Jh/cLOLa+dkk8XatkB0jaoAwIpHDU2qhyy pw8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772849233; x=1773454033; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4+UoRrpddV2Fy8n72X0PUQuiXrofIoHgnww81/fG+ME=; b=eDJ3yVZaimz9PptNIyVkpauAHRy74E4F6EIqX4G4L1Z0cvtT9B3jIzvH6hNNPj5bCL kCj4Y2T9o6pdOTGuqUtJx1pny5juXbvth7fo3gTxoRYQtpwADa805P6FesJEKvOeXz25 qCpF0UcEA52INBKz87VEWuw2pUhfiZDS5ytByI+AodE8LyZLW5cEpp6jOTkUSbTUF+ua 1s5QgFBtg93bAKr74CVJI9y7epL7BjghTBMtQCo2gwGrXJHynwkYn9YbBB/DG+M5SG+e S4+83bf2q+FmxwicTV1dR3lk/WXQA8e0xQtmlrQfpeB2GiSqGoKZm5balF0YveTUNBgu S9hg== X-Gm-Message-State: AOJu0YzgWjw2LT18sQOvmK+vQJSb4knUETVytHnys1EaOOSaBs1Krxb6 aT9ldNTmyv7FJXHY8c00ydR5ghs2lM4Lk1wTtK8Cz23HThcc0kJioW5uoMl29BOeTW+Uu4IO6gh 53UpgQg== X-Received: from plcp17.prod.google.com ([2002:a17:902:e351:b0:2ae:5344:9e72]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:c406:b0:2a9:484c:ff2f with SMTP id d9443c01a7336-2ae823a1df5mr41713865ad.23.1772849232601; Fri, 06 Mar 2026 18:07:12 -0800 (PST) Date: Fri, 6 Mar 2026 18:07:11 -0800 In-Reply-To: <20251026201911.505204-14-xin@zytor.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251026201911.505204-1-xin@zytor.com> <20251026201911.505204-14-xin@zytor.com> Message-ID: Subject: Re: [PATCH v9 13/22] KVM: VMX: Virtualize FRED nested exception tracking From: Sean Christopherson To: "Xin Li (Intel)" Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, pbonzini@redhat.com, corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, luto@kernel.org, peterz@infradead.org, andrew.cooper3@citrix.com, chao.gao@intel.com, hch@infradead.org, sohil.mehta@intel.com Content-Type: text/plain; charset="us-ascii" On Sun, Oct 26, 2025, Xin Li (Intel) wrote: > arch/x86/include/asm/kvm_host.h | 4 +++- > arch/x86/include/asm/vmx.h | 5 ++++- > arch/x86/kvm/svm/svm.c | 2 +- > arch/x86/kvm/vmx/vmx.c | 6 +++++- > arch/x86/kvm/x86.c | 13 ++++++++++++- > arch/x86/kvm/x86.h | 1 + > 6 files changed, 26 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 550a8716a227..3b6dadf368eb 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -760,6 +760,7 @@ struct kvm_queued_exception { > u32 error_code; > unsigned long payload; > bool has_payload; > + bool nested; > u64 event_data; > }; > > @@ -2231,7 +2232,8 @@ void kvm_queue_exception(struct kvm_vcpu *vcpu, unsigned nr); > void kvm_queue_exception_e(struct kvm_vcpu *vcpu, unsigned nr, u32 error_code); > void kvm_queue_exception_p(struct kvm_vcpu *vcpu, unsigned nr, unsigned long payload); > void kvm_requeue_exception(struct kvm_vcpu *vcpu, unsigned int nr, > - bool has_error_code, u32 error_code, u64 event_data); > + bool has_error_code, u32 error_code, bool nested, I think we should pick a different name, as both VMX and SVM declare "nested" as a global boolean. I.e. this creates some nasty variable shadowing. Maybe is_nested?