From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 091D125DD1E for ; Sat, 7 Mar 2026 02:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772849418; cv=none; b=IfNqp5rxc84WHpKuugr/pgiG/aEmavhr39SzYFZjRmBaN7fspgXQl3r/x/SS6ewgHAVIOMUcVlFlWs9TMK+0RB0nn9gikMoU2kuONuU30zraJFBEzO4zAANgG+oWnrx2qYSaJJvoSHb3Orb0wSfgtSSK9Z+7kwAi1ERUZFk8MYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772849418; c=relaxed/simple; bh=9h4cduGK17GQj8nyW3SF7iI1VXySYDk0sliwwVt98BQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Nz/vbqcDByl031vA8Hzv+Wag4b2pgZATgPhaaN6LNGanvO4YeYWce79knjES7sLewKpDqXHksp2Br1tPUKb6aQg6Ez31plH78NclglpjtrdmjQ8PORWdLdoFctoAD0JpFtgdnJUdBtdF16JSYUxAwwguNYksCKH08zxRi62eJQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KX7V6fFa; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KX7V6fFa" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2ae66ee7354so39909305ad.0 for ; Fri, 06 Mar 2026 18:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772849416; x=1773454216; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VA9d9qqBA64RLM6+sK3wbxGS9ABEXBuT3KUjnzm+Jyg=; b=KX7V6fFabBjiWcPBeGIRKxStTzKZGW7PKod9DQwxvDQaZGw+gIKfh8WvFNkjk8SOiQ dcsuK8uYywQvnNQgtyJ/ciR0bIbjL8OSs8+ERE1Da8SaaIud4ge/tuWwRDYW7CFXe7zK BDNkD4Y1c46/o+HdfLH4oewkdp38oD9nuH1NkPUoQhPY3F3VUMK53f1UycEu+/4xFP5w RV/BA4y7WSu6Vojsy7u9j38UnJXbEft+MmSGuJrDSQmU3XeRzwctTyLyjv7ELMNlxVxj X9jgO+smJKOA8zoLVnbOUFO9oTD9wISyTYpICo43gv7nSUDp6re0sSjxAmAxpXX8Itfu 664g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772849416; x=1773454216; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VA9d9qqBA64RLM6+sK3wbxGS9ABEXBuT3KUjnzm+Jyg=; b=X6JldHHQqlV/52RWCXi120RCerXT3W1qd7HzrVEvYi1fAU9Y9ja5vT2DWbI7c1Vmwl wreVZzl21K5AJUWC4mfNDFqVEGFjS0Zle6E0XxsZ93M9zSBfd6n/Xc536Ec4EeOH85Di 2G8zQST4V5T4qybPFFuxONYb6rPONlkIoYqcKFXzhc92q7hllnC1pKOytuTbXngv8lAG R+eSirtB0pKCJuDmG5BicweDCxbilmtYWmGBXcQWt325Mv9KCHzZtJGWea89kLpxZ6uy vvwpI+KnL87sDDU79P/BBfJQ57tFwEMcPoE9c+6fmsjNcRsyr1lt3fRw2gg/To9azzAy ckVA== X-Forwarded-Encrypted: i=1; AJvYcCXXMW2B6cQNilU7s6slfnuQdWFAz9HzL8TRWgzKWxQZ1SZ5ydzPV1D2NYg53eHnoJ8KEAdczbWxny3n9lA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6E9+D9+vJSQdu2XS28DWG35vzINYlPnkcB3Nfn5XXZwbIPAJA TbRgLLtdLUqCtwZaYOIYS8WtKPPXfwfUh41RL0LPr7VNZiA3nCcoTl6rjULTYbXmGQDSLn3zc6m JgJJFBA== X-Received: from pfiy21.prod.google.com ([2002:a05:6a00:1915:b0:7b7:c77:a04b]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:a06:b0:38b:e9eb:b12b with SMTP id adf61e73a8af0-398590877e7mr4395240637.41.1772849416212; Fri, 06 Mar 2026 18:10:16 -0800 (PST) Date: Fri, 6 Mar 2026 18:10:14 -0800 In-Reply-To: <20260129063653.3553076-3-shivansh.dhiman@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260129063653.3553076-1-shivansh.dhiman@amd.com> <20260129063653.3553076-3-shivansh.dhiman@amd.com> Message-ID: Subject: Re: [PATCH 2/7] KVM: SVM: Disable interception of FRED MSRs for FRED supported guests From: Sean Christopherson To: Shivansh Dhiman Cc: pbonzini@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, xin@zytor.com, nikunj.dadhania@amd.com, santosh.shukla@amd.com Content-Type: text/plain; charset="us-ascii" On Thu, Jan 29, 2026, Shivansh Dhiman wrote: > +static void svm_recalc_fred_msr_intercepts(struct kvm_vcpu *vcpu) > +{ > + struct vcpu_svm *svm = to_svm(vcpu); > + bool fred_enabled = svm->vmcb->control.virt_ext & FRED_VIRT_ENABLE_MASK; Please use guest_cpu_cap_has(). The VMCB enable bit is a reflection of the guest's capabilities, not the other way around. And s/fred_enabled/intercept. > + > + svm_set_intercept_for_msr(vcpu, MSR_IA32_FRED_RSP0, MSR_TYPE_RW, !fred_enabled); > + svm_set_intercept_for_msr(vcpu, MSR_IA32_FRED_RSP1, MSR_TYPE_RW, !fred_enabled); > + svm_set_intercept_for_msr(vcpu, MSR_IA32_FRED_RSP2, MSR_TYPE_RW, !fred_enabled); > + svm_set_intercept_for_msr(vcpu, MSR_IA32_FRED_RSP3, MSR_TYPE_RW, !fred_enabled); > + svm_set_intercept_for_msr(vcpu, MSR_IA32_FRED_STKLVLS, MSR_TYPE_RW, !fred_enabled); > + svm_set_intercept_for_msr(vcpu, MSR_IA32_FRED_SSP1, MSR_TYPE_RW, !fred_enabled); > + svm_set_intercept_for_msr(vcpu, MSR_IA32_FRED_SSP2, MSR_TYPE_RW, !fred_enabled); > + svm_set_intercept_for_msr(vcpu, MSR_IA32_FRED_SSP3, MSR_TYPE_RW, !fred_enabled); > + svm_set_intercept_for_msr(vcpu, MSR_IA32_FRED_CONFIG, MSR_TYPE_RW, !fred_enabled); > +} > + > static void svm_recalc_msr_intercepts(struct kvm_vcpu *vcpu) > { > struct vcpu_svm *svm = to_svm(vcpu); > @@ -795,6 +811,8 @@ static void svm_recalc_msr_intercepts(struct kvm_vcpu *vcpu) > if (sev_es_guest(vcpu->kvm)) > sev_es_recalc_msr_intercepts(vcpu); > > + svm_recalc_fred_msr_intercepts(vcpu); > + > /* > * x2APIC intercepts are modified on-demand and cannot be filtered by > * userspace. > -- > 2.43.0 >