From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A69E2797AC for ; Sat, 7 Mar 2026 14:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772894384; cv=none; b=SgDN8He2pK6InwzmoAPMRm7H9vNDUj+Lptvs/BE8k1E1A8KLJvi+mfLxmAnzyEMQK5/qscqLsUKYjjSWYDZ3jV1ZqNEyJipkrLaokZaXSop79D+wJtYMMD+5l4X1Q2f/799hXyLjSq+GwEpceXChXvGGqimqnuo2ejlC3928tTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772894384; c=relaxed/simple; bh=BARth34Yph1cf5m0V/wl5J3UZE1mf+ZrtvgNTrr9e7o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JZNvwcMfztfPbhJgVAzfAp7aDlV5zyW7bOntFaUqMysSv2JthIuSdZ207vpB9wsAhnby7aU54hfcVPRIjXPcX5UnoJw8t39P+nYuh3Y43ISvv2DyR1jWAA0dTmQBU23vz9T2lwk/0b7W359LhHUfCiuOqRP8IMngAq7lW0XNgPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=emywp5TP; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="emywp5TP" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-6610bd5f322so6384479a12.1 for ; Sat, 07 Mar 2026 06:39:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772894381; x=1773499181; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hpCq+Q4/Fku+DsEBvJwO7OxmVZJajB6rcPiIWQF8jOw=; b=emywp5TPQrPyhD1HcPYMKmZpinggMAF6oBGwhz3vYtuEFbQkqJSEj1QeCL3ZMVGJTI iwUufmcYigLYnRxFENIufFqF6lmfzEUTRbi3PBUElxa7AVNo1u3AOd2DJmduC2pOnoZV x1l193Sea+CMGs+dd3VR6ppRVp+XuYAp16R4DQdp3+oG9eTW1U6YNN2Gey9PphmqfsJ4 gJeu3gL5hbThghBoQaSV1SLxD3wkm/vmR1uTicb7X/FnooImec41sizco1MDCQJbxugJ AWFGTJxeG8oswqAktlTIfFYqjH+M2KFomaiYkTenitnO+gV+l9FUPeRfPS561UQBSWlw 162g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772894381; x=1773499181; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hpCq+Q4/Fku+DsEBvJwO7OxmVZJajB6rcPiIWQF8jOw=; b=ISU2XtjN39Cruidesr8RhXu/1J8EoOJJswmVECK1kikUlFAyFa1hq3tWzBlCEe0uUt tHtLW0T+jdzjsll9TkVl/6o67P495rgIrUfdSAot1vGwYqQcH77cSq6hMKEBndlVABIo em3736pt7jOPPn2kqGujn02JBTBCXdnsb08pzKIUumy8q/et2j6+AAjbds9FFrDUt8mg 7oMZQhnsKrcRPjxU0EUGIYjlu+QjcLTehzlQVjNHmrwbciRGhcBX8fzTw3W7PYmiRH2Z HRTpBXN2bCRcu6YZ9fgpy4z/S71cqUrquYaTirbqhVf6pmKzf2DLUoFIbOuQgFBxMtO6 5IJg== X-Forwarded-Encrypted: i=1; AJvYcCW93uKqE7BK+RQQ9EKZUP5YSmfJIPcN2JIoz7Yn/H1369sIXQHHhdMFEsZ2cSrH1yGxzPDUPT59ayNqGuE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7ToX6tBhAX+Blfytk8KyDwi7TjNlDo8emT4eKeoAX0v/dnRZe PUrLPC75sE6IL+wAAYR4d5DegKrHEIH1dT9WCVVisYsU24rF542ROXmBTrY3b56W6IU= X-Gm-Gg: ATEYQzzZRCX5Ab8xwSqjeOJur0djWfAG1Bo8seqLUHNgGPR/M/0e6snMaor/tSeaMo8 NIjCE8q+eFDDj9YoAAdfqhkYnjojer2+ctk20O+dJ0MyIUfi/6mfk9x+AShlnCUu9GfoRNqua6I wY0wsvJV3wAc2eLkJtP+srNjmvRy5mlAgy064dX6loDprtPFQCKT4GEbP8s/at1CldTIyKmmzxj WOVpv46BzdYgdmY6MRYV6dYs1lSq+V1EW8mu92uIdeuB7zqYoZImX99dEMPDW3IuCmOmzldO+jo 1GonduLGdDd2Gbt3t+RzkrRwG+oJZuwYFG3hnW+cAOABX02aPv0/z49Uv7kr/LgrM8OdmXggsYC xJ16PRiqNYyKq8XQXQ18W+Lye/F2MsSQaNNdycItmRDwExxjaCwb4CxHIuA4ZYTeUvg90sgLAMP KwJL0YRqYSAiA3UgkUDZa/H4iRTxFf X-Received: by 2002:a05:6402:268c:b0:661:93ed:cebf with SMTP id 4fb4d7f45d1cf-6619d51a156mr3250392a12.25.1772894381431; Sat, 07 Mar 2026 06:39:41 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-661a55a660csm1248151a12.33.2026.03.07.06.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 06:39:40 -0800 (PST) Date: Sat, 7 Mar 2026 17:39:37 +0300 From: Dan Carpenter To: Rachit Dhar Cc: Viresh Kumar , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Rui Miguel Silva , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] staging: greybus: resolved checkpatch checks for light.c Message-ID: References: <20260307140930.1732-1-rchtdhr@gmail.com> <20260307140930.1732-3-rchtdhr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260307140930.1732-3-rchtdhr@gmail.com> On Sat, Mar 07, 2026 at 02:09:25PM +0000, Rachit Dhar wrote: > Added comments to mutex declarations, to resolve the associated checkpatch.pl checks: > > CHECK: struct mutex definition without comment > + struct mutex lock; > > CHECK: struct mutex definition without comment > + struct mutex lights_lock; > > Signed-off-by: Rachit Dhar These kinds of things require more than a two word explanation. It should probably be a paragraph. But first do a proper review of the locking. When do we start needing to worry about concurrent accesses? How is it accessed? What would happen if the locking were not there? Is the unregister sequence correct? regards, dan carpenter