From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ilvokhin.com (mail.ilvokhin.com [178.62.254.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F4B92E62D9 for ; Sat, 7 Mar 2026 14:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.62.254.231 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892609; cv=none; b=Tn0yq69pL2XFjXsLZAIi5o0A+4clDFjkOIYnckhPC4wjHoE/ycCHbafHhCcZQZJ6XqvFW4GfRW30fVAQd00jWpgVA3lthv16Wf0nj4cCug4lyHdWHgvbvrZvqvhF/OauAgOa1NHF7x6h3bP2sZA3Nu3rBPl54aba3jDumkd8Cw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892609; c=relaxed/simple; bh=u75JTT/VbR9IVE6fo9nKJ1PBlCw8FCFM1uHnndSA5wA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qPB9o+V5thsYeBjt5rnMcAy2MdsC4kjnAgjBnrs/AiA930ovMKI/RRMpNh/UFVDuHVcTatITOLYPD26+zoYmHF3jUbhy510XRZdLzsR6b8W+jcrmaGVGmtmO1kpnlUWTQPXdv8qheih69aIcVv0QltfDGGtJAeNPVmqB5lm7DmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com; spf=pass smtp.mailfrom=ilvokhin.com; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b=ujxH/YQ0; arc=none smtp.client-ip=178.62.254.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b="ujxH/YQ0" Received: from shell.ilvokhin.com (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 47802B3509; Sat, 07 Mar 2026 14:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1772892600; bh=RM+Hz9YH+3ijyF4ASnaYHms+P4W04IcR81Vaa3/ZpsA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ujxH/YQ05q9ZFNSDyFCZ1YR46Y6t85rj5qkuY775bNT3qzXYk5c0/A8PIyWS5RL2Z o1zATF4Hj1rnDr/AN6RZFS1ROw6CX4gl2Mm5oNykswDaRbm98SHzc8j7DGVoc9wEqp j76QCbkivRDwyIQXJscX+ujcDy20UUBqhToZ7FG8= Date: Sat, 7 Mar 2026 14:09:41 +0000 From: Dmitry Ilvokhin To: Peter Zijlstra Cc: Vlastimil Babka , Steven Rostedt , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 1/8] mm: use zone lock guard in reserve_highatomic_pageblock() Message-ID: References: <20260306095336.a79fcc869a7f6d2b2e97501b@linux-foundation.org> <20260306130052.7da8eab3@gandalf.local.home> <20260307131641.GX606826@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260307131641.GX606826@noisy.programming.kicks-ass.net> On Sat, Mar 07, 2026 at 02:16:41PM +0100, Peter Zijlstra wrote: > On Fri, Mar 06, 2026 at 07:24:56PM +0100, Vlastimil Babka wrote: > > > Yeah I don't think the guard construct in this case should be doing anything > > here that wouldn't allow the compiler to compile to the exactly same result > > as before? Either there's some problem with the infra, or we're just victim > > of compiler heuristics. In both cases imho worth looking into rather than > > rejecting the construct. > > I'd love to look into it, but I can't seem to apply these patches to > anything. > > By virtue of not actually having the patches, I had to resort to b4, and > I think the incantation is something like: > > b4 shazam cover.1772811429.git.d@ilvokhin.com > > but it doesn't want to apply to anything I have at hand. Specifically, I > tried Linus' tree and tip, which is most of what I have at hand. Thanks for taking a look, Peter. This series is based on mm-new and depends on my earlier patchset: https://lore.kernel.org/all/cover.1772206930.git.d@ilvokhin.com/ Those patches are currently only in Andrew's mm-new tree, so this series won't apply cleanly on Linus' tree or tip. It should apply on top of mm-new from: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm