Re: [PATCH v4 next 09/23] tools/nolibc: Implement strerror() in terms of strerror_r()

[Willy Tarreau <w@1wt.eu>]

On Sat, Mar 07, 2026 at 04:55:06PM +0000, David Laight wrote:
> On Sat, 7 Mar 2026 12:37:35 +0100
> Willy Tarreau <w@1wt.eu> wrote:
> 
> ...
> > > > > +static __attribute__((unused,))
> > > > > +int strerror_r(int errnum, char *buf, size_t buflen __attribute__((unused)))
> > > > > +{    
> > > > 
> > > > Here I think we can simply do this to comply with the man page:
> > > > 
> > > > 	if (buflen < 18) {
> > > > 		errno = ERANGE;
> > > > 		return -1;  
> > > 
> > > Looks like it should 'return ERANGE' (matching glibc 2.13+).  
> > 
> > Ah you're right, I initially misunderstood the man page as "a positive
> > number with errno set". But yes, returning ERANGE is fine!
> 
> Which also means I got the return value wrong when I made it
> return the length.
> 
> Might be easiest to apply these patches and then fix it up?

Better only redo this one. It's always bad to purposely merge a
patch that we know has an issue, it can complicate some bisect later.

Willy