From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1BD23090FF for ; Sun, 22 Mar 2026 10:04:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774173883; cv=none; b=BOf/Pa4Ixn9qchzFbQwws0uDDzCozu7f+0vAAkhE194xoQKLFan8VpspZV8fZt/RRP2DPXx/SZ3tF0CxXrLLxA1/14DoHh+tLWGEsesSVd0d9bWED37gbX14BvbsUgaQasq5UYLRNSvD9E3MrbNrxXRghYDn5B9jVA1r/FSu1rE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774173883; c=relaxed/simple; bh=JXFpcOId5hljyBMRvIswXJUP7F5f7sVrUNNkeou1UIY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MfT+DjC5XhAmlvC6Cpo9/bewrBesrydb6mVni+qwgwO1BpuOqP+wgkvEvaFUg0KGXMQgt6gsHZ6SL/2DZhg/L4+EiRyWpXYnO9qPEeVN4fFZU2a3IhRaQbCpqzcCIeovidWLx0jL1EAtyMS5gN8r8cxh3Ot6qGT/xuj2Wegc6HM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rQ5N29A5; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rQ5N29A5" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-485317b6bd0so67975e9.1 for ; Sun, 22 Mar 2026 03:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774173880; x=1774778680; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=08waK1gpp0C9CvdH4Hrzkz/c2JUiId3dhgzoaIlZ0mg=; b=rQ5N29A5hj8Qo3QMT8+LzvJ/Y/Iw9GaW8tbJBZfj9pAqlEOt7kooEkxl0Skfc1P7rY 25g0gJwtqH7wh8pspxTvt2OfLhtX3c8Aky4S1LxNo/YY02EUkhANMGf6p/sPfCzviDr/ lU5BvIlj8FPRWQe51MQsOvVcGRukZjeYpl2UkVXkT37dVQ5SjnyBUEORL+ZbwCPxecgs JnJD3ekeHXyiVRUr4/UTsBqdcb04hX5f1C2+zLYjL9+x9/VgD2lxiC+fifhZUq1E2Alt u4ov7pgKWcReQRdBR0vfTPoPZmaL1+VVmTEypEC6W38WnEV30jQ+nOpc6R+YWLV03AUv lFWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774173880; x=1774778680; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=08waK1gpp0C9CvdH4Hrzkz/c2JUiId3dhgzoaIlZ0mg=; b=YM6Z4HPUs2lvSm0roqXaW3KBCMrnu0LEYt+mukeD7j+6CU9sXwubsnvnTWhQHQ+fEy KyzMydpkzRaq7pwm5ou1krSOQd+NtoYizH3dHiTUrJnJUdwRCA6jVTkKExerxrCxZv8f cLtqIxKOLWPtCr7VAFekXGvfl1TwqNt6WsSzIhxJQHb/xR8libPTCyp89dcrApOU3moE U9OsvZCWHTkCdbWUJ4GKVLNbXwIr8pZVLp0bPbhIPeK0y4rxdOJ3hIdfytZwOd0w7kc9 dC2Vrm43EfEtBffnqj0NrZIiKvuNe1w34Qc7k4JIcXos/oYi6FhnxNt9oKX0L6mOMRSn UWyw== X-Gm-Message-State: AOJu0YyVk16GDTZhUHfFs2Jm6ryMcyqWTV/maYMeo4cRmRfa1z49Hd1t oF+H7xFeMSjjoGN4QvnFfpzXwz0CeUv0TQu45ttsgl57/R3IC5mnX8rcGyxvA87FDw== X-Gm-Gg: ATEYQzwH5wLilBXpUR0cKQzHh0jeD2ST1cicEqQaz5DX2rcqyFA0o4H6vALxDlctBG7 ED0Zy0NNHSxoKiW39c+CwqB2G7y5vhpG1xmXSZjvuS4E0EnqfcdoGxGXVUSoBZVZFcl8IsZPh2F Osnf4oqq1S2ir4f/pHiBem2ZqSGyv/PHUG+h4w1r7IE2rGdf9SrM1VnNEgFUuDxpyt2OUikFgQk VVK+/lK1avs4feNirhkVa+8rmDs28mPUzG1o6eLQkyfWRswKNZAYOF0Y0fohi/OJ++r4rGlqmQU Eyv9YQtlRsa6O1riXW4Yg5w43TQPK47wdAtnaoCi1cOE0v9uZRhA/Oc9Thm3YcOQEDIO/OVbReW DAJUvrfC3VbasBmDX2tP4FvEpKBVOV0mxlDGSSBjhQOsU3DgT/Uj9ltz6jKYJIgrzvLQCKOaY92 NXNmtqS3Bye7GljEpCwHMxYA3p+EQmadtXShjMcbN7zylCzgAGyIDGWjtbx49IeWNcxL8= X-Received: by 2002:a05:600c:c1c8:20b0:475:d905:9f12 with SMTP id 5b1f17b1804b1-487034332b2mr810295e9.4.1774173879710; Sun, 22 Mar 2026 03:04:39 -0700 (PDT) Received: from google.com (54.95.38.34.bc.googleusercontent.com. [34.38.95.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae37dsm20239291f8f.2.2026.03.22.03.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 03:04:39 -0700 (PDT) Date: Sun, 22 Mar 2026 10:04:35 +0000 From: Mostafa Saleh To: Jacob Pan Cc: linux-kernel@vger.kernel.org, "iommu@lists.linux.dev" , Jason Gunthorpe , Alex Williamson , Joerg Roedel , David Matlack , Robin Murphy , Nicolin Chen , "Tian, Kevin" , Yi Liu , skhawaja@google.com, pasha.tatashin@soleen.com, Will Deacon , Baolu Lu Subject: Re: [PATCH V2 07/11] vfio: Update noiommu device detection logic for cdev Message-ID: References: <20260312155637.376854-1-jacob.pan@linux.microsoft.com> <20260312155637.376854-8-jacob.pan@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312155637.376854-8-jacob.pan@linux.microsoft.com> On Thu, Mar 12, 2026 at 08:56:33AM -0700, Jacob Pan wrote: > Rework vfio_device_is_noiommu() to derive noiommu mode based on device, > group type, and configurations. > > Signed-off-by: Jacob Pan > --- > drivers/vfio/vfio.h | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/vfio/vfio.h b/drivers/vfio/vfio.h > index 838c08077ce2..c5541967ef9b 100644 > --- a/drivers/vfio/vfio.h > +++ b/drivers/vfio/vfio.h > @@ -127,8 +127,13 @@ static inline bool vfio_null_group_allowed(void) > > static inline bool vfio_device_is_noiommu(struct vfio_device *vdev) > { > - return IS_ENABLED(CONFIG_VFIO_NOIOMMU) && > - vdev->group->type == VFIO_NO_IOMMU; > + if (!IS_ENABLED(CONFIG_VFIO_NOIOMMU)) > + return false; > + > + if (vfio_null_group_allowed()) > + return vdev->noiommu; > + > + return vdev->group->type == VFIO_NO_IOMMU; I see that noiommu is set for both, can this just be simplified to: return IS_ENABLED(CONFIG_VFIO_NOIOMMU) && vdev->noiommu; Thanks, Mostafa > } > #else > struct vfio_group; > -- > 2.34.1 >