From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755022AbcIJU0B (ORCPT ); Sat, 10 Sep 2016 16:26:01 -0400 Received: from mout.web.de ([212.227.17.12]:52336 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbcIJUZ7 (ORCPT ); Sat, 10 Sep 2016 16:25:59 -0400 Subject: [PATCH 04/13] DRBD-receiver: Improve a size determination in drbd_do_features() To: drbd-dev@lists.linbit.com, Lars Ellenberg , Philipp Reisner References: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Sat, 10 Sep 2016 22:25:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:GS+gYZOtNs8TD6pt+DuWhjYq+ucXQtETg71LRwcEImXOPnseCYg gUuVj7xuwJJw/Orqdp0In+8k64YxLJchFzDFgeGk2uVzahuwfApvNUxkKXuiDzmEHIF/TFP tOZ953zg5f9sw28DKm6HlfUL715z/9wd3yhM+ERLblFCHAhi7lyt3AySHmYMeP/OQH5GsLP xuF2KReO/u6AkGAeC1UNw== X-UI-Out-Filterresults: notjunk:1;V01:K0:wcRkcRN249I=:oGgLxUgUrpMAvq4IkDqM/J mdSSJCb0+FGBhrxHlCBaeyuMfpS19LUQ+NeUg1WeTB3EIzqogiu3wSD3hXBV5B2CzwhGzOSVX P6hqaidjWPnoDUVTkHouU8Ymn5bb2fWgykxViAGoA0JO60TAD68SdpXHB9brQfGigR3xKoOjt k6es87qzPwg7IW7SYEVYGUCqptMVpmnf4/owkDvbnYwps8RdgOiGRDU2GF5r+fzn8fDt4TMgh 6JVAh3giGOD8EnjmBk9lvPLLKFoosozu/zmR6Nog3kxO46SDxTQVl/WLNyirZ7Yz0LzGs9YiL zW7QP31M4mxDRryivmkiqLZjOIye9R+bPNVaxKXRguXqxVr1MUjqZLpJpE+1zWmXZEPPu06du 4yRfkopDaADYcnze4HDrbeCUouFtHT/3WR3vRlFhMzIxPZ8RqxCRh8Z/s2XnW27WmhTGOMWAh vbH6LxKcebtV89UjXUZZdwHLuumrhdMsuJ8zSmkdKBhjJzEvStDhQp+42MQwl64nF4WiDn6c4 Y6xaD0sJoqAzWvd8kE3PGSJqAYSHakKNHpMF4uLQXsiNlqtsqVy2vQtRKEylFwP5Ewz7jm+QD sl1VyCt1wSCFpky7wf4/iHMbJH5esTR5uVgcsPQeg47to67U77lSGd+8edxFfJKeuCiL01vRb KJi/2qEWMXdYG1rtfoCHEdS/61a5IWpjdiM1m628SvIu6qKjgorYXAoYJqJ6/JJePuyHl/yZ2 XtgHX4YN6nxMNV+UGsHwhg8WM69CkxQDOwnNR+3NrQBR3LuouyTE4j+lUT8bBXAxdVuGTBNsj UxvjYqG Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 19:46:05 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/block/drbd/drbd_receiver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 5526f6b..b5a3cf0 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -5208,7 +5208,7 @@ static int drbd_do_features(struct drbd_connection *connection) { /* ASSERT current == connection->receiver ... */ struct p_connection_features *p; - const int expect = sizeof(struct p_connection_features); + const int expect = sizeof(*p); struct packet_info pi; int err; -- 2.10.0