From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AD8135BDA5 for ; Fri, 20 Mar 2026 13:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774013168; cv=none; b=qG7Wt7UCxd4DnnY5TR57zn5Zjk6kIubGKcTWvqow5iCksBCYaMHAVmXCQ6TeDCANs7JyfvlqDUWbQGn0IH6nDF2eMkemdZzlY8dUwpKs1HyBBzYir5PS8QSZUmhpb35G6IDmlbX4ejaGGzHzg7Yqh9t3r8CniRE1620M2XpobQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774013168; c=relaxed/simple; bh=WPvpeQDdzO+GgprJ21xMbMraGpIYDJe/5WMU9LWDYn4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GdC+KCD+7dTTDPtHtk37t4JlfPMxNacknocGCIEZv1kEi6WaP5QyVQ8uHigHHdQSd+lT+trQRRvZI0vvWcYYex1YGOmEAnl4N+pnO/XOfmg2tN0hSFyXl+4nH8ieUHIN7lSCJGMRVB+1t7f7yzwnvultlgLnNfRluCMD4Kd56Vw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=FPFpdd/+; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="FPFpdd/+" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-439cd6b0aedso1318439f8f.1 for ; Fri, 20 Mar 2026 06:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774013165; x=1774617965; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YleuovkqL/mLOY7qyM/w1oS9wpwrcConR5IRWNylFhM=; b=FPFpdd/+24PtKRKI+GEuYmgHqugZXgdZj8in0BMxRq9Dg5V3MIeDhNvZcETrEYCjuu RVlcV7xZ5ICC743alKJGXL/dCwAGV8iuLF21E6tlBwJO4MH3rP5fFhXikvdQj2ubenzd Nc9230xIFC+ihGXMpNvdassrr6ESj13BadreNV0JGAGx1Te6BDlrFnwRVdW1mp+x0ZEE zyZ0x79WTOijhlDFENOJtt/Ui7xCvrezI1p9i1LOFvCEb+jupqKvREcNIeCGKW57fCj7 cXigUyqi/aDl5tw3pcY4A/pWj+Yub6C9B/K2Dhd6tNG34BCOWzfHXSCVHWoxi+tLpb7c eZFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774013165; x=1774617965; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YleuovkqL/mLOY7qyM/w1oS9wpwrcConR5IRWNylFhM=; b=BS5lCLLpe/Y9Sk9KAkogKiHEoJwbdwhYx5+Xh+4M5eEOIsRla2FbwodItUy4EFpCYw jFFsl+WVWwfeJjnBrIeUA8b8sY5xIv12qeeN8/huj57Wvk2XTmrtDBQM/UXTolPluxHB bEYGf4+J/EbB7EVlG95SGD6N8/UNFJKDKzs8k/s1zdZoA1jZmEwFEJ2B6xTQxBzB4K+Y b9oxRfiK2VC7Glflj/loHV5FwNZuDzWWUVF2aUMSnRHkT6VEM+U7F9bOsYZzk1kT3tQ3 lBBCmKrVk9TkM43DSNx0VHnPQE6fPA0pRMGQ9iTswI/GIAtjN1i2X3VfLtzLWSGODAi7 S+VQ== X-Forwarded-Encrypted: i=1; AJvYcCUDnCOmiLhTxr+zbl6+C+Wn6XQgWXqt0vKsRFg9lec6ZTJE5HlKyISZUYBMFk+UQJWmjaAFGVWV01ONENg=@vger.kernel.org X-Gm-Message-State: AOJu0YyhjxS5Re6BT8XEAYOmunyzoSoDLq9C8NmtZWLGfZBSomOv7Pog PUpTFhZNfcs+mtGX28kz2Pk+gYt3pP+XvCpAJ/M6LukacZMvipg8hRxbW4vNdcwo6oQ= X-Gm-Gg: ATEYQzwPYPllmCH2Rqj6EvpZ58RFnbtwYtf0pKoHj6An7UyKNPdvWRzUC37ZiPXEeHc 9+zTLuU5j4j74X5MKXtDRrOk3SQszTqISgFBXM2GPCOERTaFKo+SDmbpCIr2tG1s+seiY3zu/4T KthANbnPgvSePGXJkuUsUDKkgge2YlkbeXcwBmyrMJzYpRh3RqVQObThwcXAK9sfJ8A6+xVT68c 3x/U1BG7fTw/nWayvSdVuXDUa5WXhMYCZvG2hCU/8VWxCQzRXOvsGJlsIt2fm+Y7xASb1SU7ewZ eiopG7Y7GfUF8f8b4lmAhvgn16EomUUqg2oPRzC0HAh+FgcfwKw2G+Nb1krUkSjw4x59LnrzBSt ZAQDa3oUzVwiuamPzmx9e7jpiF9LfU/A+ZiDIPUl1MVMbemUG8uHoCGRM5rVlq/gUQUklBRKRFS u0SfUGJcgZE49tbn0TO4Ifsg1+mg== X-Received: by 2002:a05:6000:2f84:b0:43b:464a:28de with SMTP id ffacd0b85a97d-43b64243b0dmr4968964f8f.14.1774013164909; Fri, 20 Mar 2026 06:26:04 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6471a297sm6548523f8f.37.2026.03.20.06.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 06:26:04 -0700 (PDT) Date: Fri, 20 Mar 2026 14:26:02 +0100 From: Petr Mladek To: Marcos Paulo de Souza Cc: Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Joe Lawrence , Shuah Khan , live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] selftests: livepatch: functions.sh: Extend check for taint flag kernel message Message-ID: References: <20260313-lp-tests-old-fixes-v1-0-71ac6dfb3253@suse.com> <20260313-lp-tests-old-fixes-v1-8-71ac6dfb3253@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260313-lp-tests-old-fixes-v1-8-71ac6dfb3253@suse.com> On Fri 2026-03-13 17:58:39, Marcos Paulo de Souza wrote: > On SLE kernels there is a warning when a livepatch is disabled: > livepatch: attempt to disable live patch test_klp_livepatch, setting > NO_SUPPORT taint flag > > Extend lightly the detection of messages when a livepatch is disabled > to cover this case as well. > > Signed-off-by: Marcos Paulo de Souza > --- > tools/testing/selftests/livepatch/functions.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/livepatch/functions.sh b/tools/testing/selftests/livepatch/functions.sh > index 781346d6e94e0..73a1d4e6acaeb 100644 > --- a/tools/testing/selftests/livepatch/functions.sh > +++ b/tools/testing/selftests/livepatch/functions.sh > @@ -324,7 +324,7 @@ function check_result { > # - filter out dmesg timestamp prefixes > result=$(dmesg | awk -v last_dmesg="$LAST_DMESG" 'p; $0 == last_dmesg { p=1 }' | \ > grep -e 'livepatch:' -e 'test_klp' | \ > - grep -v '\(tainting\|taints\) kernel' | \ > + grep -v '\(tainting\|taints\|taint\) \(kernel\|flag\)' | \ > sed 's/^\[[ 0-9.]*\] //' | \ > sed 's/^\[[ ]*[CT][0-9]*\] //') With the upstream maintainer hat on: I am afraid that we could not take this. It is needed only because of another out-of-tree patch. It does not describe the upstream behavior. It might even hide problems. We should maintain a SUSE-specific patch against the selftests as a counter-part for the patch adding the tainting. Or we could try to upstream the patch which adds the tainting. Well, we might want to limit the tainting only to livepatches with callbacks or shadow variables. IMHO, only these features are source of potential problems. Best Rerards, Petr