From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nelson Johnson <nzjfr547@gmail.com>
Cc: linux-mmc@vger.kernel.org, adrian.hunter@intel.com,
ulf.hansson@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mmc: sdhci-acpi: exclude INT33BB:00 from ACPI binding on Lenovo N22
Date: Fri, 20 Mar 2026 19:02:28 +0100 [thread overview]
Message-ID: <ab2LtPclnoAXeYHQ@black.igk.intel.com> (raw)
In-Reply-To: <20260316212325.4207-4-nzjfr547@gmail.com>
On Mon, Mar 16, 2026 at 04:23:25PM -0500, Nelson Johnson wrote:
> On the Lenovo N22, the firmware exposes the Braswell SD controller through both PCI 0000:00:12.0 and ACPI INT33BB:00. The ACPI path for INT33BB:00 never finishes probing on this machine and repeatedly defers, which leaves the slot in the broken ACPI path instead of letting the working PCI path own the controller.
>
> Return -ENODEV early for INT33BB:00 on the Lenovo N22 so that sdhci-acpi does not bind this machine-specific firmware node. That leaves the controller to the PCI SDHCI driver, which is the path that works once the N22-specific runtime PM and card-detect quirks are applied.
>
> Scope the exclusion to the Lenovo N22 DMI match so other INT33BB systems continue to use the normal ACPI handling.
This should be done somewhere in drivers/acpi/x86/lpss.c I believe. That's the
driver that responsible for ACPI enumeration of LPSS devices on Braswell
machines.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-20 18:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 21:23 [PATCH 0/3] mmc: Lenovo N22 Braswell SD slot fixes Nelson Johnson
2026-03-16 21:23 ` [PATCH 1/3] mmc: sdhci-pci: disable aggressive runtime PM for Braswell SD on Lenovo N22 Nelson Johnson
2026-03-20 17:58 ` Andy Shevchenko
2026-03-16 21:23 ` [PATCH 2/3] mmc: sdhci-pci: force polling card detect " Nelson Johnson
2026-03-16 21:23 ` [PATCH 3/3] mmc: sdhci-acpi: exclude INT33BB:00 from ACPI binding " Nelson Johnson
2026-03-20 18:02 ` Andy Shevchenko [this message]
2026-03-20 13:27 ` [PATCH 0/3] mmc: Lenovo N22 Braswell SD slot fixes Adrian Hunter
2026-03-20 16:47 ` Nelson Johnson
2026-03-20 17:55 ` Andy Shevchenko
2026-03-20 18:08 ` Andy Shevchenko
2026-03-20 23:07 ` Nelson Johnson
2026-03-21 11:07 ` Hans de Goede
2026-03-24 15:05 ` Adrian Hunter
2026-03-20 17:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2LtPclnoAXeYHQ@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nzjfr547@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox