From: Jiri Slaby <jirislaby@kernel.org>
To: Christoph Hellwig <hch@lst.de>, stefani@seibold.net
Cc: jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kfifo: don't include dma-mapping.h in kfifo.h
Date: Tue, 15 Oct 2024 09:47:31 +0200 [thread overview]
Message-ID: <ab456339-18fd-45d8-abde-b04196e0f604@kernel.org> (raw)
In-Reply-To: <20241014144643.51917-1-hch@lst.de>
On 14. 10. 24, 16:46, Christoph Hellwig wrote:
> Nothing in kfifo.h needs dma-mapping.h. Drop the include to
> reduce include bloat.
>
> Fixes: d52b761e4b1a ("kfifo: add kfifo_dma_out_prepare_mapped()")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/mailbox/omap-mailbox.c | 1 +
> include/linux/kfifo.h | 1 -
> samples/kfifo/dma-example.c | 1 +
> 3 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
> index 6797770474a55d..680243751d625f 100644
> --- a/drivers/mailbox/omap-mailbox.c
> +++ b/drivers/mailbox/omap-mailbox.c
> @@ -15,6 +15,7 @@
> #include <linux/slab.h>
> #include <linux/kfifo.h>
> #include <linux/err.h>
> +#include <linux/io.h>
Oh, I've just noticed this. Why io.h?
--
js
suse labs
next prev parent reply other threads:[~2024-10-15 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 14:46 [PATCH] kfifo: don't include dma-mapping.h in kfifo.h Christoph Hellwig
2024-10-15 7:38 ` Jiri Slaby
2024-10-15 7:40 ` Christoph Hellwig
2024-10-15 7:53 ` Jiri Slaby
2024-10-15 7:56 ` Christoph Hellwig
2024-10-15 8:19 ` Jiri Slaby
2024-10-15 7:47 ` Jiri Slaby [this message]
2024-10-15 7:50 ` Christoph Hellwig
2024-10-15 7:55 ` Jiri Slaby
2024-10-15 7:57 ` Christoph Hellwig
2024-10-15 8:03 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab456339-18fd-45d8-abde-b04196e0f604@kernel.org \
--to=jirislaby@kernel.org \
--cc=hch@lst.de \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox