From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Bjorn Andersson <andersson@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: memory-controllers: samsung,exynos4210-srom: Enforce child props
Date: Thu, 6 Mar 2025 14:51:05 +0100 [thread overview]
Message-ID: <ab483a68-40a8-4b44-ad73-d8a34bd32c69@kernel.org> (raw)
In-Reply-To: <CAL_JsqKODHZcrpqskA2aeK6EqGNx9aGNuPqGzhcZ_Nqiu+Ccww@mail.gmail.com>
On 06/03/2025 14:39, Rob Herring wrote:
> Why do we need this? Any child node should have a schema which needs
> to include mc-peripheral-props.yaml if any properties from it can be
> used.
From correctness point of view, you are right, we don't need it. However:
1. Convention was so far to have in every controller. I think this also
is easier to understand whenever one reads the bindings - clear
documentation what children on this bus should look like.
2. To clearly document from where samsung,srom-timing comes in the
required block:
https://web.git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml?h=dt/next#n50
Otherwise for me it is a bit confusing to require a property which is
nowhere here defined.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-06 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 8:58 [PATCH 1/2] dt-bindings: memory-controllers: samsung,exynos4210-srom: Enforce child props Krzysztof Kozlowski
2025-03-06 8:58 ` [PATCH 2/2] dt-bindings: memory-controllers: qcom,ebi2: " Krzysztof Kozlowski
2025-03-06 13:39 ` [PATCH 1/2] dt-bindings: memory-controllers: samsung,exynos4210-srom: " Rob Herring
2025-03-06 13:51 ` Krzysztof Kozlowski [this message]
2025-03-06 20:52 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab483a68-40a8-4b44-ad73-d8a34bd32c69@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox