From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B0BC433E1 for ; Thu, 13 Aug 2020 03:11:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E84A42076C for ; Thu, 13 Aug 2020 03:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbgHMDLu (ORCPT ); Wed, 12 Aug 2020 23:11:50 -0400 Received: from mga03.intel.com ([134.134.136.65]:11512 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbgHMDLu (ORCPT ); Wed, 12 Aug 2020 23:11:50 -0400 IronPort-SDR: kSWN4xgfnJ4SeWicfjc+7ler2gzzMBJE1mAEzq1uQ5fqV9IBU/AiGjTBGbSLScIf9RomVH/gyj 0zH2aPU/TJnw== X-IronPort-AV: E=McAfee;i="6000,8403,9711"; a="154117552" X-IronPort-AV: E=Sophos;i="5.76,306,1592895600"; d="scan'208";a="154117552" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2020 20:11:49 -0700 IronPort-SDR: Cc7HVTVAn7hMx++DeaCvM9u+iUjbiwFJyzTXJueUAd1gl526zu8Zj6dOjNNxdrrqOBnYDwZZZg luobUriuw9KA== X-IronPort-AV: E=Sophos;i="5.76,306,1592895600"; d="scan'208";a="495720985" Received: from yjin15-mobl1.ccr.corp.intel.com (HELO [10.238.5.239]) ([10.238.5.239]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2020 20:11:46 -0700 Subject: Re: [PATCH] perf parse-events: Set exclude_guest for user-space counting To: Like Xu , Arnaldo Carvalho de Melo Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <20200812065953.22143-1-yao.jin@linux.intel.com> <20200812121504.GE13995@kernel.org> <74097816-3f36-abea-1eaa-8942aedd7322@linux.intel.com> From: "Jin, Yao" Message-ID: Date: Thu, 13 Aug 2020 11:11:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <74097816-3f36-abea-1eaa-8942aedd7322@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Like, On 8/12/2020 9:02 PM, Like Xu wrote: > On 2020/8/12 20:15, Arnaldo Carvalho de Melo wrote: >> Em Wed, Aug 12, 2020 at 02:59:53PM +0800, Jin Yao escreveu: >>> Currently if we run 'perf record -e cycles:u', exclude_guest is 0. >>> >>> But it doesn't make sense that we request for user-space counting >>> but we also get the guest report. >>> > > Please hold the horse and allow this possibility. > > Some authorized perf users on the host may > only want to count (KVM) guest user space events. > > Thanks, > Like Xu > Without this patch, if we don't set the ":u" modifier, exclude_guest = 1. perf record -e cycles ./div perf evlist -v cycles: size: 120, { sample_period, sample_freq }: 4000, sample_type: IP|TID|TIME|PERIOD, read_format: ID, disabled: 1, inherit: 1, mmap: 1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1, ksymbol: 1, bpf_event: 1 So this patch doesn't change perf's original behavior. Thanks Jin Yao >>> To keep perf semantics consistent and clear, this patch sets >>> exclude_guest for user-space counting. >> >> Applied, and also added this, that you should consider doing in the >> future (modulo the "Committer testing:" header :) ): >> >> Committer testing: >> >> Before: >> >>    # perf record -e cycles:u >>    ^C[ perf record: Woken up 1 times to write data ] >>    [ perf record: Captured and wrote 1.231 MB perf.data (91 samples) ] >>    # >>    # perf evlist -v >>    cycles:u: size: 120, { sample_period, sample_freq }: 4000, sample_type: >> IP|TID|TIME|ID|CPU|PERIOD, read_format: ID, disabled: 1, inherit: 1, exclude_kernel: 1, >> exclude_hv: 1, freq: 1, sample_id_all: 1 >>    >>    # >> >> After: >> >>    # perf record -e cycles:u >>    ^C[ perf record: Woken up 1 times to write data ] >>    [ perf record: Captured and wrote 1.263 MB perf.data (403 samples) ] >>    # >>    # perf evlist -v >>    cycles:u: size: 120, { sample_period, sample_freq }: 4000, sample_type: >> IP|TID|TIME|ID|CPU|PERIOD, read_format: ID, disabled: 1, inherit: 1, exclude_kernel: 1, >> exclude_hv: 1, freq: 1, sample_id_all: 1, exclude_guest: 1 >>    # >> >> ---- >> >> I.e. show actual command output before and after that demonstrates the >> problem and then the solution. >> >>> Signed-off-by: Jin Yao >>> --- >>>   tools/perf/util/parse-events.c | 2 ++ >>>   1 file changed, 2 insertions(+) >>> >>> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c >>> index 9f7260e69113..4d809f1fe269 100644 >>> --- a/tools/perf/util/parse-events.c >>> +++ b/tools/perf/util/parse-events.c >>> @@ -1794,6 +1794,8 @@ static int get_event_modifier(struct event_modifier *mod, char *str, >>>           if (*str == 'u') { >>>               if (!exclude) >>>                   exclude = eu = ek = eh = 1; >>> +            if (!exclude_GH) >>> +                eG = 1; >>>               eu = 0; >>>           } else if (*str == 'k') { >>>               if (!exclude) >>> -- >>> 2.17.1 >>> >> >