From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Felix Fietkau <nbd@nbd.name>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] dt-bindings: clock: airoha: Document support for AN7583 clock
Date: Fri, 7 Nov 2025 09:12:48 +0100 [thread overview]
Message-ID: <ab520621-b11d-4763-a7b7-fe7dfafdca6c@kernel.org> (raw)
In-Reply-To: <690da391.5d0a0220.33eed5.80b7@mx.google.com>
On 07/11/2025 08:45, Christian Marangi wrote:
> On Fri, Nov 07, 2025 at 08:42:15AM +0100, Krzysztof Kozlowski wrote:
>> On Thu, Nov 06, 2025 at 08:59:31PM +0100, Christian Marangi wrote:
>>> Document support for Airoha AN7583 clock based on the EN7523
>>> clock schema.
>>>
>>> Add additional binding for additional clock and reset lines.
>>>
>>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>>> ---
>>> .../bindings/clock/airoha,en7523-scu.yaml | 5 +-
>>> include/dt-bindings/clock/en7523-clk.h | 3 +
>>> .../dt-bindings/reset/airoha,an7583-reset.h | 62 +++++++++++++++++++
>>> 3 files changed, 69 insertions(+), 1 deletion(-)
>>> create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h
>>>
>>> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
>>> index fe2c5c1baf43..2d53b96356c5 100644
>>> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
>>> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
>>> @@ -30,6 +30,7 @@ properties:
>>> compatible:
>>> items:
>>> - enum:
>>> + - airoha,an7583-scu
>>
>> That's random order. Keep it sorted.
>>
>> Best regards,
>> Krzysztof
>>
>
> Hi Krzysztof,
>
> I was also not cetrain on the correct order.
Why? The rule was expressed on mailing list many, many times and only
Sunxi or maybe one more SoC does it differently.
>
> We have En7523 and en7581 and then An7583.
>
> So should I put it at last following the number order or the
> alphabetical order?
All such lists or enumerations are ordered alphanumerically.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-07 8:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 19:59 [PATCH v3 0/5] clk: add support for Airoha AN7583 clock Christian Marangi
2025-11-06 19:59 ` [PATCH v3 1/5] clk: en7523: convert driver to regmap API Christian Marangi
2025-11-06 19:59 ` [PATCH v3 2/5] clk: en7523: generalize register clocks function Christian Marangi
2025-11-06 20:25 ` Christophe JAILLET
2025-11-06 20:27 ` Christian Marangi
2025-11-07 17:27 ` Christophe JAILLET
2025-11-06 19:59 ` [PATCH v3 3/5] clk: en7523: reword and clean clk_probe variables Christian Marangi
2025-11-06 19:59 ` [PATCH v3 4/5] dt-bindings: clock: airoha: Document support for AN7583 clock Christian Marangi
2025-11-07 7:42 ` Krzysztof Kozlowski
2025-11-07 7:45 ` Christian Marangi
2025-11-07 8:12 ` Krzysztof Kozlowski [this message]
2025-11-07 8:20 ` Christian Marangi
2025-11-07 8:52 ` Krzysztof Kozlowski
2025-11-07 10:57 ` Krzysztof Kozlowski
2025-11-06 19:59 ` [PATCH v3 5/5] clk: en7523: add support for Airoha " Christian Marangi
2025-11-07 7:44 ` Krzysztof Kozlowski
2025-11-07 8:01 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab520621-b11d-4763-a7b7-fe7dfafdca6c@kernel.org \
--to=krzk@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nbd@nbd.name \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox