From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C2CB23ED6A for ; Sat, 21 Mar 2026 07:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774079255; cv=none; b=KJUecYSfaIOOieadwr7ajmS6fikYulDuiw/Wb6XsxZSq6es04vHi9GRpfHJ5ujOXFoq0dRnBFK1WTz+ykLItzQNk1x1GG4pf64QyQRWof07uw5CyadkDPaWMoYrDTSyGQQWif2iIs2OFa9+/HWq9eFDsGnc/qxiTm31EhRfSp9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774079255; c=relaxed/simple; bh=D1bR+ZMSEYc8TaALw65NJI8y3xbn0+30h6I793bzoKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AWLPoz6KOAY1ojAg0O36oLLKlog8s/bUYbQEjx3obCGcIF6PHyMe96PK8no7h9xjGi+qYKqLz235977KVD4nCmBFIVp/OJnY6EbiEAicq5OMmweBa7C9Kifts2Z3Xol/70tGo1dowe4ChpBW6ct3ytM2qQEZLV85yBwho4RrTN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Av71iU+c; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Av71iU+c" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43b3d9d0695so2404904f8f.0 for ; Sat, 21 Mar 2026 00:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774079252; x=1774684052; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0MiQ792kHHHn00blfaUy7hM76QTaBAWEx5tkF9QD2vE=; b=Av71iU+cuVN5F1CGCYsbNHtRn9SdMnCil+PGX9/sr5Nw+bKuqj/jlSKZjutIWwAsKU ioGJ/0RILO/qqgFmzTgS7u+3ig2fulzu2x2RLxQbTHnxCSaHziFLqn97ihw0F8RW2kQ7 R8VDQ8Bf9WKtS/msS58aZlC4esy3dA4bgZ6y3oylVCPRs6CzrJSf9L+rjM6KrvgzPk20 V4PNZHgJ/CIq8UPFVE/Zg9mxqcisv8gyRFsU/Jt8OLEKR4Pybfvwh8Xa9eKE2TnaGglF an8ryWeAPHaHYXPOfTzfF+D+a9ZBCE6Tjcvdp6gJGdJtojpIiIc12ixiQ+vVv9RtFHQh +szA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774079252; x=1774684052; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0MiQ792kHHHn00blfaUy7hM76QTaBAWEx5tkF9QD2vE=; b=CzQb1KfELnk2eNiGqrTNvw2Eemn+KBXwN8nA3WF3CA0tM65ayktbOU0aiyW1ds6qeG 5IWQ6M+pAbdhTefHfa3xZoNKUrlYvWf05VvcsWXnoq+jzGZVhSVpe0zYaIfoCY8JKRs6 5Bod/qRGxup2PniG5oOUGPhi6VSffIQMIgZkYNU6HBIeSEFzXqoShSNK+r9yTnPaYI5p 7W4M80UcDHLDtekZoNbV8n+2cHPsIj9u0+iVgFTLbExAAOv0Sb7FIIvqNozR+ofM/C2D I+Qa0Rd/n5JAYIY/hyKsiWysWu+59TfOzJF0IfsXwX15M+rJbTHKVjjmF+iHOSvOQ6gF 842Q== X-Forwarded-Encrypted: i=1; AJvYcCVvLk0SPqEyEqOziHUOqmkO2EquZsrBlgWwy8Equ6dGUBw6ERgGpqFsdeV2Bhz8hyFCJw7QpkQy4gQGDK4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu9ySQ91Gv1rq6NTnaRiRy5m84AoVzJspjKiCut5BhtWG8yVIT AMC4IcOXvc1rUCLUI4DHh7suBY/vDMeTHQZOz5G09piSWM+uTaHs03V6pfnwvRIjXDw= X-Gm-Gg: ATEYQzyIdLJmqM4UJdVz1vyzkQA5D75SWAOzTnuf0WoMb6gN9g7mz6CTJvImLBVL6M7 Oi/rQi1EB7PoM0h5Q+aSGHQFyK9bKsrmM1+GFrWuHyEPUElrw3a4bPJP4uJeRVVcpXPlAhV+X+C Kfgrdtfw3wD3GhvvAlukB+sLt9ap3tBMx03pHOtN7XFkOov+w8r5FtGKkPrXqdxUdjlreqLXSD3 NiMZi9W4ttR0FZgruRpBdwSFKaz2rkQeOXNeI9q4AFpGI1ri+LP2ysYG8Rn6wOjxbgxbkw3NkNX FA6aaz+GaQ2wV0u9f5OAdhBGuwy+SdVM6968+qstB2nyndD5HyggtBGcbry3zQPcMo30jar2qM2 Kac5S5AxBZhxIBBHod7oKbDrjFqVah7cuqQ6VoekWDl6hmlkD3Wk/i327RjDOPJR5iPY3oynJck CiC/APVUTvdRU9U4mV+v571JZ8U4jf X-Received: by 2002:a05:6000:1861:b0:43b:4703:9dd5 with SMTP id ffacd0b85a97d-43b64272ae1mr9913678f8f.18.1774079252483; Sat, 21 Mar 2026 00:47:32 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae619sm14023715f8f.5.2026.03.21.00.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 00:47:32 -0700 (PDT) Date: Sat, 21 Mar 2026 10:47:29 +0300 From: Dan Carpenter To: Lin YuChen Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: initialize le_tmp64 in rtw_BIP_verify() Message-ID: References: <20260320172502.167332-1-starpt.official@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260320172502.167332-1-starpt.official@gmail.com> On Sat, Mar 21, 2026 at 01:25:02AM +0800, Lin YuChen wrote: > Initialize le_tmp64 to zero in rtw_BIP_verify() to prevent using > uninitialized data. > > Smatch warns that only 6 bytes are copied to this 8-byte (u64) > variable, leaving the last two bytes uninitialized: > > drivers/staging/rtl8723bs/core/rtw_security.c:1308 rtw_BIP_verify() > warn: not copying enough bytes for '&le_tmp64' (8 vs 6 bytes) > > Initializing the variable at the start of the function fixes this > warning and ensures predictable behavior. > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/linux-staging/abvwIQh0CHTp4wNJ@stanley.mountain/ > Signed-off-by: Lin YuChen > --- > v2: Add Fixes: tag as suggested by Dan Carpenter. Fantastic. Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter