From: Dan Carpenter <dan.carpenter@linaro.org>
To: yaxing guo <guoyaxing@bosc.ac.cn>
Cc: oe-kbuild@lists.linux.dev, lkp@intel.com,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: drivers/uio/uio_pci_generic_sva.c:140 probe() warn: passing devm_ allocated variable to kfree. 'udev'
Date: Sat, 21 Mar 2026 13:22:38 +0300 [thread overview]
Message-ID: <ab5xbtDoMoq7HUnz@stanley.mountain> (raw)
In-Reply-To: <2da23703-7693-47f8-a561-743428b9bb22@bosc.ac.cn>
On Sat, Mar 21, 2026 at 05:51:15PM +0800, yaxing guo wrote:
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 135 pci_set_drvdata(pdev, udev);
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 136
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 137 return 0;
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 138
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 139 out_free:
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 @140 kfree(udev);
> >
> > So this is a double free.
> >
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 141 out_disable:
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 142 pci_disable_device(pdev);
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 143
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 144 return ret;
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 145 }
> >
>
> Hi Dan,
> The double-free issue has been addressed by Shuangshuo Li, who has already
> submitted a fix patch:
>
> https://lore.kernel.org/lkml/20260226153250.18079-1-lgs201920130244@gmail.com/
>
Okay. Good. I actually reported this bug to you last year in
November.
https://lore.kernel.org/all/202511280815.WV9iCJZb-lkp@intel.com/
regards,
dan carpenter
prev parent reply other threads:[~2026-03-21 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 8:24 drivers/uio/uio_pci_generic_sva.c:140 probe() warn: passing devm_ allocated variable to kfree. 'udev' Dan Carpenter
2026-03-21 9:51 ` yaxing guo
2026-03-21 10:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab5xbtDoMoq7HUnz@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=guoyaxing@bosc.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox