The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Zhang, Baoli" <baoli.zhang@linux.intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	Serge Hallyn <serge@hallyn.com>, Lili Li <lili.li@intel.com>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tpm: restore timeout for key creation commands
Date: Tue, 12 May 2026 12:04:02 +0800	[thread overview]
Message-ID: <ab62f209-72f3-4e36-aa5b-2ddb0314539a@linux.intel.com> (raw)
In-Reply-To: <af-F9iMpvQFpVBwH@kernel.org>


On 5/10/2026 3:07 AM, Jarkko Sakkinen wrote:
> On Thu, May 07, 2026 at 01:36:36PM +0800, Zhang, Baoli wrote:
>> On 5/4/2026 11:13 PM, Jarkko Sakkinen wrote:
>>> On Tue, Apr 21, 2026 at 08:50:20AM +0800, Baoli Zhang wrote:
>>>> From: "Baoli Zhang" <baoli.zhang@linux.intel.com>
>>>>
>>>> Commit 207696b17f38 ("tpm: use a map for tpm2_calc_ordinal_duration()")
>>>> inadvertently reduced the timeout for TPM2 key creation commands
>>>> (`CREATE_PRIMARY`, `CREATE`, `CREATE_LOADED`) from 300 seconds to 30
>>>> seconds.
>>>>
>>>> This causes intermittent timeout failures, with several failures observed
>>>> across hundreds of test runs on some Intel platforms using Infineon
>>>> SLB9670 and SLB9672 TPM modules. Restore the timeout to 300 seconds to
>>>> avoid spurious failures.
>>> Is this a production case?
>>>
>>> I'm not sure if there is anything to fix tbh. I mean it is
>>> pretty much the same as "maintaining compatibility to OTT driver"
>>> to addresses issues on undisclosed hardware.
>>>
>>> Please correct me if I'm wrong. Otherwise, I'd carry out internal patch
>>> to tweak this for pre-production hardware (presumably).
>> Hi Jarkko, this is indeed a production case. We discovered this issue during
>> validation testing for the sustaining release.
> OK, it can be considered as a backwards compatibility issue then I
> guess.
>
> I applied the patch, thank you.
>
> BR, Jarkko

Thanks Jarkko and you all for your kindly review and help.

BR/Baoli

>

      reply	other threads:[~2026-05-12  4:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260421005021.13765-1-baoli.zhang@linux.intel.com>
2026-05-04 15:13 ` [PATCH v2] tpm: restore timeout for key creation commands Jarkko Sakkinen
2026-05-07  5:36   ` Zhang, Baoli
2026-05-09 19:07     ` Jarkko Sakkinen
2026-05-12  4:04       ` Zhang, Baoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab62f209-72f3-4e36-aa5b-2ddb0314539a@linux.intel.com \
    --to=baoli.zhang@linux.intel.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=lili.li@intel.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox