From: Lizhi Hou <lizhi.hou@amd.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>, <ogabbay@kernel.org>,
<dri-devel@lists.freedesktop.org>
Cc: <linux-kernel@vger.kernel.org>, <min.ma@amd.com>,
<max.zhen@amd.com>, <sonal.santan@amd.com>, <king.tam@amd.com>,
<mario.limonciello@amd.com>
Subject: Re: [PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers
Date: Fri, 13 Dec 2024 09:02:34 -0800 [thread overview]
Message-ID: <ab646462-07f2-e09c-cd4d-6bc697d8cd43@amd.com> (raw)
In-Reply-To: <d4db5e3c-56b5-ed77-95af-15e9271339ce@quicinc.com>
On 12/13/24 08:58, Jeffrey Hugo wrote:
> On 12/6/2024 3:00 PM, Lizhi Hou wrote:
>> The latest released firmware supports reading firmware interface version
>> from registers directly. The driver's probe routine reads the major and
>> minor version numbers. If the firmware interface does not compatible
>> with
>> the driver, the driver's probe routine returns failure.
>>
>> Co-developed-by: Min Ma <min.ma@amd.com>
>> Signed-off-by: Min Ma <min.ma@amd.com>
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>> ---
>> drivers/accel/amdxdna/aie2_message.c | 26 ----------
>> drivers/accel/amdxdna/aie2_pci.c | 74 ++++++++++++++++++++++------
>> drivers/accel/amdxdna/aie2_pci.h | 6 +--
>> drivers/accel/amdxdna/npu1_regs.c | 2 +-
>> drivers/accel/amdxdna/npu2_regs.c | 2 +-
>> drivers/accel/amdxdna/npu4_regs.c | 2 +-
>> drivers/accel/amdxdna/npu5_regs.c | 2 +-
>
> Do you need an update to npu6_regs?
npu6_regs is added with upstream fw minor already. Thus, it does not
need an update.
Lizhi
>
> -Jeff
next prev parent reply other threads:[~2024-12-13 17:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 21:59 [PATCH V2 0/8] AMD NPU driver improvements Lizhi Hou
2024-12-06 21:59 ` [PATCH V2 1/8] accel/amdxdna: Add device status for aie2 devices Lizhi Hou
2024-12-11 0:31 ` Mario Limonciello
2024-12-13 16:31 ` Jeffrey Hugo
2024-12-06 21:59 ` [PATCH V2 2/8] accel/amdxdna: Replace mmput with mmput_async to avoid dead lock Lizhi Hou
2024-12-13 16:33 ` Jeffrey Hugo
2024-12-06 21:59 ` [PATCH V2 3/8] accel/amdxdna: Add RyzenAI-npu6 support Lizhi Hou
2024-12-11 0:30 ` Mario Limonciello
2024-12-13 16:37 ` Jeffrey Hugo
2024-12-13 16:47 ` Lizhi Hou
2024-12-06 21:59 ` [PATCH V2 4/8] accel/amdxdna: Replace idr api with xarray Lizhi Hou
2024-12-13 16:42 ` Jeffrey Hugo
2024-12-13 16:50 ` Lizhi Hou
2024-12-06 21:59 ` [PATCH V2 5/8] accel/amdxdna: Add query firmware version Lizhi Hou
2024-12-11 0:28 ` Mario Limonciello
2024-12-13 16:48 ` Jeffrey Hugo
2024-12-06 21:59 ` [PATCH V2 6/8] accel/amdxdna: Enhance power management settings Lizhi Hou
2024-12-11 0:28 ` Mario Limonciello
2024-12-11 5:28 ` Lizhi Hou
2024-12-11 20:55 ` Mario Limonciello
2024-12-13 16:55 ` Jeffrey Hugo
2024-12-13 17:31 ` Lizhi Hou
2024-12-06 22:00 ` [PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers Lizhi Hou
2024-12-11 0:20 ` Mario Limonciello
2024-12-11 5:32 ` Lizhi Hou
2024-12-13 16:58 ` Jeffrey Hugo
2024-12-13 17:02 ` Lizhi Hou [this message]
2024-12-13 17:11 ` Jeffrey Hugo
2024-12-06 22:00 ` [PATCH V2 8/8] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c Lizhi Hou
2024-12-10 20:54 ` Mario Limonciello
2024-12-13 16:20 ` Jeffrey Hugo
2024-12-13 16:42 ` Lizhi Hou
2024-12-13 17:00 ` [PATCH V2 0/8] AMD NPU driver improvements Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab646462-07f2-e09c-cd4d-6bc697d8cd43@amd.com \
--to=lizhi.hou@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=king.tam@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=max.zhen@amd.com \
--cc=min.ma@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=sonal.santan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox