From: xiaogang@codeaurora.org
To: John Stultz <john.stultz@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Andy Yan <andy.yan@rock-chips.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Chris Brand <chris.brand@broadcom.com>,
Richard Weinberger <richard@nod.at>,
Moritz Fischer <moritz.fischer@ettus.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS"
<linux-pm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] power: reset: Add qcom reboot mode driver
Date: Fri, 14 Oct 2016 11:40:50 +0800 [thread overview]
Message-ID: <ab76bb8e9a3eb417ea2fbfb0363bdc7e@codeaurora.org> (raw)
In-Reply-To: <CALAqxLXL+AHwchp8Ja2NAXt-=0xd87ojA4AGzT-n0oQFbwcCzw@mail.gmail.com>
在 2016-10-14 11:25，John Stultz 写道：
> On Thu, Oct 13, 2016 at 7:02 PM, Xiaogang Cui <xiaogang@codeaurora.org>
> wrote:
>> This is a initial version so it's very similar with syscon
>> reboot mode driver. We will add more functionalities in the
>> further after dependency is ready.
>>
>> Signed-off-by: Xiaogang Cui <xiaogang@codeaurora.org>
>> ---
>> .../bindings/power_supply/qcom-reboot-mode.txt | 23 +++++
>> drivers/power/reset/Kconfig | 10 ++
>> drivers/power/reset/Makefile | 1 +
>> drivers/power/reset/qcom-reboot-mode.c | 109
>> +++++++++++++++++++++
>> 4 files changed, 143 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/power_supply/qcom-reboot-mode.txt
>> create mode 100644 drivers/power/reset/qcom-reboot-mode.c
>>
>> diff --git
>> a/Documentation/devicetree/bindings/power_supply/qcom-reboot-mode.txt
>> b/Documentation/devicetree/bindings/power_supply/qcom-reboot-mode.txt
>> new file mode 100644
>> index 0000000..8b33592
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/power_supply/qcom-reboot-mode.txt
>> @@ -0,0 +1,23 @@
>> +Qualcomm Reboot Mode Driver
>> +
>> +Qualcomm reboot mode driver based on reboot mode framework to update
>> +SPMI specific bits.
>> +
>> +Required Properties:
>> +-compatible: "qcom,reboot-mode"
>> +-offset: offset of the SPMI reboot mode register
>> +
>> +Optional Properties:
>> +-mask: mask of reboot mode
>> +-mode-xxx: magic of reboot mode
>> +
>> +Example:
>> + qcom,reboot-mode@88f {
>> + compatible = "qcom,reboot-mode";
>> + offset = <0x88f>;
>> + mode-normal = <0x00>;
>> + mode-recovery = <0x04>;
>> + mode-bootloader = <0x08>;
>> + mode-rtc = <0x0C>;
>
> So I don't think we've had a "rtc" mode before. This needs to be very
> clearly documented (or maybe just skipped) so we don't start fraying
> with all the various vendor specific modes.
>
Thanks for the comments, I will skip this specific mode in next version
of this patch.
> thanks
> -john
next prev parent reply other threads:[~2016-10-14 3:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 2:02 [PATCH 1/2] power: reset: Add qcom reboot mode driver Xiaogang Cui
2016-10-14 2:41 ` Andy Yan
2016-10-14 3:06 ` xiaogang
2016-10-14 13:15 ` Sebastian Reichel
2016-10-14 3:25 ` John Stultz
2016-10-14 3:40 ` xiaogang [this message]
2016-10-18 14:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab76bb8e9a3eb417ea2fbfb0363bdc7e@codeaurora.org \
--to=xiaogang@codeaurora.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=andy.gross@linaro.org \
--cc=andy.yan@rock-chips.com \
--cc=chris.brand@broadcom.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=f.fainelli@gmail.com \
--cc=john.stultz@linaro.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=nicolas.ferre@atmel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox