From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E10A32D662F for ; Sat, 21 Mar 2026 21:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774128463; cv=none; b=GG+AVZyytA+DeMSGjfNVKGNa7aao4dHtHS5irajdyt263v5infMRP5GBSDZsgzU2FUXsnuoeL0IwWYrc8679/6lHnOy5hc1HbyVQERNHGbSZIASFsgZFTkVdDKsC8O3Hhqb3iy2+9HF/5bNVohGa85xYFagEJyz4ICIwCcXTqnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774128463; c=relaxed/simple; bh=c+uGPFfPI8Dv2tWOYcQBg299DNSQ5YhpV+5pMkeGXZs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jhdxLKxdQJZYdm+Z5mFN7h+Ct0ufhDtPdyWDKf0+iIdSglJuam0TwS9DpQv4svvP/EZekfzIjM/3ladZP9iim00ODpxJse7zFlzPCCrkAeIYp2GFMiz1VK2384iB9mlU8IvbBnKYUmryRyUCUaAWH+DULdiKepnYZjTycMUuO+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sxUWaa38; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sxUWaa38" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43b4d734678so3083131f8f.1 for ; Sat, 21 Mar 2026 14:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774128460; x=1774733260; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=72ApMUurYX2GgJLwF7KgodErv2db4HcxpZX43xt8Nqk=; b=sxUWaa38PdbTGP/qcugjKP/vscyqIrIXORTveBAgzERPC36NpyFqmJFdirgT3EQ2u3 PCTOPmwv3JgwXnfXWFWxQz+b1yDvbZCM63j1XBEAqLSqI4untkfQSqxAoLKgyjPS4eI9 xAkyC8ECcT3RT+Dewe29i8KXmdSudYvsCPhUz5EKahrFPCIpB5LyZW5uSjGxnIONgTIE eCS3kb24Rj5Nt1LVgVThyxWxH46A2Uu69UAnebCBghcBTPy0ERsNK+vjlQNSZYyO02om smQucavKK4vee+58A3IAm89HpWfccNAfl1XKUOR0zjuvHnUl/C6DU9Oqqe3B1yPGzXOB /+JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774128460; x=1774733260; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=72ApMUurYX2GgJLwF7KgodErv2db4HcxpZX43xt8Nqk=; b=Szylv1uWXexK+DH4FV7XGd29DBfbDzwOf3HSb749wupiMflNOnUYR/C9gt7qCadJpR oN9PmSKhpINM3wSjUSfTUIMjr1MqwIPmqeTfx4DnCKg3vwzAJ1F1oOfVbu8sKzawga1B iiyl0U4H1eOkN6tmmCI+JgWpCCrSX4RGTi1MjGNaxfNvYkvjogL1750XrhDsr8tIZSZm duSyTHw7QJk7z4Yb0XrPAxQbJgVJUlWiACk6yTIJfAS58qgISul7/pF2kG6g9Ihg+v8y rfgHwFBgfesKoZ4qgj5/02WR/hiNpFR7c3dVCrje7mzRfilqDbdaFwKdWhaX1n44OdQI 1ZLw== X-Forwarded-Encrypted: i=1; AJvYcCXzKRrCB6wpQGXg2i+4zDOHlwIeXWjC4GNmgOqzVBlJcDQkVrli56Po60F/tpZi+uBgPsM6p09qgymfSO4=@vger.kernel.org X-Gm-Message-State: AOJu0YxLwY9Ugoltqewiq9s+dtDMNw9oYWI1VzbcdSBzQrrtgm0s86yk HCX5fy4umoBA/yNK20mYlcQRLFyyLRIjwg3cBEGH1QrGXFqyizi7gX2DovpPJwKh03eSxO0NTGF bmlxc X-Gm-Gg: ATEYQzwnVQo+Fk4+nFq0RVpfTiL7gjjVjQTmvWCpeGt4tf/uXsgl5J6OSQFB4mjAPov Fej3RNSsYYpvimPGoOIwLcAt+mkVy+eUAZ7C97f6fHHdUOFYlb+xAfHwTiaD2B8UFO0V3OmcvcF NkAPPsHpTiGT4AFO/g6IHlVZpVm2EpnCLy0+YPN0ZIkcsxphIWBXUenHsGbKh4MniuPYiPe3vWH XiNbEEIkcqiNpCxbxMl/ID/fP3ls19VLGEmXSdyadsVgQyl7dysCZ9FIG9DBIg/TZqG37/ZFNl7 eR06ky6cPKWjGTkUEKgKXdXbWiRGe/YOrJXjwMkJrGaGzrKzRZsgxnwpD4xLecW5OVRkH7NjnaN x4QxTCfxhowbHUr+wM4dRN0ixHMkqxQoLc2CPfJ2QNFq4JmiQndqDhsn86ikCrL85FpbRuoBw3U SP05Z4S1xXpHTr200HbkHSqWzYIS3J X-Received: by 2002:a05:6000:240b:b0:43a:580:f60d with SMTP id ffacd0b85a97d-43b64264bc4mr12386445f8f.35.1774128460075; Sat, 21 Mar 2026 14:27:40 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64703650sm15981010f8f.20.2026.03.21.14.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 14:27:39 -0700 (PDT) Date: Sun, 22 Mar 2026 00:27:36 +0300 From: Dan Carpenter To: "Jose A. Perez de Azpillaga" Cc: linux-staging@lists.linux.dev, Greg Kroah-Hartman , Michael Straube , Hans de Goede , Khushal Chitturi , Luka Gejak , Vivek BalachandharTN , Artur Stupa , Zhuoheng Li , Nino Zhang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/2] staging: rtl8723bs: clean up rtw_joinbss_event_prehandle Message-ID: References: <20260321182713.665872-1-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260321182713.665872-1-azpijr@gmail.com> On Sat, Mar 21, 2026 at 07:26:58PM +0100, Jose A. Perez de Azpillaga wrote: > This series cleans up the rtw_joinbss_event_prehandle function in the > rtl8723bs staging driver. > > The first patch removes dead code guarded by the REJOIN macro, which is > never defined in the kernel. This simplifies the function before the > subsequent refactor. > > The second patch refactors the function using guard clauses and early > returns to reduce deep indentation, improving overall readability. > > v4: > - Removed redundant return at the end of the void function. > - Fixed typo in v3 cover letter. ("Rmoed" -> "Removed") > - Picked up Reviewed-by tag from Luka Gejak. Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter