Re: [RFC PATCH 04/25] perf pmu-events: Add counter info into JSON files for SapphireRapids

Liang, Kan
2023-09-26T15:20:30Z

On 2023-09-25 2:18 a.m., weilin.wang@intel.com wrote:
> diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
> index 2809f68d2..5614bc203 100755
> --- a/tools/perf/pmu-events/jevents.py
> +++ b/tools/perf/pmu-events/jevents.py
> @@ -655,7 +655,7 @@ def preprocess_one_file(parents: Sequence[str], item: os.DirEntry) -> None:
> _bcs.add(pmu_name, metric=True)
> _bcs.add(event.build_c_string(metric=True), metric=True)
> if event.size:
> - _bcs.add(event.build_c_string(metric=False, layout=True))
> + _bcs.add(event.build_c_string(metric=False, layout=True), metric=False)
>

What's it for?

Seems should belong to a dedicated patch?

Thanks,
Kan

> def process_one_file(parents: Sequence[str], item: os.DirEntry) -> None:
> """Process a JSON file during the main walk."""
> --