From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98BA732D7F1 for ; Wed, 11 Mar 2026 05:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773207003; cv=none; b=RmNXKUri/Jll7uTUUfPO3H+8tNjJUIXFjh+mygjtd+8CwtnTkFIetHWVX7iSo/M6drzqiv6HpDPnqP+LZNyE/KXkq4Ztm/BOGLhiVvueT4+75uMFmIzOwVy6sjqhHAtJiWpxPh7KMmddsUba7vRScjYUWjqDfrjzkU5KvaPrRkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773207003; c=relaxed/simple; bh=Cl7naJDsdxKofAKL13XTAAg0NFqCf5G30oR7fQpbKvk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mVoS++/qIj/LxQCvBrwsTTgipSG0e1GFcbO6zeiOGEb3CPGqYgQiP/tR9WL+WdMEBHTWRHpQWG//1+e8xLLbBBRrCODQyeRMR4c/K4MzfZiPcjhtrxYVsf6ylnEn8PAtZYxgdt7z7awxtmzJ6s6fgYg/2rAPRFGGuEDgMaaz5ec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZYYxjQZb; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZYYxjQZb" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ae4e538abdso98842155ad.3 for ; Tue, 10 Mar 2026 22:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773207001; x=1773811801; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tpIlh++gNSqrjxti8e+fCN/v6IbpRXIC+wi7lGmEm8w=; b=ZYYxjQZb672J8H8bueVgQZkkVe2nlsxN9HI6km+HLy99eC9o+Yd9mCrbE7rV4hvSkx idHDuSqNyyWkae9+yZsth9HFzudxzo0kFYdhcDdR9I5/Uh9Xrgjn+qfekbBhLKRa10T2 TcSWMTefrYZfjaoV89DJCNfXAtiDXA87xF/zg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773207001; x=1773811801; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tpIlh++gNSqrjxti8e+fCN/v6IbpRXIC+wi7lGmEm8w=; b=ei7LB+31UuA0rDQw3XBCLyGMhLCYTFihp1008uRurQITQQksWoO0IgHDizf8uE4de+ nOMzULrh7xg+TAW7KNIy9Lg7DNDZJcv/0qeU9KHql0I+0So7wVb45SW0OhiYIx7QHaCK 7EfnA8Sk/v+nmJfFMfdrDLZuCwXdgM9FNFk1KNlB88SQ9lZfdpS24UipS2h0laoFCHHk x8p0kPKm/Bib/DgDOXsnyhdegFOqxsYLud6AzureQnenJ4tV+eTcv1oPWjHVXSHbgVtP 17+mjme8OSOSf0nl1MwUftFa2Sn8GkMmurwnE0rxoQEunm8++4vDqj6HDNFeksuS2iV+ slWw== X-Forwarded-Encrypted: i=1; AJvYcCWM+hAgVPAqGdrT1DLS/iRlTuy2vDqbK7WekP4labE057orJ53BiMKMNvughFrCkwKO2ZAdgNcQI0G0b2I=@vger.kernel.org X-Gm-Message-State: AOJu0YxsdI/XIgHKolLYmkjQshSpqu7/IQR8PKuC4DrTQyn+Je7gSt6W tDuuaENd0OJ2ZBkXACwyLdHmQiDgMwu9m7DB1lJbSLiQgPYmTajvyW+3MUSloT3wxA== X-Gm-Gg: ATEYQzyRwEFsduWE1Wldv9hCAs5/4alZCye4pcZLO+EYlzUe3DRA7B2H3wtAU0t1Qt2 cFsEyl+wR16Ix3DVnrGf+ycDyKVK6ZEOMzUuNbAGjj41kXb7MJzpbqcf+ZKNeedjEOocVXWWdkA Xr6fIC6BLh8jnRWDblk6Zp/QEvAnq89eX3r66N3Pp5mDNpdpWHespEjpQivMd9iim9R+xfQ4/Tn 09ifH3Ucb4HsKZvh698orY/ldUJF6nvFs474/ci6tQmcJtGTCusqAWz1lVdv9n+YXZRW0HfkE/1 PFhLOlskAys9Z6Gio8zZMfvp5eaXNrVyaJIHPVPavZu5aEYcfKQU0Xjfy6zK5qNQTS34/z6xFlY FCHsDCl1p1Ic+boUeu1hiBDqC8drfMLRZb5KXYqU/yoXSxq1Kng1adHgBByCIBnvrHZmVu5+Uwf rgzCUKPooUR3S0LKVNn0N6FHcR8lP6TBxYDoCSWCBeaDNA5E4QkgXv61lHATnlZhs= X-Received: by 2002:a17:902:c951:b0:2ae:46df:5643 with SMTP id d9443c01a7336-2aeae763812mr14917185ad.11.1773207000953; Tue, 10 Mar 2026 22:30:00 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:93a4:8281:fe98:426a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae222a2dsm9964165ad.17.2026.03.10.22.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 22:30:00 -0700 (PDT) Date: Wed, 11 Mar 2026 14:29:57 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Minchan Kim , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, Brian Geffon , Sergey Senozhatsky Subject: Re: [PATCH 3/5] zram: recompression priority param should override algo Message-ID: References: <8a5d53d19a8dbd51d7d81d153676895163e0735e.1772180459.git.senozhatsky@chromium.org> <831636c74ca6d72317de02d96585cc6833d082e6.1772180459.git.senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <831636c74ca6d72317de02d96585cc6833d082e6.1772180459.git.senozhatsky@chromium.org> On (26/02/27 17:21), Sergey Senozhatsky wrote: > Recompression algorithm lookup by name is ambiguous and > can lead to unexpected results. The problem is that > the system can configure the same algorithm but with > different parameters (compression level, C/D-dicts, etc.) > multiple times: > > [zstd clevel=3] [zstd clevel=8 dict=/etc/dict] > > making it impossible to distinguish compressors by name. > It is advised to always use "priority". Additionally, > override "algo" with "priority", when both params are > provided. I don't like this patch. Andrew, can you drop that whole series? I'll send a v2.