From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B62AB332EBD for ; Wed, 11 Mar 2026 01:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773192144; cv=none; b=cY4sfn2r/C71yjaYLHqi+eMS8auGeCoVl7EhysM8puUI9wqtOOH966KHaCgYFHu/uxzWJpM5+ZxDqwWXXHWEfB/G1yKjTTYrAKv6hcejU8TdkdK2ovy1szl0XMXJu3kb2CbI8vYCrkXwhPSgsOseAgYwy+WJzxP9eNN9no2qnI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773192144; c=relaxed/simple; bh=kGsy0b5KOWq5KuvAJPAe2ChW+aktGyhPr5Fvlh4msew=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GYyxgEHmmzOLYXLqiSCgPzGg1EIjTEl0oV8pA/z7xDnM3AAvEtIhgovt8qtH9oEO4jKth0Tgr9KWKBFJPoy23L/1dwsa8TIeIFSAlX2lVuQTSQXAl3SoGY1ULAPVrVrpU0x8qrMTxZZtOaCfYhLtD45LQqbfl0zVcJ2/Vz1b3hA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=bI2sfZpj; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bI2sfZpj" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-829a9d08644so2782145b3a.1 for ; Tue, 10 Mar 2026 18:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773192143; x=1773796943; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qLXe9b91umT1f2u9z3Pl/31L7d9kVUOK4uWgGsELxSs=; b=bI2sfZpjxLds9wsVCdqzivcI60XYSym+fd7btd7q5HHmyX8WalpaR3zh7JdqyxEtX/ zkQIkCR8JP42u9a+U9X3J6Ms/1FXiT16YNENu6LehdCZQQT9nXFpun2hjZhSTk3kALfh 6n47d87mh8XK8mJ3g3zvIqeZfMnt8njEToqFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773192143; x=1773796943; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qLXe9b91umT1f2u9z3Pl/31L7d9kVUOK4uWgGsELxSs=; b=UdZmBOT8SAzRiPVOzmqgUCcjsFAt9Ao55HxdQq01M342lSUF8qXKx8OSNc6HP1H3oH ywcst7jRc8OTOHEHcDtpBC4la0RqBiyVUhE5cCE4nYMY6OZ61eSnD6fFudZVTnrS6tSG nxX0X0oTHZzgo/Ho90HrXQxWUjvBxzu/AQQinGgvYj2hlrjYR419p3WwBcYJrBiLAENr HalhGQJuJJS14Tl8MaHGbtTYwfJbx+Pwc6NR09OQEpatgmi73q1cL6i3AdwYtvzIHnCx PliLaFHIXJ0r6ziiA8NlAssC36foH//kwDFj75aSN1058/vjgcva8960nYZRO2T6jsrR 8K9w== X-Forwarded-Encrypted: i=1; AJvYcCUtbZqM/2nu1WXghHzkzEBjPJaEEWIqzl/Wal9xSZFiudVIF1koRjW5n3qbbQLb4M9gmJW+PUiXqdRCqro=@vger.kernel.org X-Gm-Message-State: AOJu0YxxTIHau0BuN3RsI5+71v0AaVMaXG7QvervGv8lqZTy2v+fHHxL RdlpKgy7IvglMoE4EJuhGC4DMAHJsJFimHpSIEBpQLTQl/HR0+b6dEVavFB4bmgFF2khf9mxUyT 7bLU= X-Gm-Gg: ATEYQzynz8+5eEUeiVa5sRUO5GnI4kvns7GwGGshU57HEbk8CVTL05u0YBKm0YP6ToI Kjitw7c3AWBtaZ2gikPrcwTCn8M8hScMn9gHLPsHgQppeDd3odrWOTjJ4lxaRvrn9386138Oiyq a0pn+rWA3OnghEYilnFT8smFE7nPZCqe+/pJMOrkPsczpJt/9O7qoimrq9G27AX9eyI1KqK8R8E TuYlXySw6f5tsTBiyvNh9pcLvOtiJUPhMvI8Zs5/bSVxYa58nQryzqT3yHLpx8XqoQCMrV5kx1Q qk88Xia1SjPKQlO1xXyEhB9hYzhWW9k5zM06pfhxZ4FBrRmQoWvZYj1dTg74Zr8x9mJbudSH1rr 0a+G1MJPgCv8GMMD5DpVV1hOLnDdpOxePrS4kpP1FSFhOitRHL5WS6JKoHyq9KVT7aGHi47agjn 2i24DmIHHu+0/nJvoNjbnYrWHaSA4yAelRwKWpxXO6ay/t4dM6CvRIAONZU00cxNM= X-Received: by 2002:a05:6a00:4148:b0:7e8:4471:ae6d with SMTP id d2e1a72fcca58-829f70b8b5bmr767543b3a.57.1773192143073; Tue, 10 Mar 2026 18:22:23 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:93a4:8281:fe98:426a]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829f6e23c93sm486974b3a.29.2026.03.10.18.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 18:22:22 -0700 (PDT) Date: Wed, 11 Mar 2026 10:22:18 +0900 From: Sergey Senozhatsky To: gao xu Cc: Sergey Senozhatsky , Minchan Kim , Jens Axboe , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "surenb@google.com" , zhouxiaolong Subject: Re: zram: Optimize LZ4 dictionary compression performance Message-ID: References: <234ad9d53124461185f60b9cd2f1603e@honor.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <234ad9d53124461185f60b9cd2f1603e@honor.com> On (26/03/10 08:32), gao xu wrote: > +static int lz4_create_cstream(struct zcomp_params *params) > +{ > + int ret; > + > + if (!params->dict || !params->dict_sz) > + return 0; > + > + params->drv_data = kzalloc(sizeof(LZ4_stream_t), GFP_KERNEL); > + if (!params->drv_data) > + return -ENOMEM; > + > + ret = LZ4_loadDict((LZ4_stream_t *)params->drv_data, > + params->dict, params->dict_sz); > + if (ret != params->dict_sz) { > + kfree(params->drv_data); > + return -EINVAL; > + } > + > + return 0; > +} > > static int lz4_setup_params(struct zcomp_params *params) > { > if (params->level == ZCOMP_PARAM_NO_LEVEL) > params->level = LZ4_ACCELERATION_DEFAULT; > > - return 0; > + return lz4_create_cstream(params); > } [..] > Should I modify it like this? Do you need lz4_create_cstream() as a separate function? If not, you can just move the code into lz4_setup_params() and remove lz4_create_cstream()?