From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5A0E2BD030 for ; Wed, 11 Mar 2026 06:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773211887; cv=none; b=t9nt6zJShSWDb4oBaaPhwCF+vd75nWk5Z/1XyF3AjpaV9owZfA6Wng9DdN0KZ0pQLXh+OfdkD7C6ZagVucJ1qW3bNIZpIYYJhRpceX6/mk0LlvmZ59BHxDPLUnLTRHR7J9DnLAarZv9lCpehcafv/oZUVndVd/izEtS4rhd7hsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773211887; c=relaxed/simple; bh=PzPcFTQ3tXwP7zF5f7H/cw0KlxWYCJGLWtrtgS88JXE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r5g0Zr3RN+0haX1E7PbefufrCanAbl3immfs3mySuJbeMI6fX4yS7X88V24oe6xLyhxRS51L1c37zrbnhPWLc55FqJZCKdKyUfPUUOvbQsNMUJxDC0Uxkd5SuM8WKn5Xl33Z/4wKQ5t15X44ay22q8c/SJfJIzKExy07Hwdf6Ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u0IgWttN; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u0IgWttN" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48534237460so37733885e9.3 for ; Tue, 10 Mar 2026 23:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773211884; x=1773816684; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7zvEX0IAkMa6oXnGfx3rdipMmH1BF7wL9zhJ+aTV/NY=; b=u0IgWttN0t2kyvnbuaA/cPXyQSBGDt6n0UasqFNVxJUrU353xF55fuUABB6DJA/qkX U/qiU5Ark8KUIF2CQ0KopcGh3F/PMW8c+adL0lf4Cgae2591SU0QzLAir+FXNMFORF87 EWk8TY2mNXC0cGxCpcYAowv4onkc/1xJl/NkbpsIdL0ZyL7iGshqvxywjsvPFuh5piEw GCZ4lrEjfTNPd6ZMSUZxrSgVXUyRIDiC0weIAb9huh+C0yjQaE2Mgi3KGEbKDht5qE2F 6xs3MAhJMtCBSjF8lRYOhj4ykV9OfXqsDJgP1NjSRlnyzqO/4P1e317nQFihI8Hnv9X0 J5UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773211884; x=1773816684; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7zvEX0IAkMa6oXnGfx3rdipMmH1BF7wL9zhJ+aTV/NY=; b=APnxZUFb6oZUsYk/wAFMvE3iy0CBxwiY//PzvgXLXLMG2kkexZJpitH/Cq6VhV2AsG JNIlt9JDsV1REeBaZxBt2U/VZ66H0/RVe/Msh9e7L8P0uUFQaFpZbu7ejZyP27QruAWl uUGVQmp+9rITzFVQTGp1HxYfS1o01esRX5+DGzvV7yh4C+VZJx/tE9QExSNrdy4YYyZW /DMBwDeUdM0uihzCkfluGo6z3TMCAOZK10v7yOPju7wuj+hI5p/uNfxI7Cc2I9LI3AlS puElvaiYtVL4GwAzC8Z6Dn2idpM4lNi5VQ/hXQSpoqsaU2rzvyVNt6WsMb3XTsgJPcko 4lxw== X-Forwarded-Encrypted: i=1; AJvYcCW+uzVVvf+uAjNPgu0Q7qcIrB8KeyWU5nEda49pvsWmRDo+IyeDhZpdE2Cmkq1ilsCb0tPQ0c1o2oZekhA=@vger.kernel.org X-Gm-Message-State: AOJu0YxkpWITEvzg0P4hNCtHR+PnKyguhjrR8NiB8GC8CJ6yNa49vkuv qxl4RkKKdjXjaGC9nznzibMQ3ZGnX64J8qBSQFG8OCQfaLST50phVisH1f5gKC+Qpec= X-Gm-Gg: ATEYQzyHLnKCbNXFD363nkutO3hRaniEpQ5fBHl9Y/dBf2JB3qU2f4BoT1W5GSMuYXP 8vy332BBMIKdeNBN33jWasebpS5UehYyi5NS+aGNvZYLdh7vhMNk1YOk5EEEA4XAOBXIfVUL3dZ 1JbYw3B8tmmuqMmUi6AlcyKyedUS6+eFShuAJPgiJDrGYJAvE7DqCeaBOra4dfVgUVVUKvsX7z6 sSf4lFzEBHCsRqyw85G+T3yeKCXWbuquwQML1TcJrSHC6/5ee71obfppudyqWMRHajPM7DwKggO NgUiCiwe0Sk3E9Y3Mz+5hxON+bXt3gdscyOIe2uu0IQkDyG/3ohKMgyo8DklypXzuPIA6RMYjgC 0v3fhu55urfD4VMYbJZtfNuOh8o9jiilPtZ1i8rFk3SRfXgOdcJBphDa8USdIb688ZPnIRIHOem +jorU9wFvu83En/o2HMH+Si5BlpRiJ X-Received: by 2002:a05:600c:1383:b0:485:2fe9:3375 with SMTP id 5b1f17b1804b1-4854b0bff59mr23795475e9.15.1773211884113; Tue, 10 Mar 2026 23:51:24 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439f820a2f1sm4090148f8f.30.2026.03.10.23.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 23:51:23 -0700 (PDT) Date: Wed, 11 Mar 2026 09:51:20 +0300 From: Dan Carpenter To: Andy Shevchenko Cc: Sanjay Chitroda , jic23@kernel.org, m.tretter@pengutronix.de, mchehab@kernel.org, p.zabel@pengutronix.de, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, pure.logic@nexus-software.ie, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, kernel@pengutronix.de, kees@kernel.org, nabijaczleweli@nabijaczleweli.xyz, marcelo.schmitt1@gmail.com, maudspierings@gocontroll.com, hverkuil+cisco@kernel.org, ribalda@chromium.org, straube.linux@gmail.com, lukagejak5@gmail.com, ethantidmore06@gmail.com, samasth.norway.ananda@oracle.com, karanja99erick@gmail.com, s9430939@naver.com, tglx@kernel.org, mingo@kernel.org, sun.jian.kdev@gmail.com, weibu@redadmin.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, skhan@linuxfoundation.org Subject: Re: [PATCH 1/7] staging: greybus: simplify cleanup using __free Message-ID: References: <20260310200513.2162018-1-sanjayembedded@gmail.com> <20260310200513.2162018-2-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 10, 2026 at 11:07:16PM +0200, Andy Shevchenko wrote: > On Wed, Mar 11, 2026 at 01:35:07AM +0530, Sanjay Chitroda wrote: > > > Replace manual cleanup logic with __free attribute from cleanup.h. This > > removes explicit kfree() calls and simplifies the error handling paths. > > > > No functional change intended for kmalloc(). > > ... > > > + struct gb_camera_configure_streams_request *req __free(kfree) = > > + kmalloc(req_size, GFP_KERNEL); > > + struct gb_camera_configure_streams_response *resp __free(kfree) = > > + kmalloc(resp_size, GFP_KERNEL); > > if (!req || !resp) { > > Now this check should be done in a better way. > Yeah, two if statements, right? Drop the curly braces at a minimum. > > - kfree(req); > > - kfree(resp); > > return -ENOMEM; > > } > > > > > done_skip_pm_put: > > mutex_unlock(&gcam->mutex); > > To complete this, one may add a prerequisite to use guard()() first. > I don't think we're encouraging people to re-write existing staging code to use cleanup.h magic... It's unclear if I have to review these patches or if they're auto NAKed because we're not doing the conversions. regards, dan carpenter