From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C47931690E for ; Wed, 11 Mar 2026 06:54:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773212064; cv=none; b=bq3SkSEQNG1h7PF0RdewWvWhhh2XJSf+Kt97njchWYaCek6lPus3JIbuyKGSPFR23RdpWDpUkNMLVJ/hmaLkwnP9m3z/rxBwyMDO3Gu9Umyx1JtCOwMn6iyLRY6rkHQu/9Z9bFUQiEkg2kler1TxFLJ5ZJxq5C/iIIOMQz/tE2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773212064; c=relaxed/simple; bh=UVRKAdZHojHmopPQfckr6WfYfaCPtUN605Fdvm8Mskc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WlIukOzLyhtR48S4A34OSRnQh6YFxavnTLJ7aK/sSrsSY0PGllxElUTmYcMiLkSSYq3ArIl3NdfQsPMu0/A0TpX0V4Q7p1olZaImqmC+TqYkRgQxPF/+187fyuaBKNOHgCaROVkJaMsEngumXopSBRR+Nka5zeGu6m5nP+f9f24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=S4zFkubB; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S4zFkubB" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4852e09e23dso34783365e9.0 for ; Tue, 10 Mar 2026 23:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773212061; x=1773816861; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lF5ZKsF6F7Qr5iBaoEQm8iifpJM4zWXRKtFu+dhnmr8=; b=S4zFkubBM4jSE2bCXQCLJQbBKVpUd6lkg6mu13Nm3mwSV+fWFyEQkWrpx3S9J2c5Us Em/+TGicE+UtH0hvWkc+IVikciVojco0MSYQ0vfdEB0kAfjtJ2ZkekueeftIgr02vQu0 8lX82qrW4QF+SJOrRpjllMHX/oMBvaAWbFvlGsPYypkelnkFdb9IC72iBN88l4LuCE+k +A8fsnfu2MYL4MIh9kl6ucYZX0Bb1zTP0A3vuEGfte2WXbb67waTHDZGZy1TMYWrmJ7m x/hMSMtJ/rF/4ammotVJU4MRpKJtCTb+lS42JV/dInxB4vV4Z8eM6xldvvFtjbFwYuMv ZD4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773212061; x=1773816861; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lF5ZKsF6F7Qr5iBaoEQm8iifpJM4zWXRKtFu+dhnmr8=; b=VbnKQm5mFu+HJBYiY1CFCxqMfM5KqsNii1p8nqYhLUtcRCS1JaFyEG2Yv3B9TsP+c8 w5ayATRxa5YmRm+UjusuTROgC2A5nNjV9c3ymCYyfjmcRtzUr+JXOJKmjItJPJlP8q1b F3hbGP88A40C2++iG7IE59yK3YxkIY4vO+tGNAKSTr7ZkhF0rKQ3BPffBF+7cHrz/Scd aeqCwVi/vJAX4+8T2UHsKmRFjOJSGPVsbZMNzg6vIkfOtHbxIJu+Ht78aIBl59Jgf5DM dySKTaALQHtqdbcOxOmvb003uuTusK3aCUJmIPVj/kdbUXKTEk2K1oO5ol3V7qGC0WMM h6HA== X-Forwarded-Encrypted: i=1; AJvYcCWhWlVFFnvJe5mGPE+rLFyxgyswatv9abLB2CwzscwH19+1l/75jbP41AwbmACxvYeq2Ode2l94d37bvyw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxq+PDjMhUslmieinj/BXYYQQpk3r1tYUmvvkWJQ8uKcedPG7m5 Zn3tKc5qLbDRdBENBphB75n3hfG1Lo1FdZYZuXo84vCxcNnKjjAuTSJn9UDC9V96Qms= X-Gm-Gg: ATEYQzzW20TZhGnCEh1Q+4v3DOsnD/ex4WpF3c2q5RKQRFXrQOaFEkYJSOdGDBANnkS vueTrfTFzh0sM4rZTW1mB8UE+rKuPK/Iof3NUPGri6F7+acQ8JnFkfP/Z3Vn+ZM/Qt2A8tbb3KC 5dKqZ8P/pFBnkNXnwhO8lCocqpmvDd5A8ZPcE7PSlVwJpwa+QFehI8dJPwRGJBmZgSoyp9euWCt QzevDMzfM6nQ+clwQKlft44aIWZ1bvPQFyVvvHGkvWqFQ5jwhRVXTE30Ccj7KC0FTGD1KGT+Qni Lk8DQHMDYJ633ag2c56J6cixdxJRSeC8tR2YbdW8wkItooFtPsXx3B1/o2AbDZUaHYnjuXK1oo/ rXxx1EH41f37Ep3Sl7OtilYxwgRIqUNojXTswxjlz903ovDvy2wQXxMu4dbE4j4mVyyHVo/R09J YmfJSbS+Ud9/3rbG7zINWK/GZLFOLp X-Received: by 2002:a05:600c:46d3:b0:485:17a7:ba0d with SMTP id 5b1f17b1804b1-4854b131975mr21611215e9.32.1773212060586; Tue, 10 Mar 2026 23:54:20 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854a307bc4sm19730455e9.3.2026.03.10.23.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 23:54:20 -0700 (PDT) Date: Wed, 11 Mar 2026 09:54:17 +0300 From: Dan Carpenter To: Tomasz Unger Cc: Andy Shevchenko , Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c Message-ID: References: <20260310-atomisp-remove-void-return-v2b-v3-0-3fdddab41271@yahoo.pl> <20260310-atomisp-remove-void-return-v2b-v3-6-3fdddab41271@yahoo.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310-atomisp-remove-void-return-v2b-v3-6-3fdddab41271@yahoo.pl> On Tue, Mar 10, 2026 at 10:39:17PM +0100, Tomasz Unger wrote: > Remove redundant 'return;' statements at the end of void functions > in rx.c. Void functions do not need an explicit return > statement at the end. > > Found with checkpatch.pl --strict. > > Signed-off-by: Tomasz Unger > --- > drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c > index 9cfb8bc97e24..bf9be11335d4 100644 > --- a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c > +++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c > @@ -44,7 +44,6 @@ void ia_css_isys_rx_enable_all_interrupts(enum mipi_port_id port) > */ > ia_css_irq_enable(IA_CSS_IRQ_INFO_CSS_RECEIVER_ERROR, true); > > - return; Delete the blank line. > } > > /* This function converts between the enum used on the CSS API and the > @@ -197,7 +196,6 @@ void ia_css_isys_rx_clear_irq_info(enum mipi_port_id port, > port, > _HRT_CSS_RECEIVER_IRQ_ENABLE_REG_IDX, bits); > > - return; Same. > } > > static int ia_css_isys_2400_set_fmt_type(enum atomisp_input_format input_format, > @@ -638,7 +636,6 @@ void ia_css_isys_rx_configure(const rx_cfg_t *config, > */ > input_system_reg_store(INPUT_SYSTEM0_ID, 0x207, 1); > > - return; Same. regards, dan carpenter