From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE663AF648 for ; Wed, 11 Mar 2026 07:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773213784; cv=none; b=NmnFsdk6I4hCN0g6r5gjR3WYUL+KESqfqHDsldoPznmwSKXlBO+5yOMzWKO3PC0VQRAfVNtyCA1rjJN+NVYSGbKChzPRS6HHkyekooffRp3gqAfvIq/XDVEgssrjbRHYDAYO9QcADWGDL18p/yp/8tXdIZ/RMANc8e2WFPlcnE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773213784; c=relaxed/simple; bh=4h7q0aW632IYrtgogyF1+Py8qp0ql8NGsU4ff1gYQPU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VxTmQrMm/yKAY+r3CTy7k/hhP+M3UpWGb1OWp6h8yDseZa3mmGDIjq77OANj4Foh0zbra90fGAnKfdmqyMOoFCLSG6BAziSD2EeM9jvG5Mp7/AdA4sYEG74Bh7DnJZ+TLZEfhq9OoQBWylkZUD6J03SVJ3ooEMihhtdELhfbJAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=btFi3Vpk; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="btFi3Vpk" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-439b790af67so509737f8f.0 for ; Wed, 11 Mar 2026 00:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773213772; x=1773818572; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NsP9rDmMXfVGzEA1J0kgDggGIcSaIxHDyX+DUVCfTBk=; b=btFi3Vpk2Cg+ry5PoMZVp2H3ghehUZpNvMuIYyrmAhmoOpQEmauBSTllaiTtWvxNZq lliL2h++UPGdIGjjbIIrCSnisUhPTp1PkU/FLATtLUOPg+M/HpXacQJvUszLHEZ8tuX+ /6z1QdRft7KXYuNAu9c8sI0CLZNAqDlBkpr5Sga/Cq3ngRK3yjQ0gETNEnqlNlEwQfnf +YZ0omtonJs2/5TVXus4b3E87iBrkcr77hbEhSMKJg5CAKkNwSYkgRYJzZPB6GvG8e91 /MJdNOV7AOzoqSPbLlMaSxPAfuGho/9IbO0M32kgVzNxRh1mWEx+fdNIbUgIPOSRglV1 Wjwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773213772; x=1773818572; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NsP9rDmMXfVGzEA1J0kgDggGIcSaIxHDyX+DUVCfTBk=; b=QSpUx15Q2vBT0XDkWWoHEilFcrRlZKyPw6scSWh4niNN9T0sAs6IcczZt7ElSF0AtF TC4Rd60N51p7ahz12jhGroRU/JjeyVA2OV6wJMrtKPJ4+cHTQdFbPgy3rWBLqwFbDctP PVtplhmaRCzOO6+BX48gPUAU0z3ttX5cpm9EpKSwSXb+G1y53zZ3sVGwxy+7Eh/V74Ep NfHPpZu7IC4BpOcpSgcZMsXhlCcS40kN6jZvuIZMqf7+Sdz5NwwvrmL9asgX784kK/en fhal3JF4N1dyI12zaXku3DSu8OzcD2fU29h+t2yKqjaMxylNjgdOh9usjgsWo6A0bmiG FIcg== X-Forwarded-Encrypted: i=1; AJvYcCU7bAkUreoHrP8qUFnu5GBDgBdxPOe3RCneq1LTFKiqv7wxTbwKbevom8ARaO7oPVSA9WaFN1mm5FdERdM=@vger.kernel.org X-Gm-Message-State: AOJu0YyIAplsSrjjy2GEGPRuIOEzinPL9FOVEEHFe6WzVQXJpsgVxneH hGhC719j7IIzmzi5TDUOVjGtuCDa391FFQtBpzJXevIVKQwDluwBjw+nTkSrluRPqCI= X-Gm-Gg: ATEYQzzUbi3jzD9kn8pA8fIrE/hXsqK4ZXOg5xgRG8pR1PMNxelG7LRStdszQMT2HSR G91Jx/vgqqK3JxMKpQQlc68wg4/ZXAwrQfnT8mlTuUIEDIia/GuXGrAuOjWXsTm/lEOf2RaxMZ9 ygHNAYoF8EfLlLzrSrz78+kUTFO+liq4zaZQHI5rg/+K80QdmEi2Qcs1//43LO9W89d+p+Jqe9X J4VK0y1bxMhDEdT3/9cpWVTZ/s/oWyKA/nuAAmRuPwkt7P+Fo97dfj9u1bZi18mk7pjQIE1iSKR nyDEWZ2uVF9g46nI+dT69qDEZcolLbCLHv1FKMnBwHdxeYy68bTdcpaVLYtdXzmP9Gg32znyyd7 4hp5ZkWxgO/ZGReIgyaCbub2YtLiUNB+bkfSMFmJg2h9BKRdnqExJahyBhN1NOuyUrt+IYMHhDi 0wiCf59IerkdiH1TwwdFvEaCX+RHQT X-Received: by 2002:a05:600c:19d4:b0:485:3294:fff0 with SMTP id 5b1f17b1804b1-4854b29e736mr22629695e9.17.1773213772335; Wed, 11 Mar 2026 00:22:52 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439f821d895sm4240139f8f.33.2026.03.11.00.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 00:22:51 -0700 (PDT) Date: Wed, 11 Mar 2026 10:22:48 +0300 From: Dan Carpenter To: Shuah Khan Cc: Ai Chao , gregkh@linuxfoundation.org, b-liu@ti.com, johan@kernel.org, badhri@google.com, heikki.krogerus@linux.intel.com, valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me, tiwai@suse.de, kees@kernel.org, christophe.jaillet@wanadoo.fr, prashanth.k@oss.qualcomm.com, khtsai@google.com, tglx@kernel.org, mingo@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] usbip: vhci_sysfs: Use safer strscpy() instead of strcpy() Message-ID: References: <20260310094434.3639602-1-aichao@kylinos.cn> <20260310094434.3639602-7-aichao@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 10, 2026 at 04:10:20PM -0600, Shuah Khan wrote: > On 3/10/26 03:44, Ai Chao wrote: > > Use a safer function strscpy() instead of strcpy() for copying to > > arrays. > > > > Only idiomatic code replacement, and no functional changes. > > It is a functional change since it calls a new routine. Get rid > of this line from change log. > > How did you test this patch? I am curious because of you are > describing the change as "idiomatic code replacement" > I liked the commit message... To me it says that patch affect runtime. It doesn' fix any bugs or introduce any bugs. Too often these changes are sold as a "potential" bugfix, which means people haven't bothered to check whether it fixes a bug or not. It's the right thing to add a note under the --- cut off that the patch hasn't been tested. Testing isn't required for this sort of patch but a note is good so reviewers will know to be careful. regards, dan carpenter