From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D2BA3C552E; Wed, 11 Mar 2026 10:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773226785; cv=none; b=P5l1GG9Eu+/LJfV+tI8qIzvIGTw7qHSi+zpk/LxvClgcIqlMeWDJfNCWH3OO9G5R9g9nnw0N82O4BdXSDLYpxzd0e/l0E9pw95JttAjGHOmdTtetH14b1gZlQ1x2xVqh5+dExHq3MQCzR+xSXL7wrOKb3DtB/i3pIVZFz0aCSUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773226785; c=relaxed/simple; bh=NWbVZd2f0Apk9phlC10/UOc9VRa5mnywdugFB8KMC/E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=miIP6HzP6On7X+1jF7mlZ07dL9xG2fnqdUVa1yU9u0VDjxC1a0HD6n5TwFM2rq7aEAB7BOHu/ALmQJSlySn6ThTa+EF0oAvrXZ2qqSFeFFz+UMKtHeH4zzQSOM8OTJdEPg15YZ4GUDbEq8IHpfaRI5e9DnpbQ32NB8t/BpSCI1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NbuVPsol; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NbuVPsol" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EC28C4CEF7; Wed, 11 Mar 2026 10:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773226785; bh=NWbVZd2f0Apk9phlC10/UOc9VRa5mnywdugFB8KMC/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NbuVPsolvA1iCHiziVg/YQZCU8nhtZ7WoL4OFlP5RwLzgJ8ArrunKkEZlqWrbRaYJ VBk5Qtaoeroo4VTY/puOUUpEjex4/xAumktU9Ae+/edkR6rDma9z09ZqbhCgTo31EQ JEIqOehOcaZ9n1lsgkD1NfopjyxKU5sCeljbyZDIQLdA20XdghhTsG33WMey843qNw XFit0QD5CNRi0jSpy/KZS+o5+dHVLz7VUn3xoVdN/fB6UYfebbTRY40RPHjVab1VcV Nx0myWJYpWKDdu9F9IEEE3t2zkSfCp/e7g2nXtc74xksA0IXjdRxu7ZQ5ncFzui+VT ncZE8tHF0hEwQ== Date: Wed, 11 Mar 2026 11:59:37 +0100 From: Niklas Cassel To: Manivannan Sadhasivam Cc: manivannan.sadhasivam@oss.qualcomm.com, Bjorn Helgaas , Mahesh J Salgaonkar , Oliver O'Halloran , Will Deacon , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Heiko Stuebner , Philipp Zabel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Wilfred Mallawa , Krishna Chaitanya Chundru , Lukas Wunner Subject: Re: [PATCH v6 0/4] PCI: Add support for resetting the Root Ports in a platform specific way Message-ID: References: <20250715-pci-port-reset-v6-0-6f9cce94e7bb@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 10, 2026 at 07:07:39PM +0530, Manivannan Sadhasivam wrote: > > > > I tested your patch series + your suggested change above, and after a: > > > > ## On EP side: > > # echo 0 > /sys/kernel/config/pci_ep/controllers/a40000000.pcie-ep/start && \ > > sleep 0.1 && echo 1 > /sys/kernel/config/pci_ep/controllers/a40000000.pcie-ep/start > > > > Instead of: > > > > # FAILED: 1 / 16 tests passed. > > > > I now get: > > # FAILED: 7 / 16 tests passed. > > > > Test cases 1-7 now passes (the test cases related to BARs), > > all other test cases still fail: (snip) > I guess what is going wrong here is that you might be rebooting the device > *after* restoring the config space in 'slot_reset()' callback. So all the > previous config space contents would be lost and the device would've started > afresh. I'm confused. # echo 0 > /sys/kernel/config/pci_ep/controllers/a40000000.pcie-ep/start && \ sleep 0.1 && echo 1 > /sys/kernel/config/pci_ep/controllers/a40000000.pcie-ep/start Will not reboot the device. > > I don't think we can restore the config space after rebooting the EP device, > because host has no idea about it. It can only restore the content after > recovering the device through platform specific means. Am I missing something, or why are we talking about rebooting the device? Kind regards, Niklas