From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA5F9363C5E for ; Wed, 11 Mar 2026 12:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773231968; cv=none; b=Oy/hOeijJmDt08Zm6kNprqt0ziH/dqIkwIvmwNiaqb+qfljE6hUobLrsu29QEYmXsEh4RoV5Y20/hzFtBH9MDfiyEaxI68O+CAIWdePt5RGJdk65cJE5qUmFutpDoABZ5Dl33P6ggJDhSZ5MlGmXzmz6Beug852yLk7S1tP/Lk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773231968; c=relaxed/simple; bh=3vZyIZVWC8fJ72sjXRRb7IzYrGuhIwd41aKD2gjizuw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B3oQ/SlI08MEWcnnnIrAso/rd6D10yPIBL3VtwqzwTb+dqOjOW2krfqM9x45TU8vgP/SxsYJz1kVVK0rdUGjki+nbYOkPl8lvNx6Ocm5xheE5RmhE7KdDEcl92XcKjnVezXMf+kyPwzFFeD3lDT+jBqdu522RdyPKUdEEOum3qk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ltpWexn+; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ltpWexn+" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-485344bbf1fso66705e9.0 for ; Wed, 11 Mar 2026 05:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1773231965; x=1773836765; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=T+wmJ0/ZZVhMHdMG7Wyr9vuVdzFL/xL8pORDFizXxq8=; b=ltpWexn+BUX4vAy5jfmXiowWbleANoa4lb+zUsq+Jas3KHlbr1lFoiubbwcVJCA1R/ PsLjsGjLrKPf9BTZ1pPlvkEMO6uEXVuB5KBZ33STgPHsElPwHa/Q298GSbQINZk9lFtv B794pZhoeGr1Sfoa6lc3lxc+RhKwKx27KzNR0gPv8hChiJgGam9qtM8/6DASRuVX+A9A ho1SvlqkUxtTs4jdAwd0lSKE3BhmYjLcmsP5vILBPOhdgQRa8kRtZrNOEC3f+4MFMDlh uE91V6Gvs4AZztmWohCt5XpySxByFPVa8m3IouErMwcIeyHT+tyaq/uVuTO0G66M8Ii3 k/ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773231965; x=1773836765; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T+wmJ0/ZZVhMHdMG7Wyr9vuVdzFL/xL8pORDFizXxq8=; b=JG3RtdtTPtDny1GmE70ugWEhcAt+BWj15+BcurYsbVKCc2NsvmtOSoFPyJag3fBdyO RDjCj4iyie8rGOfn/0T+2u8t05WXa3BwBxgF219bbvVW6xf5L1CcgELm1X13PBh32jH6 IRYIQJ9lRtqcADTXWPgDI/PWe1oPv4eboMcdnvJ2YlUMAA1cxqJf5G6M7SwWzRHOGvoE ICZRUGmR1kFIpMBvXdigjCNMepLouEIAo6IE6s+3O2R/uCWqWMhOfF2rhuI8Jhka0YcD m/yKi2lCxkhI1M3T5zNOkr6d45n+ih3eqqVGJgLAmx7qoGDmkjnn2N9Wco+8UdOalONe nCHw== X-Forwarded-Encrypted: i=1; AJvYcCUms3+2/jg7cT63yGsBVJks7dow5aAzOBspy8VONMs0sNqBYpd9tMT6Ezaw9POFF9vJVbGnTBaLTeFk2V8=@vger.kernel.org X-Gm-Message-State: AOJu0YwLAQvI65V9HEQvlO+FWldSPJKTe40wrrPUv+LNTKPyg2TICYXq QQQQ4mnSsI0oQ+3zbDXJM0nJ4VBV33Pnq4cSmheY/ayc9Ea2+ZrfEFeNlTVBtgK6RA== X-Gm-Gg: ATEYQzxY2pgMBNVIZiETjfKMPxQ4aPvzdsxRa54HJzOFWvSOR+TWH9uoncaBYX7BNu5 lKLZT5DC7pG0qC0RYf1q1tNkRMiA5w0JWwInu/rC24+owGg9o2E3ktwST84Et1KagUJ914e18q2 X9h40GuHNYNNc5v7vzckLgLTmzB1ueszllP0kBH1Zr/kzzaMNgjWk0O/RxMLv4J6itJggcjaT3s QPuNMIk0KR6YiIM/4GR/rq4WXA4svy/E7dWUIOJs/ExF8xiitmcB3sIDpTphFMI0vifClC0sKec a7i5i/is6Te6JKm92XIDgewPkqFzawyOHTDLsFNJCdJHM1AU1cQTyPn4AP88XtvHeEuM4KKF7oo GGpXWV4/Bg41UiMOBhoeW0O/SbX3zPHUDU7kCz+8xr1vieQqpy16M7u4a2DMpRKGYgszFuA6kCg m4lpVNYgYJ7Ui8uPrNMzmW3PLRQ61E2+IYPgJHmV3kFrF/c4ul6l7NiPIu X-Received: by 2002:a05:600c:a40a:b0:45f:2940:d194 with SMTP id 5b1f17b1804b1-48549d50b0dmr870165e9.2.1773231964958; Wed, 11 Mar 2026 05:26:04 -0700 (PDT) Received: from google.com (54.95.38.34.bc.googleusercontent.com. [34.38.95.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b0c4ab5sm16803305e9.18.2026.03.11.05.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 05:26:03 -0700 (PDT) Date: Wed, 11 Mar 2026 12:25:59 +0000 From: Mostafa Saleh To: Catalin Marinas Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, robin.murphy@arm.com, m.szyprowski@samsung.com, will@kernel.org, maz@kernel.org, suzuki.poulose@arm.com, "Aneesh Kumar K.V" Subject: Re: [RFC PATCH 1/2] dma-mapping: Avoid double decrypting with DMA_RESTRICTED_POOL Message-ID: References: <20260305170335.963568-1-smostafa@google.com> <20260305170335.963568-2-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Mar 10, 2026 at 01:55:52PM +0000, Catalin Marinas wrote: > On Tue, Mar 10, 2026 at 01:36:08PM +0000, Catalin Marinas wrote: > > However, it's unclear to me whether we can get encrypted pages when > > is_swiotlb_for_alloc() == false, remap == true and > > force_dma_unencrypted() == true in dma_direct_alloc(). > > dma_set_decrypted() is only called on the !remap path. > > Ah, I can see Anneesh trying to address this here: > > https://lore.kernel.org/r/yq5abjjl4o0j.fsf@kernel.org I see, thanks for pointing that out, the case Aneesh is fixing is the missing decryption in the remap case. However, it’s not clear to me how we can get there for CCA, I left a comment on his patch. I can inline the is_swiotlb_for_alloc() checks outside, but I believe adding this in the lowest level is better as indeed the memory is decrypted and we don’t have to open code the check in other places are dma_direct_alloc_pages() Thanks, Mostafa > > -- > Catalin