From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A786330D23 for ; Wed, 11 Mar 2026 13:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773235639; cv=none; b=QnhmvbKd5WQoJvsAT4zoV4E16zEdLNBWJSsyO6MNU05TD55PTFbca+i8mMk7MqmLM/38XnvHx+/poZV2B0DvEWnYRzOiHXTCdQFxzyL8xAfQ4j6zwQO+qmMfYnN/SgqLbnBRWOmeHe7L0e2tMKtDodXVP6gKwbELO2itAQfrcQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773235639; c=relaxed/simple; bh=/+HfC0VLOHOYiC4gOIJJuTEqnh6faMoEQFWnLKZZ05g=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=icYJqL1m89GqwohdVqZ4wzDMjEe+qtov6ijDh7i73lZxX/TO4DCvOwJy2IavN150hciKSbm+PqOQ8aWQafBea7uOKjbUaTAceoPy7HlQsw7DX+HTWuSdhO5P6aPOlLcD3+f3DE3nW6VxC6IOYE/os6nlzN0NZk1AS+XM8agWRPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=C3cBT+JT; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="C3cBT+JT" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2adc527eaf5so87757165ad.0 for ; Wed, 11 Mar 2026 06:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1773235636; x=1773840436; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=cN43ZNEJkhJjC9vRm/4z1rElsxe6XAfZLnQLbd78RCo=; b=C3cBT+JTOQ2DZmdAWtNL4AdOtuUI+6VkZYoou84LwfRbDVQwSPT37k+kz7pW+Ve9Ov K1y8hzRoruJ/k9TMG2ib6WAuUl7qasmfisBhoZV0g2YCnE9YX1mqFa2dH/zonvx3iWQ2 2D70ltDL7hZXUz0pMvB60RBP3TnWhzQ3TScIuqpudokyK2X2tWVX0KxPhiE7PvEO+aLf fptRMlY5u89gn+MId3qJaA7gr6irx8NJQ6dda82QtRBo13eSQViQoBTKkcWtnpOWKs1D S9R8HUD73yrASYUt5kr1srLf6NxFX+kcAu4upLkLVZw0FKzHPiCfYpzQDoA6oVoRTCUC h0jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773235636; x=1773840436; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cN43ZNEJkhJjC9vRm/4z1rElsxe6XAfZLnQLbd78RCo=; b=tuLQG/BQeIwEBqLNMGC3eTI2lK+8WROBQVL7g0Oq/833MjHowaUgXWz+1wXsN1tyrN JF7kmSft3V59dpBuJrrPqV689EBEVzQIq+1QYP5BoKiV4aB2zHULPsLbrwS9cES/8dpk yfDSQr+nDOQ0jS9jo9UPF7G8UtSgtspPvAShK8W4c4xomWq1XSOfxKq08+eYEOWsdy8b F2l669PI7rUHSGCRkSuDYk6jVkE5dQup3tLmbWKq96BiukbMiR2lmTOoDc1dLV+LEgJD gSWHyjVifFP5Hvdk7mKtvQM7znWg/JcpnXnR15YYrt8Oj4I3swcMie/cMedEMzwLn58s Nwgg== X-Forwarded-Encrypted: i=1; AJvYcCVNBFgEX+9yAUHW3fakTzBcLKSr2fg27mF67Xncj/yJhBXESNUEg37NVx3eXiO/r8V1LwJ3cK1tKDNlecc=@vger.kernel.org X-Gm-Message-State: AOJu0YxX9n2S32dXaStwHd8uBBc6/fPPfe4xxUbA2qMeui02L7RayR1p zP2vN8TmP+WEEdTYNsIjBqMVtd7Kp1Y7K9o1eCGAatU7UpZIB9GpK7YiS9OQp1aq2QEzeBf7p8S DHnLDmg== X-Received: from plnu3.prod.google.com ([2002:a17:903:1a43:b0:2a9:5ed9:f590]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:1249:b0:2ae:4409:5993 with SMTP id d9443c01a7336-2aeae90f919mr25288955ad.55.1773235636399; Wed, 11 Mar 2026 06:27:16 -0700 (PDT) Date: Wed, 11 Mar 2026 06:27:14 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260310224546.2582118-1-seanjc@google.com> <20260310224546.2582118-3-seanjc@google.com> Message-ID: Subject: Re: [PATCH 2/2] KVM: x86: Suppress WARNs on nested_run_pending after userspace exit From: Sean Christopherson To: Yosry Ahmed Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Mar 10, 2026, Yosry Ahmed wrote: > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index 879cdeb6adde..cad16c83dcff 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -12090,6 +12090,13 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu) > > if (r <= 0) > > goto out; > > > > + /* > > + * If userspace may have modified vCPU state, mark nested_run_pending > > + * as "untrusted" to avoid triggering false-positive WARNs. > > + */ > > + if (vcpu->arch.nested_run_pending == KVM_NESTED_RUN_PENDING) > > + vcpu->arch.nested_run_pending = KVM_NESTED_RUN_PENDING_UNTRUSTED; > > + > > Why not inside kvm_x86_vcpu_pre_run()? That, is a very good question. /facepalm